tangentlabs / django-fancypages

86%

master: 84%

LAST BUILD ON BRANCH feature/simplify_form_loading

branch: feature/simplify_form_loading

CHANGE BRANCH

x

Reset

• feature/simplify_form_loading
• 0.3.0
• develop
• experimental/froala
• feature/add_configurable_form_block
• feature/add_editor_panel_cookie
• feature/add_language_support
• feature/increase_test_coverage
• feature/make_siblings_available_in_navigation_block
• feature/switch_to_marionette
• feature/use_asset_library
• feature/user_login_standalone_sandbox
• fix/browser_test_screen_size
• fix/django17_post_release_migrations
• fix_factories
• issue/33/support_for_django17
• issue/50/fix_oscar_templates
• master
• refactor/add_translations
• refactor/integrate_with_oscar
• refactoring
• release/0.2
• release/0.3
• requires-io-master
• temporary_fix_not_recommended
• test/branch_for_some_testing

Build # 179

Build Type

push

travis-ci

Committed by elbaschid

Commit Message

Improve form handling for content blocks

Using custom forms for content blocks can be problematic and cause
circular import issues. It is also quite tricky to simply modify a form
for an existing content block.

I am "fixing" this limitation by making it possible to register forms
for content blocks using ``register_block_form``. When a form is
required for a content block, the previous functionality is still
working the same. However, if a form is registered for a model, it takes
precedence and is returned when the form class is looked up for this
block.

This in itself does not avoid circular import. To avoid this issue,
forms can now be specified using import paths such as
``fancypages.dashboard.forms.BlockForm`` and are only imported the first
time the form class for a model is looked up. At that point all models
should be fully loaded.

Run Details

65 of 65 new or added lines in 6 files covered. (100.0%)

2207 of 2559 relevant lines covered (86.24%)

6.88 hits per line