supabase / supavisor

46%

main: 63%

LAST BUILD ON BRANCH do-not-use-meck-when-testing-metrics-controller

branch: do-not-use-meck-when-testing-metrics-controller

CHANGE BRANCH

x

Reset

• do-not-use-meck-when-testing-metrics-controller
• add-instance_id-to-metrics-metadata
• add-location_id-to-global-metadata
• add-mix_audit
• add-sobelow-security-report
• bump-version
• case-insensitive-names
• change-caputre-verbisity-in-tests
• chore/bump
• chore/bump-poolboy
• chore/bump-to-v2.6.0
• chore/bump-version
• chore/bump-version-2.6.2
• chore/bump-version-2.7.3
• chore/make-fixes
• chore/remove-version-bump-check
• chore/supa_poolboy
• chore/tool-versions
• chore/update-dependencies
• chore/update-pg_query
• cleanup-credo-issues
• cleanup-metrics-gathering
• cleanup-network-metrics-gathering
• correctly-cleanup-metric-tables
• create-separate-tenant-for-stats-test
• da/fix-compromise
• do-not-delete-metrics-in-syn_handler
• do-not-fix-db-version-in-migrations
• do-not-handle-errors-in-postgres-libcluster-strategy
• do-not-have-time-limit-in-test
• do-not-verify-tls-cert
• docs/envs-description
• docs/typo-in-readme
• etienne/sec-456-support-password-auth-in-pooler
• etienne/sec-488-support-jit-access-in-supavisor
• even-more-missing-verify_none-options
• fail_fast-in-integration-tests
• feat/add-cluster-metrics-plugin
• feat/better-memory-metrics
• feat/change-user-credentials
• feat/configurable-retries
• feat/health-check
• feat/large_heap
• feat/manually-written-appups
• feat/metadb-ipv6
• feat/postgres-errors-on-scram-errors
• feat/prepared-statements-support
• feat/promex-refresh-hot-reload
• feat/proxy_ports
• feat/ranch-instances
• feat/ssl_req_macros
• feat/telemetry-client-connection-age
• feat/use-multicast-instead-of-cast-in-loop
• fix-e2e-case-to-use-transaction-connections
• fix/authn-retry
• fix/backport-directory-check
• fix/cancel
• fix/config-logger
• fix/config-regression
• fix/correct-vault-enc-key
• fix/create-schema-before-migrations
• fix/data-race
• fix/dialyzer-and-404-on-metrics
• fix/dont-restart-pool-without-need
• fix/fork-promex-phoenix-plugin
• fix/integration-test-tag
• fix/logflare-backend-conformance
• fix/logging
• fix/logs-context
• fix/metrics-cleaning
• fix/redact
• fix/stop-db-hadler-on-owner-death
• fix/syn
• fix/tests
• fix/websocket-hanging
• hauleth/pool-124-connect-coveralls-to-the-supavisor-ci
• ignore-tasks-in-coverage
• ignore-tests-support-in-coverage-report
• ignore-tmp
• infinity-retry
• json-log-format
• la/get_tenant_cache
• la/get_user_cache
• la/handle-db-auth-tests
• la/pg_auth_methods
• la/ssl-connection
• la/tenant_controller_tests
• la/tenants_context_tests
• la/use-dbhandler-checkout
• lower-log-level-when-removing-stopped-listener
• main
• ne/libclang
• parallel-coverage-reporting
• patch-1
• plarson/fix-openapi-schema-required-fields
• pooler-127
• pooler-131-update-erlang-otp-to-27
• pooler-132-update-elixir-to-1_18
• pooler-138
• postgres-switching
• prepare-release
• refactor/improve-statems
• refactor/protocol-server-cleanup
• refactor/remove-dead-code
• refs/pull/575/merge
• release-v2.4.15
• remaining-peer-verification-setup-in-OTP-27
• remove-commented-out-code
• remove-duplicated-configuration-entry
• remove-unused-module
• rename-host-metadata-field-to-avoid-conflict
• run-tests-on-main
• security-token
• submit-dependencies-to-github
• tag-flaky-test
• test/cascade-drop-schema-in-integration-tests
• test/deno-bun
• test/integration-test-for-stats-on-other-node
• test/skip-flaky-bun-deno-test
• typo-in-api-schema
• unload-mecked-module
• update-dependencies
• update-erlang-and-elixir
• update-mailmap
• update-runner-image-for-version_updated
• update-rustler
• use-built-in-json-module
• use-iodata-for-metrics
• use-location_id-for-cluster-identification
• use-proper-output-in-mix-tasks
• use-sarif-output-for-credo-report
• v2.7.0

Build # 573281b867f53800ec74727603c241ee1ec9d555-PR-593

Build Type

Pull #593

github

Committed by hauleth

Commit Message

test: do not use `meck` when testing metrics controller

Not only it is not needed, it was harmful, as it was incorrect (the mock
wasn't removed after test), which was causing some other tests to fail
unexpectedly.

Pull Request Pull Request #593: test: do not use `meck` when testing metrics controller

Run Details

6 of 6 new or added lines in 1 file covered. (100.0%)

14 existing lines in 4 files now uncovered.

967 of 2088 relevant lines covered (46.31%)

635.48 hits per line