sul-dlss / wasapi-downloader

94%

main: 81%

LAST BUILD ON BRANCH 42-validate-settings

branch: 42-validate-settings

CHANGE BRANCH

x

Reset

• 42-validate-settings
• 15-parse-cmd-line-args
• 20-auth-networking_jm-settings-fixup
• 20-authenticate-networking
• 30-get-all-the-result-pages
• 49-date-formatting
• 54-arg-override_and_outputDir
• 70-45-more-settings
• 78-readme
• 79-update-build
• 81-single-file-download
• 81-single-file-download_settings-tests
• abolish-underscores
• add-settings
• autoupdate-20200513224805
• cap-updates
• checkstyle
• crawl-selection
• crawl-selector
• deletetestbranch
• dependabot/bundler/rake-13.0.1
• download-works
• file-manager
• filelist-req-hookup
• fixups
• long-size
• main
• master
• master-to-main
• mingledbranch
• mjgiarlo-patch-1
• move-validate-checksum
• networking-fixup
• readme-tweaks
• readmeUpdates
• refactor-wasapiconnection
• resume
• settings-updates
• shared-config-settings
• shared-configs
• t126-store_time
• tommytestbranch
• tweak-pr113
• update-dependencies
• v1.0.0
• v1.1.0
• v1.1.1
• validate-checksums
• wasapi-update

Build # 194

Build Type

push

travis-ci

Committed by jmartin-sul

Commit Message

add validation of settings values, add tests for validation

* add apache commons-validator as a dependency (v1.6) so that we have a tool that handles URL validation properly.
* add a protected WasapiDownloaderSettings no arg constructor, to allow for easier testing.
* existing WasapiDownloaderSettings calls validateSettings() (which calls out to some supporting methods, and throws an exception if settings are improperly configured).
* tests

Run Details

282 of 300 relevant lines covered (94.0%)

0.94 hits per line