sul-dlss / preservation_catalog

97%

master: 98%

LAST BUILD ON BRANCH small-refactor

branch: small-refactor

CHANGE BRANCH

x

Reset

• small-refactor
• 010918-workflow-try3
• 1.7.0
• 10_gb
• 112-fix-migration
• 1202-api-endpoint-for-checksums
• 1202-api-endpoint-for-checksums_jm-touchup
• 136-add-index-to-endpoint
• 147-MoabStorageDirectory
• 177-MV-create
• 186-PreservedCopy
• 186-preservation_copy_straggler
• 203-start-using-transactions
• 225-n-240-POH_result_handling
• 228-enums
• 228-final-enums
• 228-final-enums_touchups
• 228-status-enums
• 235-move-size
• 267-check-ext-from-disk
• 268-raketask-m2c
• 273-flag-for-seed_catalog
• 275-document-seed
• 281-db-readme
• 284-check-exist-in-poh
• 284-check-exist-in-poh_final_cut
• 284-check-exist-in-poh_pre-commit-squashing
• 284-check-exist-in-poh_rebased
• 285-update-version
• 288-timestamps
• 2nd-worker-vm
• 311-duplicate-exists
• 318-invalid_moab-status
• 32-add-honeybadger
• 325-log-MV-errors
• 325-log-MV-errors-additions
• 338-db-readme
• 342-remove-storage-root-db
• 343-rake-populate-root
• 347-activerecord-caching
• 347-fewer-db-lookups
• 353-add-statement
• 353-refactor_confirm_version
• 353-refactor_confirm_version_rebased
• 381-README
• 393-stub-check-existence
• 3rd-endpoint
• 476-order-spec-for-sql
• 478-update-db-object
• 483-add-po-pc-version-match
• 483-m2c
• 484-dedup-results
• 496-use-storage-dir
• 519-follow-up-c2m-sql
• 572-rename-cv-methods
• 596-add-cv-success-code
• 604-close-but-possible-bug
• 604-data-to-sigcat
• 604-squash-commits
• 68-basic-rake
• 766-c2m-bad-status-only
• 793-more-endpoint-endpointtype-prescopy-tests_n_some-indexes
• 793-target-archive-endpoints-followons
• C2M_single_druid
• HashEachMethods
• POH-AR-rescue-centralization-etc-etc
• POH-takes-endpoint
• POH-update_version-differentiates-by-endpoint-class
• README-tweaks
• active_job_railtie
• add-CV-errors
• add-calling-method-rough
• add-cap-shared-configs
• add-comment-links-to-485
• add-description
• add-detail-result-message
• add-openapi-1216
• add-profiler-single-root
• add-query
• add-rspec-tests
• add-sdr-transfer-setting
• add-storage-trunk
• add_desc_for_seed_catalog_task
• add_druid_info_to_json
• addition-logging
• additional-rspec
• all-roots
• allow-null-versions
• amcollie_1319
• amcollie_1321
• amcollie_1321_b
• amcollie_1388
• apc-to-zip-part
• apc-to-zipped-moab-version
• apc-to-zmv-new
• apc_factory_version
• apc_parts
• apcp-to-zip-part
• application-controller-logging
• archival-ep-by-factory
• archive-endpoints-guard
• archive-ep-delivery-class-config
• archive-pres-copies
• archive-pres-copy-rpsec
• archive_pcs
• assorted-touchups
• atz_test
• aud-results-contains-code
• audit-check-logging-tweak
• audit-details-for-moabs
• audit-details-in-db
• audit-namespace
• audit-owns-m2c
• audit-results-actual-version
• audit-results-msg-prefix
• audit-results-revisions
• audit-results-spec
• audit-results-symbols
• audit-status-in-db
• audit-timestamps
• audit_module
• auditwf-bug
• aws-profiles
• aws_worker
• azanellaCv
• brawndo
• brawndo_2
• bug-template
• bugfix
• by-druid
• c2a-audit-check
• c2a-logging
• c2m-bad-status-only
• c2m-bugfix
• c2m-check-audit-req
• c2m-class
• c2m-handle-pc-status-already-bad
• c2m-instance
• c2m-specs
• c2m-todo-comments
• c2m-version-checking
• c2m_quuuuu
• cache-cleaner
• cache_cleaner
• cap
• cap-rake-seed-catalog
• cap-resque
• cap-resque-pool
• cap-seeding-fix
• cap-shared-configs-revert
• cap-stage
• cap-to-new-machines
• case_statement_refactor
• catalog-has-moab-not-disk
• check-exist-spec-reduction
• check-exist-specs
• check-existence-revalidates-on-bad-status
• check-existence-skips-bad-status
• checklist-template-tweaks
• checklist-tweaks
• checksum-debug
• checksum-errors
• checksum-validate-disk
• checksum-validation-testing
• checksum-validator-stub
• checksum_persistence
• checksum_validate_disk_all_endpoints
• class-comment
• class_order_wrapper
• clean-up
• cleanup-routes
• cleanup_resque-pool_pid
• complete_moab_test
• confirm-version-redo
• consolidate-pools-1122
• content-diff-endpoint
• content-diff-fix
• content-sub-dirs
• content-subdirs-setting
• controller-opt-arg
• controller-take-diff-druid
• core-be-gone
• count-workers
• create-after-validation
• create-audit-wf
• create-with-validation
• create_missing_pres_wf_1258
• create_route
• create_validator_class
• cron
• crontab-edit
• cv-audit-name
• cv-bug
• cv-by-root-by-status
• cv-fail-upd-pc-status
• cv-fail-upd-pc-status--honest-set_status_as_seen_on_disk
• cv-hookup-after-save
• cv-online-only
• cv-pairing
• cv-sig-cat
• cv-timestamps
• cv_async
• cv_job
• cv_oo
• cv_queue
• date_format
• db-readme
• db-readme-improvements
• db-readme-schema
• db-update-msg
• defaults_good
• delivery_job_cleanup
• dep-upd
• dependabot/bundler/puma-3.12.2
• dependabot/bundler/puma-3.12.3
• dependabot/bundler/rack-2.0.8
• dependent_through
• deploy
• deploy-multiple-prod-vms
• deploy-sds-test
• deploy-seeding-path
• diagram_stubs
• disable-ddl
• disable_csrf
• dockerize
• documentation
• dor-wf-service-gem
• dvz-model-specs
• dvzp-size-md5-tests
• elsif-to-else
• elsif-to-else_polish
• end-of-slush-touchups
• endpoint_name_to_storage_location
• err-msgs
• exit-codes-etc
• extract_validator_class
• fh_close
• fh_close_2
• fix-DSC-druid-param
• fix-archive-pres-copy-creation
• fix-bucket-name
• fix-cron-sched
• fix-db-readme-diagram-link
• fix-druid
• fix-gem-groups
• fix-log-results-merge-issue
• fix-part-audit-ibm
• fix-stray-pcs
• fix-stray-pcs_follow-on
• fix-typo
• fix_build
• fix_type_error
• fix_zipmaker
• follow_up
• gem-group-touchups
• grammar-fix
• help
• honest-set_status_as_seen_on_disk
• host_settings_robustness
• hot-swap
• ibm-cloud
• ibm-cloud-rebase
• improve-audit-timestamps
• improve-timestamp-specs
• index-db-dates
• jcoyne-patch-1
• jmartin-sul-patch-1
• julianmorley-patch-1
• justinlittman-patch-1
• jwt
• jwt-fix
• jwt-groundwork
• less_flush
• less_host_settings
• linked-data-model
• list-druids-on-MoabStorageRoot
• list-druids-on-MoabStorageRoot_cursor-impl
• live_aws
• log-msgs
• logger
• logger_chain
• m2c-incoming-lt-catalog
• m2c-list-of-druids
• m2c-rake
• m2c-single-druid
• m2c-sql
• m2c_quuuuu
• make-logging-more-intelligent
• master
• migration-weekend
• misc-poh-refactoring
• misc-polish
• missing_moab_1184
• missing_workflows_dwc#139
• mjgiarlo-patch-1
• moab-storage-root
• moab-storage-service
• moab-to-catalog-touchups
• moab-validation-errors
• moab-validation-errors-method
• moab-validation-tests
• moab-vers-update
• monitoring
• monkeypatch
• more-cron-fun
• more-report-fixup
• move-logger-to_prepare
• move_lib_to_app
• mv-v3.0.0
• mv-v4.0.0
• mysql
• new_sheriff
• newrelic
• ng-update
• nix_spring
• no-weekend-crons
• no_newrelic
• no_nukes
• normalize-prod-data
• normalize_druid_name
• notify-hb
• nrdebug
• object-creation-is-not-an-error
• ok_comp
• okc_logger
• okcomputer-fix-wfs-check
• okcomputer-tweaks
• online_moab_does_not_exist
• order_independence
• overwrite-settings
• part_audit
• pc-to-complete-moab
• pc_spec
• pc_unique_constraint
• plexer
• plexer-refactor
• plexer_logic
• po2pc
• po2r
• po2r-scheduling-etc
• poh-add-opt-arg
• poh-online-only
• poh-only-online-only
• poh-optional-indicate-cv-ran
• poh-to-pc-refactoring
• poh_go_oo
• poh_spec_refactory
• poh_specs_revamp
• pohandler-refactor
• pohandler-refactor_touchups
• pohandler-results
• pohandler-spec-refactor
• pohresults_spec-revisions
• policy_cache
• pr-template
• prefix_workflows_1267
• pres-copy-expired-fixity-scope
• pres-copy-has-version
• pres-copy-status-name-touchups
• pres-policy-factory
• prod-log-level-info
• profiler_without_rails
• prolifer_oneliner
• purge_constants
• push-events-1357
• queue_semantics
• quick-fix
• quiet-moab-rep-audit
• quiet_tests
• quobyte
• rails-logger-warn
• rails-upgrade
• rails_already_requires
• rails_helper_no_rake
• rake-task
• rake-task-druid
• rake-tasks
• rake-tasks-c2m
• rakefile-fun
• random-touchups
• readme-tweak
• readme_after_rename
• redis
• redis_readme
• reenable-moab-file-checksum-mismatch
• refacor_pohr_confirm_version
• refactor-models
• refactor-poh-specs
• refactor-pohandler-spec
• refactoring-happens
• remove-double-logging-cronjob
• remove-dup
• remove-dup-cv-fail-statuses
• remove-east-endpoint
• remove-empty-clauses
• remove-interpolation
• remove-namespaced-druid-conditionals
• remove-obsolete-comment
• remove-redundant-moab-storageobj-method
• remove_deprecated_fixtures
• remove_old_benchmarking
• remove_outdated_arg
• remove_outdated_arg_and_alias
• remove_permit
• rename-methods
• rep-audit-queued-by-zip-end
• rep_recorder
• replace_ar
• replication_trigger
• replication_trigger_2
• replication_trigger_3
• reporter-comments
• reporting-fix-and-touchup
• request-spec
• requests-specs-oops
• resolve_replace
• resque
• resque-backend
• resque-bug
• resque-config
• resque-pool
• resque-pool-env
• resque-queue-prefix
• resque_rake_setup
• resque_tasks
• results-constants
• results-rename
• retrieve-moab-file
• revert-a8f9d2f
• revert-metadata-refactor
• rm-sds
• rm-zip-checksum
• rm_load_fixtures
• rm_normalize_druid_name
• rm_profiler
• rspec-random
• rubocop
• rubocop-off
• rubocop_todo
• ruby-upgrade
• schedule-cv
• scope_without_arel
• scope_without_arel_rebased
• scope_without_arel_rebased_on_master
• sds
• seed-with-validation
• seeding-timestamp-statements
• selectable-checksum-test
• send_errors_workflow
• settings_env_override_in_bash
• setup-resque
• shared-examples-rspec
• shared_configs
• shelve-diff-fix
• split-rakefile
• spring_cleaning
• stage-deploy
• stage-deploy-tweaks
• status-and-details
• status-invalid-moab
• status-ok-vs-default
• status-to-integer
• storage-migration-template
• storage-trunk-rename
• stringify-parts-count
• subsume_endpoint_type
• switch-checksums-to-post
• switch-to-log-level-prod
• t1087-delete_locks
• t1087-delete_locks2
• t1087-redis-config
• t1139-move_moab
• t1158-MoabToCatalogJob-path-optional
• t1159-multi_storage_roots
• t1229-404
• t1243-api_docs
• t1307-s3
• t1308-okcomputer
• t1322-migrate_task
• t1322-migrate_task-single_update
• t1406-circle
• target-archive-endpoints
• target-archive-endpoints_query-experiments
• template-tweaks2
• test-cv-async
• test-cv-on-stage
• test-fix
• test-results-not-behavior
• test-stack-trace-help
• test_scope_without_arel_rebased
• time-parse-no-zone
• timezone-parse
• transactional_tests
• travis-faster
• turn-off-provenance-logging
• turnon-honey
• tweak-rake-reports
• undo-east-migration
• unneeded_require
• upd-dependencies
• upd-deps
• upd-shared_configs-on-deploy
• update-audit-timestamp
• update-dependencies
• update-dependencies-fix-frozen-string-rubocop-rspec
• update-dependencies-fix-rubocop-errs
• update-deps
• update-gems
• update-moab
• update-moab-versioning
• update-noko
• update-parser
• update-readme
• update-vers-errors-for-wrong-po-vers
• update-version-after-validation
• update-version-timestamps
• update-via-rest
• update-workflow-calls
• update-workflow-to-completed
• update_code
• update_dependencies
• update_route
• update_schema
• update_sdk
• upgrade_workflow
• upload-file-not-put
• us_east_1
• use-correct-part-audit-class
• use-correct-part-audit-class_enum-impl
• v0.1.0
• v0.10.0
• v0.11.0
• v0.12.0
• v0.2.0
• v0.2.1
• v0.3.0
• v0.3.1
• v0.3.2
• v0.4.0
• v0.4.1
• v0.5.0
• v0.6.0
• v0.6.1
• v0.6.2
• v0.6.3
• v0.6.4
• v0.6.5
• v0.6.6
• v0.7.0
• v0.7.1
• v0.7.2
• v0.7.3
• v0.7.4
• v0.7.5
• v0.8.5
• v0.9.0
• v1.0.0
• v1.0.1
• v1.1.0
• v1.10.0
• v1.11.0
• v1.2.0
• v1.3.0
• v1.4.0
• v1.5.0
• v1.6.0
• v1.6.1
• v1.7.0
• v1.8.0
• v1.8.1
• v1.9.0
• validate_disk_endpoint_name
• validity-unknown-status
• var_change_archive_to_zip
• vers-mismatch-result
• version-api-1206
• version-mismatch-report-results
• versioned-api-readme-touchups
• west_2
• wf-fix-regex
• wf-use-comment
• wfreporter-touchup
• whenever-audits
• whenever-experiment
• whenever_roles
• wip_scope_without_arel
• workaround
• worker
• workflow-client
• workflow-code-stuff
• workflow-testing
• workflows-get-more-more-info
• workflows-gets-more-info
• workflows-msgs-revised
• write-md5
• wwhy_am_i_passing
• zfs
• zfs2
• zip-checksum-table
• zip-command-edit
• zip-debug
• zip_cache_cleaner
• zip_chunks
• zip_endpoint_refactor
• zip_endpoint_touchups
• zip_evaluation
• zip_output_capture
• zipmaker_worker
• zmv_replicate_consistent_return_type
• zp_s3key_correct_version

Build # 1556

Build Type

push

travis-ci

Committed by tallenaz

Commit Message

Use pres_copy.matches_po_current_version? where we can

  Found this small refactor while working on another issue

Run Details

588 of 604 relevant lines covered (97.35%)

71.99 hits per line