strongloop / loopback

90%

master: 90%

LAST BUILD ON BRANCH fix/crash-in-verifyUserRelations

branch: fix/crash-in-verifyUserRelations

CHANGE BRANCH

x

Reset

• fix/crash-in-verifyUserRelations
• 2.x
• 2.x-backport
• 2.x-eol
• 2.x-latest
• 3.x-latest
• 3.x/update-dependencies
• acl-apidoc-fix
• add-codeowner
• add-node-10
• add-validate-updateAll
• backport/babel-es6-to-es5
• backport/do-not-allow-duplicate-role-names
• bajtos-patch-1
• catch-err
• change-status
• chore/add-node-12
• chore/improve-issue-templates
• chore/update-juggler
• copyright
• copyrights
• create-issue-pr-templates
• declarative-nest-remoting
• disable-context-tests
• drop-node-4x
• drop/node-0x
• empty-password-lb3
• empty_password
• eol
• feat/maintenance-lts
• feature/access-scopes
• feature/access-token-scopes
• feature/change-password-api
• feature/detectUserConfig
• feature/enable-email-verification-replay
• feature/object-storage
• feature/refactor-access-token-id
• feature/remove-model
• feature/set-password-with-token
• fix-acl
• fix-comma-dangle
• fix-crash-when-replacing-unknown-user
• fix-create-id
• fix-dep
• fix-lint
• fix-npm-audit
• fix-translation
• fix/build
• fix/build-2x
• fix/change-password-multiple-users
• fix/change-password-validation
• fix/ci
• fix/dangling-promise-in-test
• fix/debug-statements
• fix/diff-remoting
• fix/eslint-issues
• fix/get-access-context-user
• fix/multi-user-reset-password
• fix/options-in-token-invalidations
• fix/options-in-token-invalidations-master
• fix/principal-type-polymorphic-user
• fix/role-acl-with-multiple-users
• fix/setRemote-updateAll
• fix/travis-config
• fix/unauthorized-current-user-literal-2x
• fix/windows-ci
• fixFilterDef
• fix_type
• ignore-failing-downstream-builds
• improve/github-templates
• juggler-version
• license
• lts
• maintenance/passing-context-options-in-user.verify
• master
• nestRemoting/prevent-endless-relation-recursion
• npm-test
• persisted-model/fix-updateonly-props-check
• production
• remove/lehni
• revert-3541-add-validate-updateAll
• set-default-remote-options
• speed-up-acl-tests
• string-username-email
• test-branch
• test-ci
• test-readme
• translate
• travis
• update-dependencies
• update-dev-deps
• update-eslint-config
• update-juggler
• update-juggler-2
• update-karma-nyc
• update-lts
• update-msg
• update-strong-error-handler
• update-strong-globalize
• update/travis-platforms
• updateonly_feature
• upgrade-nodemailer
• v2.38.2
• v2.38.3
• v2.39.0
• v2.39.1
• v2.39.2
• v2.41.1
• v2.41.2
• v2.42.0
• v3.10.0
• v3.10.1
• v3.11.0
• v3.11.1
• v3.12.0
• v3.13.0
• v3.14.0
• v3.15.0
• v3.16.0
• v3.16.1
• v3.16.2
• v3.17.0
• v3.17.1
• v3.18.0
• v3.18.1
• v3.18.2
• v3.18.3
• v3.19.0
• v3.19.1
• v3.19.2
• v3.19.3
• v3.20.0
• v3.21.0
• v3.22.0
• v3.22.1
• v3.22.2
• v3.22.3
• v3.23.0
• v3.23.1
• v3.23.2
• v3.24.0
• v3.24.1
• v3.24.2
• v3.25.0
• v3.25.1
• v3.26.0
• v3.27.0
• v3.28.0
• v3.5.0
• v3.6.0
• v3.7.0
• v3.8.0
• v3.9.0
• welcome-lehni
• welcome-nitro404
• welcome-zbarbuto

Build # 6263

Build Type

Pull #3934

travis-ci

Committed by web-flow

Commit Message

Fix crash in verifyUserRelations

In the present implementation `verifyUserRelations(Model)` assumes that
`Model.relations.accessTokens` is always set, and as a result may
crash when trying to access `polymorphic` property of that relation.

It seems the intention is to check whether the the following conditions
are met:
 1. a model has a hasMany accessTokens relation
 2. that relation is polymorphic

This commit fixes the problem by accounting for the case where the
accessTokens relation was not correctly set up.

Pull Request Pull Request #3934: fix: resolve customAccessToken warning error that causes app to crash

Run Details

1829 of 2275 branches covered (80.4%)

3 of 3 new or added lines in 1 file covered. (100.0%)

3309 of 3670 relevant lines covered (90.16%)

10189.93 hits per line