strongloop / loopback-datasource-juggler

84%

master: 85%

LAST BUILD ON BRANCH fix/default-value-in-response

branch: fix/default-value-in-response

CHANGE BRANCH

x

Reset

• fix/default-value-in-response
• enable/coveralls
• master
• travis-8
• welcome-lehni
• v3.12.0
• globalize
• test-ci
• welcome-zbarbuto
• test/related-fix
• test/filter-undefined-property
• test/master
• feature/custom-defaults
• update-strong-globalize
• fix/migrate-single-model
• v3.13.0
• feature/relation-properties
• license
• v3.14.0
• feature/correct-model-ctor-name
• fk-update-fix
• test-ci-tv
• optimized-findbyid
• v3.15.0
• v3.15.1
• truongminh-set-datasource-name
• v3.15.2
• add-datasource-tests
• v3.15.3
• fix-ds-constructor
• v3.15.4
• welcome-nitro404
• v3.15.5
• update-codeowner
• v3.16.0
• fix-ci
• embedsMany/optional-default
• feature/remove-model
• v3.17.0
• v3.18.0
• fix/phantomjs
• v3.18.1
• ts-definitions
• v3.19.0
• fix-ts-defs
• v3.20.0
• v3.20.1
• v3.20.2
• fix-lazy-connect
• v3.21.0
• tidy-up-tests
• v3.21.1
• upgrade-deps
• v3.22.0
• good-first-issues-are-not-stale
• fix/destroyall
• fix/apply-updates-from-hooks
• fix/typings
• v3.22.1
• juggler-fix
• control-pr
• make-test-output-concise
• v3.22.2
• kv-types
• update-eslint-config
• datasource-event-type
• update-dev
• fix-list
• fix-list-of-class-instances
• v3.24.0
• start-4.0
• 3.x
• drop-bluebird
• update-lts
• v4.0.0
• update-lts-3x
• v3.24.1
• issue-1622-3x
• exclude-hidden-properties-from-where
• fix-4028
• v4.1.0
• v3.25.0
• fix-1646
• v4.1.1
• v3.25.1
• fix-1645
• v4.1.2
• v3.25.2
• fix-1651
• v4.2.0
• v3.26.0
• fix/types
• v4.2.1
• v3.26.1
• fix/update-apidocs-file-list
• allow-flags-in-options
• v4.3.0
• v3.27.0
• set-default-remote-options
• v4.4.0
• v3.28.0
• feat/memory-connector-index
• feat/execute
• eslint/use-const-not-var
• upgrade-eslint-config-3x
• upgrade-eslint-config
• fix_geo_2.x
• v5.0.0
• v4.5.0
• fix/include-test
• fix/include-test-3.x
• fix/type-defs
• v4.5.2
• v4.5.3
• fix/near-filter-cb
• feat/type-sub-property
• v4.5.4
• v4.6.0
• update/dependency-lodash
• fix/list-format
• 3x/type-sub-property
• 3x/list-format
• fix/default-value-in-response-3x
• test/fix-default-values
• v3.29.0
• v4.6.1
• chg-downstream
• codeowner
• fix/git-file
• fix/git-file-4
• v3.29.1
• v4.6.2
• fix/include-crash-3x
• v3.29.2
• fix/nested-property-resolution
• fix/primitive-datatypes-coercion-3x
• fix/add-index-for-couchdb
• fix/failing-tests
• v3.30.0
• 3.x-downstream
• fix/nested-property-coercion
• fix/nested-property-coercion-4x
• chore/add-node-12
• chore/add-node-12-3x
• v4.6.3
• update-deps
• update-nyc
• fix/postgresql
• v4.6.4
• v3.31.0
• eol
• temp/trigger-downstream-builds-4x
• temp/trigger-downstream-builds-3x
• copyrights
• fix/modification-of-datasource-config
• fix/hooks-with-near-queries
• fix/datestring-ctor
• fix/datestring-ctor-3x
• fix/hooks-with-near-queries-3x
• v4.7.1
• v3.31.1
• v4.8.0
• fix/add-index
• v4.8.1
• readme
• update/ds-declaration-file
• v4.8.2
• fix/coerce-or-operator
• feat/ds-begintransaction
• fix/migrate-errors
• v4.9.0
• feat/reset-datasource
• fix/begintransaction-api
• v4.10.0
• fix/PK-coercion-in-replaceById
• v4.10.1
• dremond_3.x_migrate_errors
• dremond_migrate_errors
• 3x/defaultValueHandling
• v4.11.0
• getMaxListeners
• feat/defaultValueHandling
• v3.33.0
• v4.12.0
• chore/oracle-fielnames
• reduce-identifier-length-4.x
• reduce-identifier-length-3.x
• temp
• temp-3.x
• v4.12.1
• v3.33.1
• fix-datasource-getmodel-typing
• v4.13.0
• improve/github-templates
• v4.14.0
• v3.33.2
• chore/improve-issue-templates
• v4.15.0
• memory/throw-on-malformed-types
• feat/nested-applyDefaultOnWrites
• update-eslint
• fix/datasource-typings
• fix/typo
• v4.16.0
• v4.17.0
• feat/nested-applyDefaultOnWrites-3.x
• v3.34.0
• feat/ignore-matching-default
• feat/ignore-matching-default-3.x
• v3.35.0
• feat/chunked-all-cb
• relational-strict
• copyright
• v4.18.0
• discover-naming
• v4.18.1
• feat/lb4-operation-hooks
• update-uuid
• feat/fix-observer-api
• fix/listener-type
• improve-listener-signature
• v4.19.0
• update-lts-status
• v4.19.1
• v4.19.2
• deprecated-idcol
• update-node-versions
• embedded-parent2
• v4.20.0
• feat/datasource-stop
• v4.21.0
• fix/stop-typings
• v4.21.1
• fix-types/datasource-migrate
• v4.21.2
• nested/fields
• types/execute-nosql
• v4.22.0
• v4.23.0
• 3.x-travis
• feat/execute-db-command
• v4.24.0
• contributing
• contributing2
• pr-template
• test/db2
• template
• discussion
• v4.20.1
• v4.25.0
• 3.x-update-ts
• backport-atomic-upsert
• mem-connector-fix
• v4.26.0
• 3.x-backport-1874
• v3.36.0
• test-3.x-downstream
• v3.36.1

Build # 5070

Build Type

push

travis-ci

Committed by bajtos

Commit Message

Do not apply default values on data from database

Before this change, when a property was configured with a default value
at LoopBack side and the database was returned a record with a missing
value for such property, then we would supply use the configured
default.

This behavior is problematic for reasons explained in #1692.

In this commit, we are fixing DAO operations like `find` and
`findOrCreate` so that they do NOT apply default property values on
data returned by the database (connector).

Please note that most of the other CRUD methods were already not
applying default values on database data as long as the connector
provided native implementation of the operation.

Run Details

4423 of 5557 branches covered (79.59%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

7000 of 8033 relevant lines covered (87.14%)

1847.46 hits per line