stride-nyc / remote_retro

97%

master: 97%

LAST BUILD ON BRANCH fix-react-modal-warning

branch: fix-react-modal-warning

CHANGE BRANCH

x

Reset

• fix-react-modal-warning
• 556
• Remote-Retro-Onboarding-Doc
• a
• action_item_test
• add-border-styling-to-highlighted-ideas
• add-brotli-compression
• add-contact-stride-cta-at-end-of-retros
• add-dev-logger
• add-npm-tdd-script
• add-pairs
• add-spotify-logo
• add-stop-start-continue-prefix-to-grouping-cards
• add-task-for-parsing-out-openssl-version
• add_assignments
• add_env_file
• adds_clipboard_copy_button
• allow-html-in-confirmation-message
• animate-vote-increments
• another
• avoid-retrieval-of-current-user-in-retro-index
• b
• beta-blogpost
• broadcast-to-all-connected-clients
• bug/fix_mocha_watcher_config
• bug/use-regex-for-required-hex-version-in-preflight
• bugfix/allow-users-who-delete-their-last-name-from-google-account-to-join-rr
• bugfix/only-apply-scroll-container-when-there-is-an-idea-for-a-given-column
• bugfix/overflow-shadows
• build/avoid-hanging-async-test
• bump-elixir
• bump-otp-from-22-to-23
• bust-cache-in-phoenix-buildpack
• cache-global-npm-dependencies
• cache-npm-global
• circleci-update-resource-class
• compile-production-assets-on-circle
• convert-eex-templates-to-heex
• convert-stage-change-alerts-to-banner
• default-values-for-name
• defer-honeybadger
• dependabot/npm_and_yarn/ini-1.3.8
• dependabot/npm_and_yarn/jquery-3.5.0
• dependabot/npm_and_yarn/ua-parser-js-0.7.31
• dependabot/npm_and_yarn/websocket-extensions-0.1.4
• deps-updates
• deps/bump-elixir-1.8-1.10
• deps/bump-em-all
• deps/bump-slender-channel
• deps/upgrade-phoenix-to-1.5
• derp
• determine-facilitator-name-from-all-time-users-rather-than-those-present
• enable-our-eslint-on-ebert
• end-to-end-script-only-builds-javascript-bundles-when-they-dont-already-exist
• enhance-retro-email
• enhancement/clean-up-mix-exs
• enhancement/clipboard-copy-feedback
• enhancement/disable-send-action-items-button
• enhancement/ensure-all-users-who-have-ever-taken-part-in-a-retro-are-available
• enhancement/limit-retros-to-75-ideas-in-idea-generation-stage
• enhancement/pointing-label-prompt-for-idea
• enhancement/remove-association-not-loaded-monkeypatch
• experiment-with-landing-page-semantic-ui-features-breakdown
• faster-webpack-builds
• feature/182-close-retros-action-item-distribution
• feature/NONE_FixSpacing
• feature/NONE_UpdateLogo
• feature/action-item-email-participants
• feature/add-ebert-code-review-integration
• feature/add-facilitator-id-to-retros-table
• feature/add-google-analytics
• feature/add-idea-action-and-reducer
• feature/add-prime-directive-welcome-tooltip
• feature/add-test-coverage
• feature/alert-for-facilitator-reassignment
• feature/allow-users-to-submit-action-items-within-groups-interface-during-action-items-stage
• feature/allow-users-to-submit-feedback
• feature/assignees_for_action_items
• feature/close-retros-upon-entering-action-item-distributon-182
• feature/connect-remote-retro-component-to-store
• feature/contributing-guidelines
• feature/disable-transfer-alert-when-closed
• feature/disable-voting-buttons-in-action-items-stage
• feature/display-number-of-votes-left-for-participant
• feature/display-real-time-user-typing
• feature/dynamic-placeholders
• feature/edit-action-item-assignee
• feature/ensure-parity-between-readonly-and-actual-group-label-input
• feature/extract-authentication-helpers-out-into-reusable-plug
• feature/facilitator-sees-typing
• feature/implement-faq
• feature/limit-user-to-five-votes
• feature/link-vote-to-user
• feature/persist-stage-changes-to-retro
• feature/rename-action-item-distribution-stage
• feature/retro-index-345
• feature/retro-participation
• feature/rework-user-reducer-and-actions-to-handle-array
• feature/sort-ideas-by-most-votes
• feature/start-retro-with-prime-directive
• feature/surface-action-items-grouped-by-retro-388
• feature/toggle-display-of-action-items-in-retro-index
• feature/upgrades
• feature/user-can-delete-idea
• features/560
• fix-modal-warning
• fix-react-dev-tools
• fix/dupe-participations
• fix/oauth-rejection-new-users
• fix/terser-webpack-config
• fix/update-buildpack
• fix/user-object-on-session
• fix_scolling
• font-display-swap
• gigalixir
• group-video-chat-with-protections
• group_labeling
• hail-mary/bump-us-to-elixir-1.6.2
• heroku-test
• honeybadger-js
• iex_alias
• johns-first-PR
• layout/users-list-takes-up-less-space-on-smaller-screens
• license-year-bump
• make_idea_lists_scrollable
• master
• mock-auth--and-change-asset-server-for-ngrok-mobile-testing
• new-landing-page-image
• notifications-for-slack
• perf-and-a11y
• perf/avoid-needless-database-hits-for-current-user-where-unnecessary
• performance-avoid-layout-shift-from-images
• performance/leverage-uniqueness-index-with-upsert-to-avoid-extra-db-hit
• performance/optimistic-ui-for-vote-retractions
• persist-and-broadcast-group-names
• persist/stage-changes-to-retro
• plug-canonical-host
• postcss-via-cli
• prefetch-icon-outlines
• preflight
• prompt-users-to-star-repo-in-application
• redux-migration/shift-remote-retro-component-away-from-ideas-on-local-state-168
• redux-migration/shift-retro-stage-from-local-state-to-redux-store-171
• refactor-presence-tests
• refactor/clean-up-retro-channel-join
• refactor/extract-CRUD-of-ideas-out-into-ideas-controller
• refactor/extract-idea-list-sorting-logic-out-into-container-component
• refactor/extract-lower-third-wrapper
• refactor/move-away-from-react-overflow-in-favor-of-custom-overflow-detector
• refactor/normalize-user-presence-relationship-clientside
• refactor/persist-userid-on-idea-records
• refactor/remote-retro-to-redux-v1
• refactor/remove-author-column-from-idea
• refactor/shift-to-redux-ducks-pattern
• refactor/stop-intercepting-presence-diffs
• refactor/votes-persisted-in-their-own-table
• remove-timed-disappearance-of-delete-button
• remove-unnecessary-wrapping-div-from-icon-portal
• responsive
• secrets
• seo-tweaks
• simplification/labeling-and-voting-take-place-in-a-single-stage
• spike/group-video-chat
• spike/remote-retro-to-redux-with-updated-users
• steve-master
• style/ensure-overflow-shadow-is-visible-over-vote-counts-and-idea-group-list
• styles
• task/set-up-continuous-deployment
• test
• test-cla-hook
• test-debugging
• testing-wallaby-chromedriver-supervision
• transition-drags
• translate3dPerf
• travis-modal
• travis/separate-labeling-and-voting-out-into-individual-stages
• ui-tweaks
• update-cimg
• update-copy-for-stage-change-info
• update-deps
• update-faq
• update-privacy-policy
• update-share-retro-link-modal
• upgrade-local-app-to-node18
• upgrade-otp-22-to-24
• upgrade-phoenix-live-dashboard
• upgrade-phoenix-to-1.6
• upgrade-postgres-container-on-circleci
• use-strides-new-web-url
• user-list-becomes-presence-list
• user-list-item-exposes-user-voting-status
• vote-table-spike
• workflow/allow-circle-ci-to-review-pull-requests-from-forked-repos
• workflow/avoid-duplicative-test-run-for-coveralls
• workflow/create-github-templates-169
• workflow/deflake-flaky-end-to-end-tests
• workflow/enable-react-hot-module-replacement
• workflow/update-erlang-elixir-installation-script-with-dynamic-openssl-determination
• workflow/use-wallaby-with-chromedriver

Build # 1050

Build Type

Pull #381

circle-ci

Committed by laumontemayor

Commit Message

moved setting element out of lifecycle

Pull Request Pull Request #381: Fix modal warning in console and tests

Run Details

88 of 91 relevant lines covered (96.7%)

25.54 hits per line