srishanbhattarai / nepcal

88%

master: 79%

LAST BUILD ON BRANCH v0.5.0

branch: v0.5.0

CHANGE BRANCH

x

Reset

• v0.5.0
• brew
• circle-ci
• correctness
• dateconv
• dependabot/add-v2-config-file
• dependabot/go_modules/github.com/davecgh/go-spew-1.1.1
• dependabot/go_modules/github.com/fatih/color-1.10.0
• dependabot/go_modules/github.com/fatih/color-1.11.0
• dependabot/go_modules/github.com/fatih/color-1.12.0
• dependabot/go_modules/github.com/stretchr/testify-1.3.0
• dependabot/go_modules/github.com/stretchr/testify-1.4.0
• dependabot/go_modules/github.com/stretchr/testify-1.5.0
• dependabot/go_modules/github.com/stretchr/testify-1.5.1
• dependabot/go_modules/github.com/stretchr/testify-1.6.0
• dependabot/go_modules/github.com/stretchr/testify-1.6.1
• dependabot/go_modules/github.com/stretchr/testify-1.7.0
• dependabot/go_modules/github.com/urfave/cli-1.21.0
• dependabot/go_modules/github.com/urfave/cli-1.22.2
• dependabot/go_modules/github.com/urfave/cli-1.22.3
• dependabot/go_modules/github.com/urfave/cli/v2-2.3.0
• docs-update
• epoch-independence
• experimental-grpc
• fix-overflows
• master
• more-data
• more-data-2
• move-calendar
• nep-numerals
• panic-fix
• robustness
• stateful-writer
• travis-go113
• v0.3.0
• v0.3.1
• v0.4.0
• v0.6.0
• v1.0.0
• v1.1.0
• v1.2.0
• v2

Build # 134

Build Type

push

travis-ci

Committed by web-flow

Commit Message

fix: Avoid representing BS dates using time package to fix overflows (#24)

Fixes #23 

If a B.S. date (say जेठ 32) is represented as 02/32 (which was the case right now), toTime will (obviously) interpret it as Feb 32 which is an overflow by 32 - 29 = 3 days. So it's reinterpreted by the time package to be March 3 which is interpreted by nepcal to be असार 3.

This is now fixed by adding a separate struct BSDate.

Run Details

225 of 255 relevant lines covered (88.24%)

276.01 hits per line