square / quotaservice

68%

master: 69%

LAST BUILD ON BRANCH spenceral/versioned-buckets

branch: spenceral/versioned-buckets

CHANGE BRANCH

x

Reset

• spenceral/versioned-buckets
• agorbatchev/dependnecies-update
• alexgorbatchev/update-dependencies
• fix_broadcast_storm
• manik/add_code_coverage
• manik/add_go_1.10
• manik/add_go_versions_to_test
• manik/better_reuse
• manik/bump_go_version
• manik/clean_up_tests
• manik/fix_sync
• manik/optimistic_version_check
• manik/update_vendors
• master
• mysql_persister
• nonint_fill_rate
• patch_flaky_zkpersister_test
• proto3_update
• spenceral/configure-tracing
• spenceral/fix-travis-ui-test
• steved/bucket-accessor
• use_modules

Build # 771

Build Type

Pull #135

travis-ci

Committed by web-flow

Commit Message

Replace Redis flush with versioned keys

The linear-time flush could block Redis's single thread for seconds in
Quotaservice deployments with hundreds of thousands of buckets (or more)
whenever config updates were made. This commit removes flush entirely,
instead scoping a bucket's keys to the current config version. The
existing maxIdleTimeMillis bucket attribute can be used to prune
outdated keys. If the max idle time is not configured for a given
bucket, the bucket factory max idle time will be used as the Redis key
TTL to ensure old keys are eventually removed.

Pull Request Pull Request #135: Replace Redis flush with versioned keys

Run Details

476 of 699 relevant lines covered (68.1%)

22.22 hits per line