square / js-jose

44%

master: 41%

LAST BUILD ON BRANCH mbyczkowski/use-eslint

branch: mbyczkowski/use-eslint

CHANGE BRANCH

x

Reset

• mbyczkowski/use-eslint
• cs/add-coverage
• master
• alok/bugbounty
• alok/testing-travis
• alok/15
• alok/fix-travis
• alok/minor-fixes
• alok/improve-tests
• alok/resolve
• alok/unicode
• alok/readme
• alok/0.1.2
• v0.0.3
• v0.1.0
• v0.1.2
• v0.1.1
• alok/0.1.4
• v0.1.4
• v0.1.5
• alok/v0.1.5
• alok/v0.1.6
• v0.1.6
• alok/tests
• alok/build
• alok/minor
• hello-typescript
• alok/v0.1.7
• v0.1.7
• alok/js-jose-fix-example
• alok/ecdsa
• mmc/CLA
• mbyczkowski/import-fix
• mbyczkowski/add-missing-declaration
• mbyczkowski/add-changelog
• mbyczkowski/0.2.0-release
• list
• v0.2.0
• mbyczkowski/bump-node-in-ci
• dependabot/npm_and_yarn/grunt-contrib-uglify-tw-4.0.1
• dependabot/npm_and_yarn/coveralls-tw-3.0.5
• dependabot/npm_and_yarn/grunt-karma-tw-3.0.0
• dependabot/npm_and_yarn/karma-chrome-launcher-tw-3.0.0
• dependabot/npm_and_yarn/qunit-tw-2.9.2
• dependabot/npm_and_yarn/webpack-cli/init-tw-0.2.2
• dependabot/npm_and_yarn/terser-tw-4.1.2
• mbyczkowski/fix-imports
• mbyczkowski/release-2.0.1
• v0.2.1
• dependabot/npm_and_yarn/karma-coverage-tw-2.0.1
• dependabot/npm_and_yarn/eslint-plugin-node-tw-10.0.0
• dependabot/npm_and_yarn/eslint-plugin-jest-23.0.0
• dependabot/npm_and_yarn/eslint-plugin-jest-23.0.2
• dependabot/npm_and_yarn/eslint-plugin-jest-23.0.3
• dependabot/npm_and_yarn/webpack-cli/init-0.3.0
• dependabot/npm_and_yarn/eslint-plugin-jest-23.0.4
• dependabot/npm_and_yarn/eslint-plugin-jest-23.0.5
• dependabot/npm_and_yarn/eslint-plugin-jest-23.1.1
• dependabot/npm_and_yarn/eslint-plugin-node-11.0.0
• mbyczkowski/bump-karma-and-qunit
• dependabot/npm_and_yarn/eslint-config-standard-tw-14.1.0
• mbyczkowski/0.2.2
• v0.2.2
• dependabot/npm_and_yarn/jest-25.1.0
• dependabot/npm_and_yarn/babel-jest-25.1.0
• dependabot/npm_and_yarn/grunt-karma-4.0.0
• dependabot/npm_and_yarn/jest-26.0.0
• dependabot/npm_and_yarn/babel-jest-26.0.0
• dependabot/npm_and_yarn/jest-26.0.1
• dependabot/npm_and_yarn/babel-jest-26.0.1
• dependabot/npm_and_yarn/grunt-eslint-23.0.0
• dependabot/npm_and_yarn/eslint-7.2.0
• dependabot/npm_and_yarn/eslint-7.3.0
• dependabot/npm_and_yarn/jest-26.1.0
• dependabot/npm_and_yarn/babel-jest-26.1.0
• dependabot/npm_and_yarn/eslint-7.3.1
• dependabot/npm_and_yarn/eslint-7.4.0
• dependabot/npm_and_yarn/grunt-contrib-uglify-5.0.0
• dependabot/npm_and_yarn/eslint-7.5.0
• dependabot/npm_and_yarn/grunt-webpack-4.0.2
• dependabot/npm_and_yarn/babel-jest-26.2.2
• dependabot/npm_and_yarn/eslint-7.6.0
• dependabot/npm_and_yarn/terser-5.0.0
• dependabot/npm_and_yarn/karma-5.1.1
• dependabot/npm_and_yarn/babel-jest-26.3.0
• dependabot/npm_and_yarn/eslint-7.7.0
• dependabot/npm_and_yarn/terser-5.1.0
• dependabot/npm_and_yarn/terser-5.2.0
• dependabot/npm_and_yarn/terser-5.2.1
• dependabot/npm_and_yarn/eslint-7.8.1
• dependabot/npm_and_yarn/terser-5.3.0
• dependabot/npm_and_yarn/eslint-plugin-jest-24.0.0
• dependabot/npm_and_yarn/terser-5.3.1
• dependabot/npm_and_yarn/eslint-plugin-jest-24.0.1
• dependabot/npm_and_yarn/eslint-7.9.0
• dependabot/npm_and_yarn/terser-5.3.2
• dependabot/npm_and_yarn/eslint-plugin-jest-24.0.2
• dependabot/npm_and_yarn/eslint-7.10.0
• dependabot/npm_and_yarn/terser-5.3.3
• dependabot/npm_and_yarn/terser-5.3.4
• dependabot/npm_and_yarn/babel-jest-26.5.0
• dependabot/npm_and_yarn/babel-jest-26.5.2
• dependabot/npm_and_yarn/eslint-plugin-jest-24.1.0
• dependabot/npm_and_yarn/eslint-7.11.0
• dependabot/npm_and_yarn/webpack-cli-4.0.0
• dependabot/npm_and_yarn/terser-5.3.5
• dependabot/npm_and_yarn/terser-5.3.6
• dependabot/npm_and_yarn/terser-5.3.7
• dependabot/npm_and_yarn/babel-jest-26.6.0
• dependabot/npm_and_yarn/webpack-cli-4.1.0
• dependabot/npm_and_yarn/terser-5.3.8
• dependabot/npm_and_yarn/babel-jest-26.6.1
• dependabot/npm_and_yarn/eslint-7.12.0
• dependabot/npm_and_yarn/eslint-7.12.1
• dependabot/npm_and_yarn/babel-jest-26.6.2
• dependabot/npm_and_yarn/webpack-cli-4.2.0
• dependabot/npm_and_yarn/babel-jest-26.6.3
• dependabot/npm_and_yarn/eslint-7.13.0
• dependabot/npm_and_yarn/eslint-plugin-jest-24.1.3
• dependabot/npm_and_yarn/terser-5.4.0
• dependabot/npm_and_yarn/terser-5.5.0
• dependabot/npm_and_yarn/eslint-7.14.0
• dependabot/npm_and_yarn/terser-5.5.1
• dependabot/npm_and_yarn/eslint-7.15.0
• dependabot/npm_and_yarn/eslint-7.16.0
• dependabot/npm_and_yarn/webpack-cli-4.3.0
• dependabot/npm_and_yarn/webpack-cli-4.3.1
• dependabot/npm_and_yarn/eslint-7.17.0
• dependabot/npm_and_yarn/eslint-7.18.0
• dependabot/npm_and_yarn/webpack-cli-4.4.0
• dependabot/npm_and_yarn/eslint-7.19.0
• dependabot/npm_and_yarn/webpack-cli-4.5.0
• dependabot/npm_and_yarn/terser-5.6.0
• dependabot/npm_and_yarn/eslint-7.20.0
• dependabot/npm_and_yarn/eslint-plugin-jest-24.1.5
• dependabot/npm_and_yarn/karma-6.1.1
• dependabot/npm_and_yarn/eslint-7.21.0
• dependabot/npm_and_yarn/eslint-plugin-jest-24.1.8
• dependabot/npm_and_yarn/eslint-plugin-jest-24.1.9
• dependabot/npm_and_yarn/karma-6.1.2
• dependabot/npm_and_yarn/eslint-plugin-jest-24.2.0
• dependabot/npm_and_yarn/eslint-plugin-jest-24.2.1
• dependabot/npm_and_yarn/karma-6.2.0
• dependabot/npm_and_yarn/eslint-7.22.0
• dependabot/npm_and_yarn/eslint-plugin-jest-24.3.1
• dependabot/npm_and_yarn/eslint-plugin-jest-24.3.2
• dependabot/npm_and_yarn/terser-5.6.1
• dependabot/npm_and_yarn/karma-6.3.0
• dependabot/npm_and_yarn/karma-6.3.1
• dependabot/npm_and_yarn/webpack-cli-4.6.0
• dependabot/npm_and_yarn/eslint-7.23.0
• dependabot/npm_and_yarn/karma-6.3.2
• dependabot/npm_and_yarn/grunt-contrib-uglify-5.0.1
• dependabot/npm_and_yarn/eslint-plugin-jest-24.3.4
• dependabot/npm_and_yarn/eslint-plugin-jest-24.3.5
• dependabot/npm_and_yarn/eslint-7.24.0
• dependabot/npm_and_yarn/grunt-webpack-4.0.3
• dependabot/npm_and_yarn/eslint-plugin-jest-24.3.6
• dependabot/npm_and_yarn/eslint-7.25.0
• dependabot/npm_and_yarn/terser-5.7.0
• dependabot/add-v2-config-file
• dependabot/npm_and_yarn/webpack-cli-4.7.0
• dependabot/npm_and_yarn/eslint-7.26.0
• dependabot/npm_and_yarn/grunt-karma-4.0.2
• dependabot/npm_and_yarn/eslint-7.27.0
• dependabot/npm_and_yarn/babel-jest-27.0.1
• dependabot/npm_and_yarn/babel-jest-27.0.2
• dependabot/npm_and_yarn/karma-6.3.3
• dependabot/npm_and_yarn/eslint-7.28.0
• dependabot/npm_and_yarn/webpack-cli-4.7.2
• dependabot/npm_and_yarn/karma-6.3.4

Build # 251

Build Type

Pull #99

travis-ci

Committed by web-flow

Commit Message

Use ESLint to ensure uniform and modern JavaScript syntax

js-jose's code has allowed for mixing snake camel case, varying
indentation practices etc. I'm sure this could have been addressed with
proper jshint config, but having used ESLint in the past, it seems to
make a better job at enforcing rules and also auto-fixing small mishaps.

I've picked standardjs.com as the basis for the JavaScript style, with
one omission -- unlike standardjs, js-jose will still use semicolons
everywhere (happy to change it, but seemed like a bigger change that
could happen in a separate PR).

Pull Request Pull Request #99: Use ESLint to ensure uniform and modern JavaScript syntax

Run Details

287 of 1230 branches covered (23.33%)

281 of 281 new or added lines in 1 file covered. (100.0%)

809 of 1856 relevant lines covered (43.59%)

18.72 hits per line