spotify / luigi
78%
master: 67%

LAST BUILD BRANCH: feature/add-datadog-contrib
DEFAULT BRANCH: master
Repo Added
Files 52
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH arash/remove-spammy-email-output
branch: arash/remove-spammy-email-output
CHANGE BRANCH
x

2009

push

travis-ci

Tarrasch 
Don't be oververbose in send_email()

    ERROR: [pid 20172] Worker Worker(salt=640365789, workers=1, host=myhost.spotify.com, username=arash, pid=20172) failed    AppleIAPDailyCohortsLuigiQa(test=False)
    Traceback (most recent call last):
      File "/usr/lib/python2.6/dist-packages/luigi/worker.py", line 87, in run
        task_gen = self.task.run()
      File "/tmp/tmp9vkWs9/python/imported_luigi_tasks/in_app_purchases.py", line 123, in run
        raise Exception()
    Exception
    INFO: Sending warning email to 'dataex-squad+notifications@spotify.com'
    DEBUG: Emailing:
    -------------
    To: ('myhost@spotify.com',)
    From: luigi-client@myhost.spotify.com
    Subject: Luigi: MyTask() FAILED
    Message:
    Runtime error:
    Traceback (most recent call last):
      File "/usr/lib/python2.6/dist-packages/luigi/worker.py", line 87, in run
        task_gen = self.task.run()
      File "/tmp/tmp9vkWs9/python/imported_luigi_tasks/in_app_purchases.py", line 123, in run
        raise Exception()
    Exception
    
    -------------

This is TOTALLY superflous information. Instead, I think we can just keep the
INFO line. The DEBUG line isn't useful even when debugging, because all of the
information is trivially retrieved anyway. Here's what I propose:


    ERROR: [pid 20172] Worker Worker(salt=640365789, workers=1, host=myhost.spotify.com, username=arash, pid=20172) failed    AppleIAPDailyCohortsLuigiQa(test=False)
    Traceback (most recent call last):
      File "/usr/lib/python2.6/dist-packages/luigi/worker.py", line 87, in run
        task_gen = self.task.run()
      File "/tmp/tmp9vkWs9/python/imported_luigi_tasks/in_app_purchases.py", line 123, in run
        raise Exception()
    Exception
    INFO: Sending warning email to 'dataex-squad+notifications@spotify.com'

This should be easier to read.

4004 of 5142 relevant lines covered (77.87%)

3.4 hits per line

Relevant lines Covered
5142 RELEVANT LINES 4004 COVERED LINES
3.4 HITS PER LINE
Source Files on arash/remove-spammy-email-output
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
2009 arash/remove-spammy-email-output Don't be oververbose in send_email() ERROR: [pid 20172] Worker Worker(salt=640365789, workers=1, host=myhost.spotify.com, username=arash, pid=20172) failed AppleIAPDailyCohortsLuigiQa(test=False) Traceback (most recent call last): ... push Tarrasch travis-ci pending completion  
2008 arash/remove-spammy-email-output Merge pull request #718 from steenzout/fix_license_header standardized Apache 2.0 license header push erikbern travis-ci pending completion  
See All Builds (1002)