splunk / splunk-operator
84%
main: 84%

LAST BUILD BRANCH: mvp/app-framework-v1-app-validation
DEFAULT BRANCH: main
Repo Added
Token 92D3mzI62Gz0GSKeMoPT9NrKmmkA35PHB regen
Build 9607 Last
Files 54
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-cel-validation-provider-field
branch: fix-cel-validation-provider-field
CHANGE BRANCH
x
Sync Branches

coverage: 84.06%. Remained the same
24709040351

Pull #1850

circleci

gabrielm-splunk 
Fix CEL validation error when provider field is missing in VolumeSpec

## Problem
After upgrading to v3.1.0, customers encountered validation errors when
updating existing Standalone CRs that were created with previous versions:

```
The Standalone "standalone" is invalid: status.smartstore.volumes[0]:
Invalid value: "object": no such key: provider evaluating rule:
region is required when provider is aws
```

This error occurred because the CEL validation rule added in #1740
attempted to access `self.provider` without first checking if the field
exists. In upgrade scenarios, status fields populated by older operator
versions may not include the `provider` field, causing the validation
to fail with "no such key: provider".

## Root Cause
The original CEL validation rule was:
```
self.provider != 'aws' || size(self.region) > 0
```

This rule evaluates `self.provider` even when the field doesn't exist,
violating CEL's requirement to check field existence with `has()` before
accessing optional fields.

## Solution
Updated the CEL validation rule to:
```
!has(self.provider) || self.provider != 'aws' || (has(self.region) && size(self.region) > 0)
```

This change:
1. First checks if `provider` field exists with `!has(self.provider)`
2. If it doesn't exist, validation passes (allows backward compatibility)
3. Only validates the AWS region requirement when provider is explicitly set to 'aws'
4. Also checks `has(self.region)` before accessing the region field

## Testing
Reproduced the issue by:
1. Creating a Standalone CR with the v3.1.0 CRDs
2. Patching the status to remove the provider field (simulating upgrade scenario)
3. Confirmed the error: "no such key: provider evaluating rule"
4. Applied the fix and verified the same operation succeeds

## Impact
- Fixes upgrade path from pre-3.1.0 versions where status fields were
  populated without the provider field
- Maintains the validation requirement that AWS volumes must have a region
- No impact on new depl... (continued)
Pull Request #1850: Fix CEL validation error when provider field is missing in VolumeSpec

11923 of 14184 relevant lines covered (84.06%)

28.01 hits per line

Relevant lines Covered
14184 RELEVANT LINES 11923 COVERED LINES
28.01 HITS PER LINE
Source Files on fix-cel-validation-provider-field

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24709040351 fix-cel-validation-provider-field Fix CEL validation error when provider field is missing in VolumeSpec ## Problem After upgrading to v3.1.0, customers encountered validation errors when updating existing Standalone CRs that were created with previous versions: ``` The Standalon... Pull #1850 gabrielm-splunk circleci
84.06
24709040323 fix-cel-validation-provider-field Fix CEL validation error when provider field is missing in VolumeSpec ## Problem After upgrading to v3.1.0, customers encountered validation errors when updating existing Standalone CRs that were created with previous versions: ``` The Standalon... Pull #1850 gabrielm-splunk circleci
84.06
24527069419 fix-cel-validation-provider-field Fix CEL validation error when provider field is missing in VolumeSpec ## Problem After upgrading to v3.1.0, customers encountered validation errors when updating existing Standalone CRs that were created with previous versions: ``` The Standalon... Pull #1850 gabrielm-splunk circleci
84.04
24527069454 fix-cel-validation-provider-field Fix CEL validation error when provider field is missing in VolumeSpec ## Problem After upgrading to v3.1.0, customers encountered validation errors when updating existing Standalone CRs that were created with previous versions: ``` The Standalon... Pull #1850 gabrielm-splunk circleci
84.04
See All Builds (9602)

Badge your Repo: splunk-operator

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh