solidjs / solid

76%

main: 89%

LAST BUILD ON BRANCH fix/frames-c18-classify-after-drain

branch: fix/frames-c18-classify-after-drain

CHANGE BRANCH

x

Reset

Sync Branches

• fix/frames-c18-classify-after-drain
• absorb-expressions
• add-code-format
• add-jsx-dev-runtime
• add-names
• add-observable-tests
• add-scheduler-cancel-task-test
• after-create-signal-hook
• after-register-graph
• agent-diagnostics
• allow-null-prototype-in-mutable
• arch/tier1-affects-reveal
• arch/tier2
• at-a-glance
• attribution-folds
• attribution-records
• audit/gabbev-3494
• audit/gabbev-batch2
• audit/post-l2-store-shapes
• bench/polymorphic-chain
• bench/projection-root-write-amortize
• bugfix/656
• bump-pnpm
• bump-workflows
• catch-error-propagation
• change-onerror-mechanism
• changelog-1.4
• changeset-release/next
• checkProxy
• chore/cleanup-stale-gitignore-entries
• chore/compiler-lint-checks
• chore/deprecate-dynamic-component
• chore/fix-h-jsx-runtime-clean-path
• chore/internal-view-protocol
• chore/remove-unused-dependencies
• chore/replace-hope-ui-with-kobalte
• chore/size-observe-attribution-cap-3581
• chore/size-report-fork-prs
• ci/size-limit
• claude/3715-fix
• claude/3729-fix
• claude/3828-fix
• claude/issue-3554
• claude/issue-3557
• claude/issue-3564
• claude/issue-3568
• claude/issue-3576
• claude/issue-3626
• claude/issue-3672
• claude/issue-3698
• claude/issue-3726
• claude/issue-3743
• cleanup
• client-error-hook
• client-only
• codes-source-names
• codex/const-effect-inference
• codex/derived-optimistic-shadow
• codex/directive-source-maps
• codex/fix-shallow-store-hydration
• codex/mount-propagation-seam
• cody-export-dynamic-props
• compiler-optimize-option
• compiler-ssr-props-spans
• context-name
• contributing-build
• createresource-types
• cross-package-fields
• dependabot/npm_and_yarn/babel/core-7.29.6
• dependabot/npm_and_yarn/babel/traverse-7.23.2
• dependabot/npm_and_yarn/cross-spawn-6.0.6
• dependabot/npm_and_yarn/express-4.19.2
• dependabot/npm_and_yarn/express-4.20.0
• dependabot/npm_and_yarn/follow-redirects-1.14.8
• dependabot/npm_and_yarn/nanoid-3.3.8
• dependabot/npm_and_yarn/semver-5.7.2
• dependabot/npm_and_yarn/seroval-1.4.1
• dependabot/npm_and_yarn/seroval-1.5.0
• dependabot/npm_and_yarn/shell-quote-1.7.3
• dependabot/npm_and_yarn/vite-4.4.8
• dependabot/npm_and_yarn/vite-4.5.1
• dependabot/npm_and_yarn/vite-4.5.2
• dependabot/npm_and_yarn/vite-4.5.3
• dependabot/npm_and_yarn/vite-4.5.5
• dependabot/npm_and_yarn/vite-5.4.14
• dependabot/npm_and_yarn/vitest-3.2.6
• dependabot/npm_and_yarn/vitest-4.1.11
• dependabot/npm_and_yarn/word-wrap-1.2.4
• dependabot/npm_and_yarn/ws-8.17.1
• dev-additions
• dev-component-function
• diagnostics-expansion
• doc/casing
• docs/action-await-yield
• docs/create-root-ownership-jsdoc
• docs/design-fit-grid
• docs/diagnostic-guide-sections
• docs/direction-rule
• docs/perf-props-composition-lane
• docs/remote-server-functions-proposal
• docs/rules-index
• docs/size-audits-and-frames-rulings
• docs/solid-element-props-gotcha
• docs/store-list-perf-lane
• doorway-for-class-components
• dynamic-run-hydration-events
• dynamic-splitProps-return-proxies
• error-thrower-path
• examples/hackernews
• export-memo-interface
• export-options-types
• expose-setter-types
• feat-server-value
• feat-store-configurable-unwrappable-types
• feat-store-types
• feat/3055-merge-sibling-templates
• feat/PULL-REQUEST-TEMPLATE
• feat/attribute-slots
• feat/binding-slot-execution
• feat/client-recovery
• feat/compiler-spread-sources
• feat/create-deferred
• feat/dev-unscoped-hole-assertion
• feat/feedback-findings
• feat/frames-live
• feat/graph-growth
• feat/html-braced-comments
• feat/initial-route-declaration
• feat/observe-include-call-live
• feat/observe-request-record
• feat/optimistic-reverted
• feat/performance-tracks
• feat/performance-tracks-server
• feat/public-hydration-api
• feat/request-failure-report
• feat/responsive-preload-links
• feat/responsiveness-findings
• feat/server-function-url
• feat/sse-carrier
• feat/ssr-element-sources
• feat/text-positions
• feat/typed-preload-links
• feat/universal-spread-sources
• feat/wasted-recompute
• feature/store-disallow-setting-readonly
• fix-3081-usehead-head-walk
• fix-3648-lane-uninitialized-landing
• fix-async-render-status
• fix-catch-error-propagation
• fix-client-hole-derived-async-hang
• fix-client-hole-inert-thenable
• fix-create-resource
• fix-create-root
• fix-createselector
• fix-custom-keyof-allowing-number-as-keyof-never
• fix-deep-readonly-mutable-not-recursive
• fix-element-owner-markers-main
• fix-hash-value-bigint
• fix-infinite-loop
• fix-is-server-type
• fix-jsx-runtimes
• fix-lazy
• fix-lazy-hmr
• fix-lazy-timeout
• fix-merge-props
• fix-merge-props-spread
• fix-missing-portal-ref-type
• fix-observable-rxjs-next
• fix-onerror-order
• fix-override-shields-uninitialized
• fix-owner-leak
• fix-prototype-getters
• fix-quotes
• fix-refetch
• fix-refetch-return-type
• fix-renderToStream
• fix-resource-initial-value-inference
• fix-resource-options-type
• fix-run-with-owner
• fix-server-lazy
• fix-set-store-traversed
• fix-set-store-with-index-signature-types
• fix-setter-assignability
• fix-setter-param-type
• fix-signal-setter-generics
• fix-solid-refresh-main
• fix-ssr-response-cancel-abandon
• fix-store-setter-with-complex-types
• fix-store-types-create-store-initial-value
• fix-store-types-generics-and-void-setter
• fix-stores
• fix-suspense-suite
• fix-ts-nodenext
• fix-type
• fix-typo
• fix-unowned-root-dev
• fix-untrack
• fix/2668-leaked-produce-draft-proxy-invariant
• fix/3054-iterable-children
• fix/3186-reusable-event-handler-tuple
• fix/3188-in-place-class-mutation
• fix/3291-tracked-effect
• fix/3733-frame-scoped-mask
• fix/3739-dev-cost-checks
• fix/3767-retained-draft-proxy
• fix/3797-ssr-dynamic-hydration-keys
• fix/3828-hoistprops-ts-types
• fix/action-done-window-batch-adoption
• fix/adopted-unflushed
• fix/affects-first-statement-lane
• fix/align-store-overloads
• fix/ambient-transaction-capture
• fix/anchor-noscroll-type
• fix/async-chain-supersession
• fix/async-iterator-settlement
• fix/async-landing-deps-3461
• fix/async-memo-overlap
• fix/async-setter-error-propagation
• fix/attribution-store-optimistic-revert-3687
• fix/born-held
• fix/capturing-listener-removal
• fix/chunk-reader-hardening
• fix/class-value-undefined
• fix/cleanup-unwind-order
• fix/companion-leaf-release-3503
• fix/compiler-istanbul-comments
• fix/compiler-source-locations
• fix/compiler-wasi-android-preopen
• fix/conditional-async-reveal-pending
• fix/csrf-origin-cross-site
• fix/delegated-event-key
• fix/delegated-event-listener-object
• fix/derived-writes-then-derivations
• fix/dev-exported-twice
• fix/document-live-channel-shape
• fix/dynamic-serialize-adopt-3666
• fix/dynamic-spread-attributes-before-children
• fix/dynamic-xmlns
• fix/errored-fallback-thunk-scope
• fix/f6-boundary-frame-reader
• fix/flatten-needsunwrap-or
• fix/flight-transform-consumer-keyed-3638
• fix/fragment-stylesheet-gate
• fix/frames-refetch-commit
• fix/frames-s-flush-address-source
• fix/frames-server-single-instance-3641
• fix/fuzz-batch-a
• fix/fuzz-batch-c
• fix/gated-reporter-hold
• fix/h-component-handler-props
• fix/h-idempotent-thunk
• fix/held-action-render-effect-3802
• fix/held-conditional-effect-3438
• fix/held-conditional-memo
• fix/held-derivation-not-a-proposal-3612
• fix/held-restore
• fix/held-truth-lane-only
• fix/hide-internal-type-exports
• fix/hole-retry-shared-slot-3815
• fix/html-loading-on-getter-3728
• fix/hybrid-memo-handoff-quiet
• fix/hybrid-store-gate-waits-for-server
• fix/hybrid-store-handoff-quiet
• fix/hydrate-wait-for-records-3610
• fix/hydrating-root-snapshot-scope-3504
• fix/hydration-mock-promise-statics
• fix/hydration-null-owner-and-hybrid-latch
• fix/inherited-dom-properties
• fix/initial-navigation-baseline
• fix/inv4-projection-dispose
• fix/ispending-companion-retention
• fix/ispending-gated-landing-replay
• fix/ispending-in-boundary-on
• fix/ispending-memo-gate-3766
• fix/ispending-memo-unstamped-hold-3457
• fix/ispending-wrapper-suppression-3028
• fix/issue-3734
• fix/issue-3750
• fix/issue-3767
• fix/issue-3769
• fix/l2-3540-fresh-loading
• fix/l2-fuzz-existing-rules
• fix/l2-remaining-bugs
• fix/lane-authority
• fix/lane-authority-next
• fix/lane-frame-children-3662
• fix/lane-read-null-tx
• fix/late-boundary-claim-and-live-slot-range
• fix/latest-conditional-async-gate-3276
• fix/latest-loading-lane-3289
• fix/latest-shadow-owned-write
• fix/live-takeover-pending-boundary-3764
• fix/loading-errored-composition-escape
• fix/loading-lazy-claim-keeps-nodes
• fix/loading-on-frame-following
• fix/loading-on-keyed-boundary
• fix/loading-on-outside-hold-same-source
• fix/loading-reset-collects-forwarded-3459
• fix/lowercase-on-is-attribute
• fix/maparray-index-optimistic-frame-f1
• fix/markheap-mount
• fix/memo-lane-posture-3442
• fix/memo-undefined-in-transition
• fix/merge-stale-sources
• fix/merge-transition-optimistic-dup
• fix/module-exports
• fix/nested-render-effect-cleanup-3404
• fix/nested-server-function-declarations
• fix/null-proto-hasownproperty
• fix/nullish-rejection-status-error
• fix/nullish-ssr-attributes
• fix/omit-fallback-read-through
• fix/oncleanup-reentrant-dispose-3601
• fix/optimistic-draft-reads-compose
• fix/optimistic-draft-visibility-3665
• fix/optimistic-lane-release
• fix/optimistic-move-duplicate-3548
• fix/optimistic-read-lane-not-transaction-3698
• fix/optimistic-settle-scope-f4-f6
• fix/optimistic-settle-verdicts
• fix/optimistic-store-first-flight
• fix/optimistic-undeclared-flight-owner
• fix/optimistic-untracked-reads-f3-f5
• fix/pending-companion-lane-parent
• fix/portal-cleanup-guard
• fix/projection-draft-valid-until-superseded
• fix/projection-root-overlay
• fix/projection-slot-release
• fix/recompute-preserves-disposed-3621
• fix/reconcile-array-object-shape-guard
• fix/reconcile-symbol-keys
• fix/ref-after-attributes
• fix/ref-spread-hydration-parity
• fix/refresh-held-write-reask
• fix/refresh-in-action-3026
• fix/refresh-lazy-hydration
• fix/refresh-memo-unnamed
• fix/render-to-string-sync-dispose
• fix/repeat-disjoint-window
• fix/require-complete-store-seeds
• fix/reveal-composite-readiness
• fix/root-dispose-drains-parked-frame
• fix/runtime-edge-case-regressions
• fix/sanitize-graph-failures
• fix/scheduler-child-queue-removal
• fix/serialized-race-unhandled-rejection
• fix/server-directive-in-method-position
• fix/server-fn-registry-reload-3346
• fix/server-fn-undefined-args
• fix/server-function-boundary-sweep
• fix/server-function-get-instance-header-3406
• fix/server-function-guard-simplification
• fix/server-function-hierarchical-ids
• fix/server-function-this-arguments-capture
• fix/server-function-types-any
• fix/server-module-unsupported-exports
• fix/server-pending-proxy-reads
• fix/settle-unchanged-pending-branches
• fix/shallow-store-leaves
• fix/signals-empty-reexport
• fix/signals-test-types
• fix/slot-prop-hole-scope-3567
• fix/snapshot-symbol-keys
• fix/snapshot-trailing-holes
• fix/sole-child-falsy-primitive-3571
• fix/splitprops-proxy-shared-keys
• fix/srvx-lazy-request-rebuild-3311
• fix/ssr-SuspenseList
• fix/ssr-async-rejections
• fix/ssr-boundary-resolve-scope-3414
• fix/ssr-capture-source-locations
• fix/ssr-class-style-separator
• fix/ssr-createResource
• fix/ssr-element-nullish-attrs
• fix/ssr-response-pre-shell-settle-3719
• fix/ssr-shell-suspend-retry
• fix/ssr-shell-suspend-serializer-flush
• fix/ssr-style-object-separators
• fix/ssr-suspense-stale-completed
• fix/ssr-text-separators
• fix/ssr-textarea-spread-value-3286
• fix/staged-reporter-deps
• fix/store-a28-backing
• fix/store-descriptor-trap
• fix/store-enumerator-presence-nodes-3664
• fix/store-overlay-rebuild-key-set-3689
• fix/store-platform-objects-raw
• fix/store-projection-types
• fix/store-setter-guard-root
• fix/store-then-probe-strict-read
• fix/store-unchanged-key-read-hold-3688
• fix/strict-read-hydration-lazy-3675
• fix/superseded-flight-wake
• fix/superseded-source-blocks-3462
• fix/symbol-observable-type
• fix/textarea-value-hydration-id-3691
• fix/tracked-style-class-objects
• fix/tsrx-parenthesized-key-spans
• fix/tsrx-semicolon-spans
• fix/tsrx-unicode-diagnostics
• fix/unstable-memo-symbol-keys
• fix/usage-of-deprecated-version-of-nodejs
• fix/usehead-stylesheet-hydration
• fix/web-late-defer-stream-warning
• fix/web-nested-package-json-exports-3627
• fix/zombie-flag-survives-recompute
• fix/zombie-flag-survives-recompute-3543
• fix/zombie-rerun-after-commit-3546
• flash-key-derivation
• flight-consumers-response-metadata
• for-index-union-types
• fragment-props-children
• gitpod-pnpm
• goldEli-fix-the-typo
• graph
• graph-property
• harden-server-fn-arg-decode
• hotfix-merge-props
• html-named-export
• ignore-internal-signals
• improve-Setter-type
• improve-errors-handling
• improve-setter-type
• improve_ts_config
• investigate/loading-reset-stale-3412
• investigate/optimistic-confirm-holds-signal-3706
• investigate/stream-hang-nested-loading-3478
• is-attribute-dynamic
• is-dev
• is-regression
• issues/1020
• jsdoc-context-ssr-guidance
• keyed-small-moves
• latest-held-till-flush
• lazy-forward-all-args
• lazy-use-devComponent
• lean-posture-followup
• main
• more-jsdoc
• names-and-ids
• next
• nksaraf-export-owner
• observable-nit
• observe-component-names
• observe-exclude-writes
• observe-origin
• observe-perf
• observe-shape-freeze
• observe-stores
• observe-tier
• ocavue/h-type
• on-cleanup-generic
• oracle/gated-away-posture
• oracle/posture-matrix
• oracle/store-postures
• otonashixav-feat-resource-type-improvements-alternative
• owner-props
• patch-1
• patch-10
• patch-2
• patch-3
• patch-6
• patch-8
• patch-9
• patch-hardening-r6
• perf-props
• perf-splitProps-flat
• perf/compiler-getter-keys
• perf/hydrate-claim-path
• perf/omit-hidden-chain
• perf/omit-nested-record
• perf/omit-view
• perf/owned-raw-stamp
• perf/packed-subscription-edges
• perf/settle-fast-path
• perf/shared-prop-handlers
• perf/shared-prop-traps
• perf/spread-direct-sources
• perf/spread-fewer-nodes
• perf/ssr-element-parity
• perf/ssr-element-path
• perf/ssr-props-constructors
• perf/ssr-scope-lazy-id
• perf/ssr-walker-entry
• perf/store-create-floor-diet
• perf/store-structural-shallow
• perf/store-write-floor
• perf/view-table-on-enumeration
• perf/with_createMemo_typings
• pnpm
• port/3732-derived-sync-landing
• port/3744-presence-folds
• port/3761-mainline-mounts
• prettier-code-format
• probe/codspeed-baseline
• probe/tier1-spike2
• probe/tier1-spike4
• probe/tier2-ambient-txn
• probe/tier2-config-brand
• probe/tier2-pend-container
• proposal/remove-store-readonly
• props-types
• proto/post-await-stale-read-warning
• prototype-fix
• prune
• records-channel
• redirect-href-logical-path
• reexport-all-signal-exports
• refactor-effect-types
• refactor-merge-props-type
• refactor-remove-stores-readonly
• refactor-split-props-type
• refactor-store-remove-readonly
• refactor-store-types
• refactor-store-types-2
• refactor-switch-downstream-and-upstream-terms
• refactor-types-clearer-store-error
• refactor-types-on
• refactor/owns-hold
• refactor/shared-read-predicates
• refs/heads/main
• refs/pull/1842/merge
• refs/pull/1847/merge
• refs/pull/1881/merge
• refs/pull/1885/merge
• refs/pull/1889/merge
• refs/pull/1896/merge
• refs/pull/1904/merge
• refs/pull/1920/merge
• refs/pull/1930/merge
• release/rc9-unblock-publish
• remove-cjs
• remove-instance-header
• remove-name-generation
• remove-patch-driver
• removeBrowserPackageJson
• render-record-scrub
• resource-error
• resource-resolving-args
• revert-stupidity
• revert/3615-hydrate-wait-for-records
• scratch/3562-bisect-c3
• server-boundary-records
• server-dev-build
• server-diagnostics-artifact
• server-diagnostics-c2
• server-error-hook
• server-frame-records
• server-function-invocation-metadata
• server-function-wrapped-exports
• server-functions-flash-cookie-hardening
• server-functions-runtime
• server-observe-c0
• server-observe-c1
• setter-fix-3
• setter-type-fix
• setter-type-fix-2
• sf-client-fetch
• sf-foreign-response
• sf-path-addressing
• show-double-evaluation
• signal-hash-untrack-json-stringify
• size-gate-minified-allowance
• size-gate-recorded-minified
• size/2883-phase-1
• size/2883-phase-2
• size/2883-phase-3
• size/audit
• size/audit-followup
• size/carve-step1
• size/compiled-caps-after-3807
• size/compiled-scenarios
• size/page-router-scenario
• size/rolldown-harness
• size/web-server-floor
• solid-ssr-windows-fix
• solid-usage-skills
• source-entry
• spec/frames-consistency-contract
• spike/a28-read-side
• split-props-omit-fix
• splitProps-defineProperty-default-configurable
• ssr-children-export
• ssr-component-names
• ssr-doc
• ssr-error-sanitize
• stage2-channel
• store-rewrite
• test-props
• test/backpressure-gate
• test/compiler-id-stability
• test/deflake-client-recovery-record
• test/deflake-hybrid-generator-hydration
• test/deflake-performance-tracks-thresholds
• test/deflake-server-boundary-records
• test/deflake-tacos-observe
• test/deterministic-held-ms
• test/direct-commit-readers-posture
• test/flaky-wall-clock-timers
• test/http-invariants
• test/hybrid-handoff-deterministic
• test/idiomatic-dynamic
• test/on-rearm-reveal-pins
• test/open-gaps
• test/oracle-stores
• test/pin-server-function-invariants
• test/server-function-coverage
• test/visibility-oracle
• test/zombie-create-path-and-chain-invariant
• throw-error-ssr-browser
• tier1-memory-guard
• tiny-use-context-optimization
• tracks-nearest-component-labels
• ts-5.7
• tsrx-frontend
• tsrx/explicit-accessor-bindings-3474
• tweaks
• type-improvements
• type-selector
• types-exports
• types/update-jsdoc-comments
• typescript-improvements
• typing/classlist
• unified-for-accept
• unified-for-engine
• untrack-fast-track
• update-contributing
• update-dom-expressions
• update-dom-expressions-to-0.40.3
• update-typescript
• update/script
• updated-readme-video
• use-transition-doc-comment
• warn-unhandled-errors
• web-storage-node-resolution
• why-did-this-run
• wip/frames-pass-integration
• wip/frames-pass-integration-2

Build # 37447904115

Build Type

Pull #3827

github

Committed by web-flow

Commit Message

Merge af5536374 into b987c41f4

Pull Request Pull Request #3827: fix(web/frames): classify an adopted occurrence only after every delivered record has drained (C18)

Coverage Stats

654 of 930 branches covered (70.32%)

Branch coverage included in aggregate %.

963 of 1196 relevant lines covered (80.52%)

28.27 hits per line