skodaconnect / myskoda

90%

main: 87%

LAST BUILD ON BRANCH v0.17.1a1

branch: v0.17.1a1

CHANGE BRANCH

x

Reset

• v0.17.1a1
• 468-selective-updates
• 468-too-many-requests
• Prior99-patch-1
• add-MARKETING_CONSENT_SAD_THIRDPARTY
• add-RESET_SPIN-state
• add-capa-dmg-mgmt
• add-capability-deactivated
• add-charging-error-state
• add-cng-engineType
• add-contributing
• add-dataclass-vehicle-offline
• add-departure-feature
• add-docstrings
• add-driving-score
• add-e-priv-capability
• add-evbooking
• add-expiry-to-mqtt-wait
• add-fixtures
• add-gas-to-tripstatistics
• add-hatchback
• add-info-timestamp
• add-new-marketing-userid
• add-online-update-capability
• add-phone-commschannel
• add-superb-iv-2025-fixture
• add-timestamps-to-models
• add-unknown-enginetype
• add-user-timestamp
• add-vehicle-disabled
• add-ventilation
• add_all-opened_state
• air-conditioning-timers
• anonymize-departure-vin
• api-endpoints-sort
• app-8.1.0-replies
• auxiliary-heating-timers
• bump-mqtt-libs
• capability-loyalty-program
• charging-profiles
• charging_history
• cleanup-poetry-leftover
• cleanup-ssl_context
• coverage
• coveralls-1
• debounce
• delay-refresh-after-op
• dependabot/pip/aiohttp-3.11.10
• dependabot/pip/aiohttp-3.11.11
• dependabot/pip/aiohttp-3.11.12
• dependabot/pip/aiohttp-3.11.13
• dependabot/pip/aiohttp-3.11.14
• dependabot/pip/aiohttp-3.11.2
• dependabot/pip/aiohttp-3.11.7
• dependabot/pip/aiohttp-3.11.9
• dependabot/pip/aioresponses-0.7.7
• dependabot/pip/aioresponses-0.7.8
• dependabot/pip/asyncclick-8.1.8
• dependabot/pip/jinja2-3.1.5
• dependabot/pip/jinja2-3.1.6
• dependabot/pip/mashumaro-3.14
• dependabot/pip/mashumaro-3.15
• dependabot/pip/mkdocs-literate-nav-0.6.2
• dependabot/pip/mkdocstrings-0.27.0
• dependabot/pip/mkdocstrings-0.28.0
• dependabot/pip/mkdocstrings-0.28.1
• dependabot/pip/mkdocstrings-0.28.2
• dependabot/pip/mkdocstrings-0.28.3
• dependabot/pip/mkdocstrings-0.29.0
• dependabot/pip/pygments-2.19.0
• dependabot/pip/pygments-2.19.1
• dependabot/pip/pyjwt-2.10.0
• dependabot/pip/pyjwt-2.10.1
• dependabot/pip/pyright-1.1.386
• dependabot/pip/pyright-1.1.387
• dependabot/pip/pyright-1.1.388
• dependabot/pip/pyright-1.1.389
• dependabot/pip/pyright-1.1.390
• dependabot/pip/pyright-1.1.391
• dependabot/pip/pyright-1.1.392.post0
• dependabot/pip/pyright-1.1.393
• dependabot/pip/pyright-1.1.394
• dependabot/pip/pyright-1.1.396
• dependabot/pip/pyright-1.1.397
• dependabot/pip/pytest-8.3.4
• dependabot/pip/pytest-8.3.5
• dependabot/pip/pytest-cov-6.0.0
• dependabot/pip/ruff-0.11.0
• dependabot/pip/ruff-0.11.2
• dependabot/pip/ruff-0.7.0
• dependabot/pip/ruff-0.7.1
• dependabot/pip/ruff-0.7.2
• dependabot/pip/ruff-0.7.3
• dependabot/pip/ruff-0.7.4
• dependabot/pip/ruff-0.8.0
• dependabot/pip/ruff-0.8.1
• dependabot/pip/ruff-0.8.2
• dependabot/pip/ruff-0.8.3
• dependabot/pip/ruff-0.8.4
• dependabot/pip/ruff-0.8.6
• dependabot/pip/ruff-0.9.1
• dependabot/pip/ruff-0.9.10
• dependabot/pip/ruff-0.9.2
• dependabot/pip/ruff-0.9.3
• dependabot/pip/ruff-0.9.4
• dependabot/pip/ruff-0.9.5
• dependabot/pip/ruff-0.9.6
• dependabot/pip/ruff-0.9.7
• dependabot/pip/ruff-0.9.9
• dependabot/pip/setuptools-75.5.0
• dependabot/pip/setuptools-75.6.0
• dependabot/pip/setuptools-75.7.0
• dependabot/pip/setuptools-75.8.0
• dependabot/pip/setuptools-76.0.0
• dependabot/pip/setuptools-77.0.3
• deserialize_time_to_finish
• disable_mqtt
• doc-api-replies
• docs-endpoint-update
• elroq
• enyaq-fixtures
• event-model-overhaul
• expand-vehicle-connection-status
• fix-PROTOCOL_TLS
• fix-broken-test
• fix-callbacks-typing
• fix-chargemode-other
• fix-charging-profile-model
• fix-charging-stopped-event-2
• fix-ci-just
• fix-colors
• fix-departure-timers
• fix-firstname
• fix-lib-version
• fix-mqtt
• fix-mqtt-connection-refused
• fix-optional-address
• fix-optional-update_date
• fix-vehicle-update
• fix1
• fix_info
• fixture-chodorenko
• fixture-enyaq-2025-5AZJK2-85
• fixture-fix
• fixture-maint
• fixture-octavia-cng
• fixture-octavia-lng-fuel
• fixture_octavia
• fixtures-add-connection-status
• fixtures-test
• full-refresh-on-access-event
• get-partial-vehicle
• ignore-error-from-get-vehicle
• ignore-for-tests
• ignore-timestamps-from-fixture
• improve-mqtt
• introduce-brands
• kodiaq_iv_fixture
• limit-mqtt-backoff
• linter-fixes
• log-unknown-usercapabilities
• login-accept-refreshroken
• main
• maintenance-customer-service
• maintenance-report-endpoint
• make-all-ac-sensors-optional
• marketing-consent
• missing-errortype
• mqtt-charging-error
• mqtt-event-handling
• mqtt/vehicle-connection-offline
• myskoda-v8.1-api
• myskoda-v8.2.0-api
• myskoda-v8.4.0-api
• new-capa-unavailability_statuses
• new-capabilities
• new_fixture
• nickname-optional
• optional-city
• optional-confirmationdate
• optional-max_charge_current_ac
• optional-next_charging_time
• ordered-vehicle
• parking-position
• parkingposition-v3
• pass-ssl_context
• patch-1
• patch-3
• pr_419
• readiness-polling
• refactor-parse-topic
• refresh-charging-on-event
• refresh_token
• release-0.7.2
• remove-async-with
• remove-just
• rename-fixtures
• renovate/termcolor-3.x
• replace-amqtt
• revert-302-fix-departure-timers
• sad-marketing-capability
• set-auto-unlock-plug
• set-default-for-chargingstate
• set-minimum-charge-limit
• test_gen
• test_gen_prod
• test_mqtt
• tests
• update-api-endpoints
• update-fixture-enyaq
• update-releasenote-drafter
• update_vehicle_connection_status
• use-maintenance-report-update
• uv
• v0.10.0
• v0.11.0
• v0.12.0
• v0.12.1
• v0.12.2
• v0.13.0
• v0.13.1
• v0.13.2
• v0.13.2-pre0
• v0.13.3
• v0.13.4
• v0.14.0
• v0.14.1
• v0.14.2
• v0.14.3
• v0.14.4
• v0.15.0
• v0.15.1
• v0.15.2
• v0.15.3
• v0.15.4
• v0.16.0
• v0.16.1
• v0.16.2
• v0.17.0
• v0.17.0+eventdata
• v0.17.0-eventdata
• v0.17.1
• v0.17.2
• v0.18.0
• v0.18.0b1
• v0.18.1
• v0.18.2
• v0.19.0
• v0.20.0
• v0.20.1
• v0.21.0
• v0.21.0-beta1
• v0.21.1
• v0.21.2
• v0.21b1
• v0.22.0
• v0.22.1
• v0.22.2dev0
• v0.23.0
• v0.7.0
• v0.7.1
• v0.7.2
• v0.7.3
• v0.8.0
• v0.8.1
• v0.8.2
• v0.8.3
• v0.8.4
• v0.8.5
• v0.8.6
• v0.8.7
• v0.8.8
• v0.8.9
• v0.9.0
• v0.9.1
• v1.0.0
• v1.0.1
• v1.1.0
• v1.2.0
• v1.2.1
• v1.2.2
• v1.2.3
• v2.0.0
• v2.0.1
• v2.1.0
• v2.2.0
• v2.2.1
• v2.2.2
• v2.2.3
• v2.3.0
• v2.3.1
• v2.3.2
• v2.3.3
• v2.3.4
• v2.4.0
• v2.4.1
• v2.4.2
• vehicle-connection-status
• vehicle-health-wakeup
• ventilation
• windows-compatibility
• yaml_json

Build # 12670934579

Build Type

push

github

Committed by web-flow

Commit Message

Refactor service event to distinguish event with data or without (#308)

Only charging events have data and some of them have the data optionally.
It could make sense to get only two types of events: with data or without.
Currenly only charging events will have these types, all other service
events will be of ServiceEvent base type.

This solution has pros and cons:
- this is simpler and shorter
- only two event types to distinguish and process
But:
- this solution is not future proof: if any of the event start to get
other data, it would be required to introduce new types anyway which
will make mqtt._parse_topic function to look even more ugly and
complicated than now.

NOTE!!! This change is not compatible with current one that is used in
HA addon. Adaptation is required.

Co-authored-by: WebSpider <WebSpider@users.noreply.github.com>

Run Details

1936 of 2140 relevant lines covered (90.47%)

0.9 hits per line