sirosen / SALVE

100%

stable: 100%

LAST BUILD ON BRANCH wip/bugfix/logging-python-vers

branch: wip/bugfix/logging-python-vers

CHANGE BRANCH

x

Reset

• wip/bugfix/logging-python-vers
• 2.2.0
• 2.3.0
• 2.3.1
• 2.4.1
• bugfix/logging-python-vers
• bugfix/logging/cli-vs-configfile
• dev
• documentation/readme-2.2.0
• feature/abstract-filesys
• refactor/codeclimate
• refactor/flake8
• stable
• testing/travis-nosudo
• wip/bugfix/setuptools-fixes
• wip/documentation/cleanup-metadata
• wip/documentation/cli-help-2.3.0
• wip/documentation/readme-fixup
• wip/documentation/readme-rst
• wip/feature/abstract-filesys
• wip/feature/block-primary-attr
• wip/feature/improved-relative-paths
• wip/feature/mock-fs-verify
• wip/feature/pip-package
• wip/feature/py2-6-compat
• wip/feature/py35
• wip/feature/pypy
• wip/feature/verify-pre-deploy
• wip/refactor/2-3-0-cleanup
• wip/refactor/action-prettynames
• wip/refactor/clean-initfiles
• wip/refactor/codeclimate
• wip/refactor/general-cleanup
• wip/refactor/global-state
• wip/refactor/remove-base-modules

Build # 190

Build Type

push

travis-ci

Committed by sirosen

Commit Message

Special casing for Python 2.6 logging

The Python2.6 StreamHandler initializer has a different signature from the one
used in Python2.7 and Python3.x
Namely, rather than using a keyword arg, it uses an optional positional
argument for the Stream, and it defaults when the argument is omitted, not when
it is `None`. Although I'm unsure of the behavior of the logger on 2.6 when the
argument is supplied as None, I'd expect it to break. Per the documentation,
this is the only correct/safe way to set the stream for Python 2.6

In Python 2.6, the NullHandler was not part of the standard logging library. As
a result, we must wrap references to the NullHandler in salve.log.handler and
explicitly define a NullHandler when we get an AttributeError doing so (which
indicates that the logging module doesn't have an attribute named
'NullHanlder').

Fixes a typo of "'DEBUG'" instead of "logging.DEBUG"

Run Details

9 of 9 new or added lines in 3 files covered. (100.0%)

1386 of 1386 relevant lines covered (100.0%)

6.99 hits per line