silvermine / toolbox

99%

master: 99%

LAST BUILD ON BRANCH has-defined-object

branch: has-defined-object

CHANGE BRANCH

x

Reset

• has-defined-object
• MatheusBaldi/update-eslint-config-file
• add-optional
• add-promise-delay
• add-props-with-type
• add-require-for-fields
• build-on-win
• changelog-v0.3.0
• changelog-v0.4.0
• changelog-v0.5.0
• changelog-v0.5.1
• changelog-v0.6.0
• coveralls-parallel
• crweber/improve-is-empty
• esmith/add-enum-value-typeguard
• esmith/add-pick
• fix-props-with-type-undefined
• group-by
• has-defined-union
• is-empty-arr-obj
• jbrupbacher/upgrade-typescript
• jrthomer/chunk
• jrthomer/flatten
• jrthomer/has-property
• jrthomer/pluck
• jrthomer/shuffle
• jrthomer/typo
• json-key-sorter
• lwilkerson/node-24
• map-of-types
• master
• node-20
• onebytegone/npm-standards
• onebytegone/pick
• refs/tags/v0.3.0
• renovate/actions-checkout-5.x
• renovate/actions-checkout-6.x
• renovate/actions-setup-node-6.x
• renovate/chai-4.x
• renovate/chai-5.x
• renovate/check-node-version-4.x
• renovate/configure
• renovate/coveralls-3.x
• renovate/coverallsapp-github-action-2.x
• renovate/eslint-monorepo
• renovate/grunt-1.x
• renovate/grunt-cli-1.x
• renovate/grunt-concurrent-3.x
• renovate/grunt-contrib-clean-2.x
• renovate/lock-file-maintenance
• renovate/mocha-10.x
• renovate/mocha-5.x
• renovate/node-12.x
• renovate/npm-grunt-vulnerability
• renovate/nyc-13.x
• renovate/nyc-17.x
• renovate/silvermine-chai-strictly-equal-1.x
• renovate/silvermine-eslint-config-digest
• renovate/silvermine-typescript-config-digest
• renovate/sinon-17.x
• renovate/sinon-18.x
• renovate/sinon-19.x
• renovate/sinon-5.x
• renovate/source-map-support-0.x
• renovate/ts-node-10.x
• renovate/tslib-2.x
• renovate/typescript-3.x
• renovatebot
• strict-union
• test
• test-typo
• tslib-upgrade
• v0.1.0
• v0.2.0
• v0.4.0
• v0.5.0
• v0.5.1
• v0.6.0
• v0.7.0

Build # 19141658822

Build Type

Pull #120

github

Committed by onebytegone

Commit Message

fix: ensure hasDefined is called on an object

Prior to this change, the following snippet would not throw a type error but would throw a
runtime error:

```ts
type TestObj = { firstName: string } | undefined;

const obj: TestObj = undefined;

hasDefined(obj, 'firstName');
```

Now that snippet will have the type error of: "Argument of type 'undefined' is not
assignable to parameter of type 'object'.ts(2345)"

Pull Request Pull Request #120: fix: ensure hasDefined is called on an object

Run Details

85 of 87 branches covered (97.7%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

256 of 258 relevant lines covered (99.22%)

76.02 hits per line