shogo82148 / mysql

82%

LAST BUILD ON BRANCH master

branch: master

CHANGE BRANCH

x

Reset

• master
• add-go-builg-lines
• add-go1.16-to-build-matrix
• connector-interface-support
• context-support
• context-support2
• dependabot/go_modules/filippo.io/edwards25519-1.1.1
• deprecate-mysql-null-time
• drop-go1.7
• drop-support-of-go1.12
• drop-support-of-go1.18
• drop-support-of-go1.19
• fix-626
• fix-compile-error-on-plan9
• fix-issue-1567
• fix-raw-bytes-corruption-issue
• fix-test-of-charset
• fix1567-18
• go1.15-is-released
• go1.17-is-released
• implement-register-dial-context
• improve-github-actions
• introduce-github-actions
• introduce-reader-and-write-groutine
• introduce-reader-and-write-groutine-2
• introduce-reader-and-write-groutine-3
• make-default-logger-goroutine-safe
• make-nulltime-type-alias
• no-copy-should-implement-locker
• parallelize-test
• prepare-for-v1.8.1
• release-v1.6.0
• scan-type-return-sql-null-time
• session-resetter-support
• shogo82148-patch-1
• stop-repeated-queries
• stop-rounding-time
• support-read-only-transaction
• support-read-only-transaction2
• support-read-only-transaction3
• tmp
• update-changelog-for-v1.8.1
• wip-context-support

Build # 8403035702

Build Type

push

github

Committed by web-flow

Commit Message

Fix issue 1567 (#1570)

### Description

closes https://github.com/go-sql-driver/mysql/issues/1567

When TLS is enabled, `mc.netConn` is rewritten after the TLS handshak as
detailed here:


https://github.com/go-sql-driver/mysql/blob/d86c4527b/packets.go#L355

Therefore, `mc.netConn` should not be accessed within the watcher
goroutine.
Instead, `mc.rawConn` should be initialized prior to invoking
`mc.startWatcher`, and `mc.rawConn` should be used in lieu of
`mc.netConn`.

### Checklist
- [x] Code compiles correctly
- [x] Created tests which fail without the change (if possible)
- [x] All tests passing
- [x] Extended the README / documentation, if necessary
- [x] Added myself / the copyright holder to the AUTHORS file


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
	- Improved variable naming for better code readability and maintenance.
	- Enhanced network connection handling logic.
- **New Features**
	- Updated TCP connection handling to better support TCP Keepalives.
- **Tests**
- Added a new test to address and verify the fix for a specific issue
related to TLS, connection pooling, and round trip time estimation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Run Details

4 of 4 new or added lines in 2 files covered. (100.0%)

3122 of 3786 relevant lines covered (82.46%)

1130723.18 hits per line