shinghim / rust-bitcoin

83%

master: 84%

LAST BUILD ON BRANCH fee-ceil

branch: fee-ceil

CHANGE BRANCH

x

Reset

Sync Branches

• fee-ceil
• 2869-displaying-hex
• 2952-remove-fmt-value-in
• 2954-amount-doc
• 2998-version-enum
• 3039-to
• 3160-remove-from
• 3160-remove-from-into
• 3186-remove-tests
• 3348-to-hex-bug
• 3366-refine-arbitrary
• 3615-block-methods
• 3652-from-next-work
• 3654-nodeinfo-ord
• 3705-arbitrary
• 3779-remove-panic
• 3843-remove-infallible
• 4031-assign-ops
• 4156-mutants
• 4172-mul-div-assign
• 4206-const
• 4345-as-inner
• 4362-from-hex
• 4476-map
• 4685-arbitrary
• api-script-bug
• arbitrary-tx
• bitcoin-arbitrary
• bitcoin-fuzz
• block-arbitrary
• cleanup
• derive-arbitrary
• fix-unused
• from-second-ceil
• fuzz-targets
• ggrep
• height
• inventory-encode
• key-arbitrary
• kill-mutants
• master
• move-arbitrary
• mutant
• mutants
• p2p-fuzz
• primitive-arbitrary
• primitives-arbitrary
• relative-timelock-tests
• remove-tests-mod
• rename-key-data
• sequence_test
• signature-arbitrary
• siphash
• staging
• typo
• units-fuzz
• units-mutants
• unused-variable
• update-arbitrary
• update-key-doc
• use-arbitrary
• version-enum
• version-tests
• witness-program-test

Build # 16911896879

Build Type

push

github

Committed by shinghim

Commit Message

Fix overflow during *_ceil FeeRate conversions

This fixes an overflow bug which occured when these ceil functions were
called on `FeeRate::MAX`, which is u64::MAX under the hood. This
resulted in the function panicking due to an overflow since part of the
ceil operation involves adding to the FeeRate before dividing by the
appropriate unit. By calling `saturating_add` instead of using `+`, this
prevents the function from panicking while preserving the expected
behavior when converting `FeeRate`s that would have previously
overflowed

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

21551 of 25843 relevant lines covered (83.39%)

15106.48 hits per line