shakacode / react_on_rails

87%

master: 0%

LAST BUILD ON BRANCH fix-gem-dependencies

branch: fix-gem-dependencies

CHANGE BRANCH

x

Reset

• fix-gem-dependencies
• 2.0.0-rc.1
• 2.0.0-rc.3
• 2.0.0-rc.4
• 2.0.2
• 2.1.0
• 2.1.1
• 2.3.0
• 3.0.0-beta.1
• 3.0.0-rc.1
• 3.0.0-rc.2
• 3.0.1
• 3.0.2
• 3.0.3
• 3.0.4
• 3.0.5
• 3.0.6
• 4.0.0
• 4.0.0-beta.2
• 4.0.0-beta.3
• 4.0.1
• 4.0.2
• 5.1.0
• 5.2.0
• 6-1-release-notes
• 6.0.0
• 6.0.0-beta.4
• 6.0.0-beta.5
• 6.0.0-rc.1
• 6.0.0-rc.5
• 6.0.0-rc.6
• 6.0.1
• 6.0.3
• 6.0.4
• 6.0.5
• 6.1.0
• 6.1.1
• 6.1.1-rc.1
• 6.1.2
• 6.10.0
• 6.10.1
• 6.2.0
• 6.2.1
• 6.2.1-rc.1
• 6.2.1-rc.2
• 6.2.1-rc.3
• 6.3.2
• 6.3.3
• 6.3.4
• 6.3.5
• 6.4.0
• 6.4.1
• 6.4.2
• 6.5.0
• 6.5.0-beta.1
• 6.5.1
• 6.6.0
• 6.7.1
• 6.7.2
• 6.8.0
• 6.8.1
• 6.8.2
• 6.9.0
• 6.9.1
• 6.9.2
• 6.9.3
• 7.0.0
• 7.0.1
• 7.0.3
• 7.0.4
• 7.1.0-beta.3
• 8.0.0
• 8.0.0-beta.1
• 8.0.0-beta.2
• 8.0.0-beta.3
• 8.0.0-updates
• 8.0.1
• Add-CHANGELOG
• DimaZab-return-react-element
• SqueezedLight-master
• TangRufus-add-skip-display-none
• add-babel-runtime-to-root-package-json
• add-development-server-message
• add-generators
• add-image-handling-example
• add-location-to-redux-store-generator
• add-projects-pivotal-tracker
• add-projects-using
• add-puma
• add-rails-helper-to-generator
• add-react-rails-note-to-readme
• add-unicorn
• alex/react-router
• alleycat-at-git-alexey/replace_symlinks_copy
• andy/169-fix-generator-jquery-config
• andy/add-help-option-for-generator
• application-js-fix
• better-errors
• bootstrap-as-an-option
• bug-fix-on-props-serialization-for-string-in-development
• change-linters-default
• change-therubyracer-to-mini_racer
• coveralls-merge
• default-rake-task-lints
• doc-updates
• docker_ci-coveralls-reporting
• docs
• docs-overhaul
• dont-call-to-json-on-props-converted-to-string-already
• ensure-assets-compiled
• examples-folder
• feature/add-node-option-to-generator
• feature/change-foreman-port-to-3000
• feature/generator-rewrite
• feature/merge-server-client-webpack
• feature/option-removal
• feature/remove-node-from-generator
• final-doc-updates
• fix-broken-gitbook-links
• fix-ci
• fix-ci-no-turbolinks
• fix-controller-redux-store-api
• fix-coverage
• fix-coverage-of-generated-apps
• fix-doc-on-shared-store
• fix-gemfile
• fix-invalid-deprecation-message
• fix-lint-issue
• fix-linting-issues
• fix-missing-new-line
• fix-performance-regression-parsing-string-props
• fix-rake-task-names
• fix-rendering-for-no-turbolinks
• fix-requires
• fix-sanitization-server-console-messages
• fix-sanitization-server-console-messages-2
• fix-test-failure
• fix-turbolinks-issue
• fix-typo-contributing-doc
• gem-issues
• hello-world-redux
• improve-linter-generators
• improve-package-json-template
• improve-release-script
• initialize-redux-store-view-helper
• jmeek/fix-hmr
• json-encoding
• justin/improve-ensure-assets-compiled
• justin800/allow-router-result-to-return-html-string
• justin808-6-8-release
• justin808-6.4-changes-to-docs
• justin808-6.4-changes-to-docs-1
• justin808-angular-plus-react
• justin808-change-logger-error-incorrect-npm-rubygems-combo
• justin808-ci-failures
• justin808-doc-fixes
• justin808-doc-updates
• justin808-gitbook
• justin808-inaccurate-build-test-message
• justin808-patch-1
• justin808-patch-2
• justin808-readme-updates
• justin808-remove-npm-link-spec-dummy
• justin808-skip-docker
• justin808-turbo-details
• justin808-tutorial-updates
• justin808-tweak-missing-store-message
• justin808-update-dependencies
• justin808-update-for-webpack-v2
• justin808-webpack-docs
• justin808-yarn-updates
• justin808/webpacker_integration
• log-detailed-message-to-console-if-server-js-file-missing
• mapreal19-fix-generated-linters-task
• mapreal19-patch-1
• mario/extract-react-component-options
• master
• more-ci-fixes
• more-turbolinks-items
• move-contributing-to-top-level
• new-api-shared-redux-stores
• npm-react-on-rails-js
• optimize-ensure-assets-compiled
• rails-4.2.5
• recognize-application-scss
• refactor-logger-middleware-generation
• remove-dummy-app-bundles-from-sc
• remove-extra-values-webpacker-config
• remove-global-variable-for-props
• remove-templates-client-folder
• remove-unnecessary-param-basic-install
• return-react-element
• rob/fix-symlink-regression
• rob/improve-ensure-assets-compiled
• rob/update-docs
• robwise-patch-1
• rstudner-patch-1
• ryanaip-data-tags
• sergey/fix-nil-json
• sergey/fix-nil-values-in-pretty-json
• server-bundle-caching
• small-error-formatting-fix
• small-package-change
• temp-fix-serialization-development
• the-react-on-rails-doctrine
• tweaks-for-i18n
• tweaks-for-webpacker-1.1
• udpate-readme
• update-chrome-version-ci
• update-dependencies
• update-dependencies-tests-react013
• update-gems
• update-linters
• update-nokogiri
• update-readme
• update-readme-changelog
• update-to-webpack-v2
• update-webpacker-lite-2.0.3
• update-yarn-lock
• use-named-parameters-for-options
• v1.0.0
• v1.0.0.pre
• v1.0.1
• v1.0.2
• v1.0.3
• v1.1.0
• v1.1.1
• v1.2.0
• v1.2.0.rc1
• v1.2.1
• v1.2.2
• v2.0.0.beta.4
• v2.0.0.rc.1
• v2.0.0.rc.3
• v2.0.0.rc.4
• v2.0.1
• v2.0.2
• v2.1.0

Build # 584

Build Type

push

travis-ci

Committed by robwise

Commit Message

Generator adds therubyracer to the Gemfile

Previously we required users to manually add therubyracer to their
Gemfile. There was really no reason for this since we can just have
the generator do it for them. We have chosen not to make therubyracer
a gem dependency in the gemspec because it is MRI-specific and
therefore will not work with JRuby.

This commit also removes removes a base_generator test asserting
that the coffee-rails gem was being removed from the Gemfile
by the generator. This was not desired behavior and was not
actually happening, but due to a mistake in how the
generator_spec_helper was written, was passing anyway.

Also adds a note about therubyracer to the README

Run Details

329 of 377 relevant lines covered (87.27%)

18.91 hits per line