seapagan / confoog

100%

master: 100%

LAST BUILD ON BRANCH refactor-and-tidy

branch: refactor-and-tidy

CHANGE BRANCH

x

Reset

• refactor-and-tidy
• add_pullreview
• autoload
• autosave
• document
• fix-reek-under-1.9.3
• load_save
• master
• refactor-status-rebase
• remove_accessors
• rubocop_cleanup
• thinking
• v0.1.1
• v0.1.2
• v0.1.4
• v0.2.0
• v0.2.1
• v0.3.0
• v0.4.0
• v0.4.1
• v0.4.2
• v0.4.3
• v0.4.5
• v0.4.6

Build # 66

Build Type

push

travis-ci

Committed by seapagan

Commit Message

General refactoring and removal of a few 'code smells'

Notably :
 * Refactor Status.set & Settings.save_to_yaml
 * Refactor - remove the :location and :filename accessors
   - These are not really needed and were adding extra code to
     prevent them being changed. Cuts down on total @vars too.
 * Move error_string out to a method, cuts down on repetition.

 * Tests - remove a global variable used to squelch console output
   Changed to an instance variable instead. Cleans up a code smell.
 * README - Add another TODO
 * Standardize Rakefile line spacing
 * Refactor Settings#set to use var instead of multiple method calls.

All RSpec tests, Rubocop and Inch are at 100%, also drops 'reek' report
down to 2 smells from 8.

Run Details

24 of 24 new or added lines in 4 files covered. (100.0%)

269 of 269 relevant lines covered (100.0%)

10.47 hits per line