sds / scss-lint

96%

master: 96%

LAST BUILD ON BRANCH trailing-semicolon-important

branch: trailing-semicolon-important

CHANGE BRANCH

x

Reset

• trailing-semicolon-important
• PrivateNamingConvention
• bang-format
• linter-gem-spec
• master
• private-naming-convention-bugs
• private-naming-edge-cases
• pseudoselector
• relax-rake-dependency-version
• single-line-per-property-nesting
• tap-report-path-fix
• tap-reporter
• tap-reporter-format
• universal-newline
• v0.40.0
• v0.40.1
• v0.41.0
• v0.42.0
• v0.42.1
• v0.42.2
• v0.43.0
• v0.43.1
• v0.43.2
• v0.44.0
• v0.45.0
• v0.46.0
• v0.47.0
• v0.47.1
• v0.48.0
• v0.49.0
• v0.50.0
• v0.50.1
• v0.50.2
• v0.50.3
• v0.51.0
• v0.52.0
• v0.53.0
• v0.54.0
• v0.55.0
• v0.56.0
• v0.57.0
• v0.57.1
• v0.58.0
• v0.59.0

Build # 978

Build Type

push

travis-ci

Committed by lencioni

Commit Message

Fix TrailingSemicolon for variables with !default and !global

The TrailingSemicolon rule was not checking guarded or global variable
declarations properly. I determined that this is because we are using
`node.expr` for the source range, which in cases like:

  $foo: bar !default;

gives us a range that looks like:

  bar

which causes the linter to fail. Instead, if we just use the `node`
source range instead, we will get

  foo: bar !default;

so our checks work as expected. I considered always using `node` source
range, but I figured that if it is working for other cases that it would
be better to leave it as is.

Addresses #602

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

2462 of 2560 relevant lines covered (96.17%)

955.67 hits per line