scottclowe / fissa

81%

master: 78%

LAST BUILD ON BRANCH rf_import-read-roi

branch: rf_import-read-roi

CHANGE BRANCH

x

Reset

• rf_import-read-roi
• 0.0
• 0.1.2
• 0.1.x
• Suite2Pexample
• Suite2Pexample3
• add-stickler-config
• appveyor_read-roi
• binder
• bug_allow-sequences
• bug_deltaf-matlab-save
• bug_fixed-seed-on-reroll
• bug_isinstance-str
• bug_ncore
• bug_needlessly-redo-prep
• bug_numpy-load-pickle
• bug_pool-context
• bug_py3-rois
• bug_roi-offscreen
• bug_roi-offscreen_0.7
• bug_roitools-initial-diagonal
• bug_setup-meta
• bug_wipe-dowstream-outputs
• ci_allow-suite2p-failure
• ci_appveyor
• ci_appveyor-conda
• ci_appveyor2
• ci_codecov-bash
• ci_docs
• ci_gha
• ci_gha-conda
• ci_improvements
• ci_jupyter-env-command
• ci_make-docs
• ci_nbsmoke
• ci_no-skip-appveyor
• ci_osx-needed-except-pr
• ci_pip-without-conda
• ci_push-coverage
• ci_py27
• ci_py38
• ci_reduce-jobs
• ci_reduce-osx-jobs
• ci_release-extra
• ci_rename_oldest_deps
• ci_test-more-things
• ci_travis
• ci_travis-fast-finish
• ci_travis-osx-3
• ci_travis-osx-4
• ci_travis-osx-rel
• ci_trim
• dev_gitfiles
• dev_precommit
• doc+tst_binder-env
• doc_add-badges
• doc_add-changelog
• doc_add-download-counter
• doc_amend-folder-listing
• doc_binder
• doc_binder-old
• doc_binder-test
• doc_change-pypi-badge
• doc_changelog-0.7.1
• doc_changelog-0.7.2
• doc_changelog-commit-link-text
• doc_changelog-reformat
• doc_ci-badge
• doc_contrib-tags
• doc_docfix
• doc_docstring-tidy
• doc_doi_lower_case
• doc_example-scripts
• doc_fix-docstrings
• doc_fix-steps
• doc_howtorelease-updates
• doc_install-verification-with-ver-num
• doc_link-to-citing
• doc_nbviewer
• doc_release-dist-needs-universal
• doc_tidyup
• enh2_python3-compliance
• enh_functional
• enh_matlab-save-path
• enh_no-cache-option
• jnb_grammar
• maint_allow-sequences
• maint_cannonise-version
• maint_deltaf-smalldata
• maint_doc_conf
• maint_init-meta-import
• maint_ncore1
• maint_ospathjoin
• maint_remove-neuropil-lowPassFilter
• maint_scipy-imsave-dep
• maint_setup-improvements
• maint_setup-with-docs
• maint_setuppy-splitlines
• maint_tidy-up-things
• master
• mnt_ellipse-roi-type
• mnt_mixed-list-ndarray
• rel_0.6.5
• rel_0.7.1
• rel_0.7.2
• rel_gpl-v3-license
• rel_manifest
• rel_min-deps
• rel_min-deps-ipython
• rel_min-deps2
• rel_min-deps3
• rel_py3.9
• rel_python-requires
• rel_require-past
• rf_remove-neuropil-lowPassFilter
• rf_tidy-up
• sphinx-setup
• swkeemink/Suite2Pexample
• tst+bug_flexible-separate-tests
• tst_add-tests
• tst_readimagejrois
• tst_rois2masks-unsupported
• tst_test-core
• tst_test-core2
• tst_test-roitools
• tst_tidy-up
• tst_use-subtest
• v0.0.x
• v0.1.x

Build # 354

Build Type

push

travis-ci

Committed by scottclowe

Commit Message

BUG+RF: Int OverFlow on Windows resolved on Py3, utilising read_roi

Resolves the issue/error:
```
  File "C:\projects\fissa\fissa\readimagejrois.py", line 129, in _getfloat
    v = np.int32(_get32())
OverflowError: Python int too large to convert to C long
```
which was seen when trying to run the code on Windows with
AppVeyor, on a freshly compiled from source copy of FISSA instead
of using the pre-compiled version on conda-forge.

This is fixed by using the imagej roi reader from the package
read_roi. However, their implementation only works for Python 3
and not on Python 2.7. Therefore, we use theirs on Python 3 and
our old method on Python 2.7.

Run Details

208 of 279 branches covered (74.55%)

Branch coverage included in aggregate %.

618 of 738 relevant lines covered (83.74%)

5.66 hits per line