sclgo / impala-go

64%

master: 83%

LAST BUILD ON BRANCH fix/tls

branch: fix/tls

CHANGE BRANCH

x

Reset

• fix/tls
• bug/badconn
• chore/125
• chore/deps
• chore/golangci
• chore/makefile
• chore/modernize
• chore/syncthrift
• chore/thrift021
• cleanup/remove_compose_dep
• docs/1.2
• docs/design
• docs/examples_e2e
• examples/compose_e2e
• examples/compose_gis
• examples/compose_s3
• feat/12
• feat/3
• feat/34
• feat/51
• feat/builtincerts
• feat/fixedtimeout
• feat/getschemas
• feat/userpasserror
• fix/36
• fix/float64
• fix/handle_hms_errors
• fix/tidy
• master
• prep101
• tests/11
• tests/cli_usql
• tests/codeql
• tests/coverage
• tests/coverage_notgenerated
• tests/coverpkg
• tests/driver_errors
• tests/gorelease
• tests/gorich
• tests/inttest_coverage
• tests/leakdeps
• tests/mark_generated
• tests/matrix_build_go
• tests/opt124
• tests/q
• tests/statment_cover
• tests/vuln

Build # 12853755844

Build Type

Pull #37

github

Committed by murfffi

Commit Message

fix: root CA support regression

The switch from the deprecated NewTBinaryProtocol to the recommended replacement
NewTBinaryProtocolConf had an unintended side-effect - TLS configuration was
propagated from the protocol to the transport, erasing the previously configured RootCAPool.

This PR fixes that and extends integration tests to cover TLS.

Closes #9

Pull Request Pull Request #37: fix: root CA support regression

Run Details

19 of 26 new or added lines in 1 file covered. (73.08%)

2 existing lines in 1 file now uncovered.

690 of 1080 relevant lines covered (63.89%)

14.14 hits per line