sapcc / limesctl

62%

master: 62%

LAST BUILD ON BRANCH fix-new-lints

branch: fix-new-lints

CHANGE BRANCH

x

Reset

• fix-new-lints
• autoupdateable-deps
• custom-request-body
• donotfail-on-low-keystone-perms
• fix-compare
• fix_formula
• fractional-quota-values
• go-cmp-ignore-fields
• goreleaser
• human-readable-values
• improved-quota-parsing
• liquid-comparison-service-infos
• liquidapi-validation
• master
• modernize
• new-limes-api
• openstack-variables
• phys-usage-empty-str
• quota-bursting
• refactor
• renovate/external-dependencies
• renovate/github.com-olekukonko-tablewriter-1.x
• renovate/github.comsapcc
• sbom
• sort_subcapacities
• test-workflow
• update_formula
• v1.0.0
• v1.1.0
• v1.2.0
• v1.3.0
• v1.4.0
• v1.4.1
• v1.5.0
• v1.5.1
• v1.5.2
• v1.6.0

Build # 14126534674

Build Type

Pull #269

github

Committed by majewsky

Commit Message

fix new lints

staticcheck has a new lint, QF1008, to remove superfluous references to
embedded fields. Because we have flagsets as embedded fields in our
commands, this results in nonsensical invocations, e.g.
"cmd.validate()" which really means "cmd.someFlagSet.validate()".

To avoid that, this changeset makes all the flagsets regular fields in
their command structs.

Pull Request Pull Request #269: fix new lints

Run Details

259 of 417 relevant lines covered (62.11%)

7.65 hits per line