sapcc / go-bits

31%

master: 31%

LAST BUILD ON BRANCH add_is_project_admin_token_field

branch: add_is_project_admin_token_field

CHANGE BRANCH

x

Reset

Sync Branches

• add_is_project_admin_token_field
• SuperSandro2000-patch-1
• assert-deepequal-match-input-types
• audittools-fix-gopherpolicy-integration
• audittools-fix-panic
• audittools-simple-mode
• audittools-simplification
• audittools_rabbitmq_persistence
• autoupdateable-deps
• bugfix-liquid-client
• bump-all-deps
• bump-jose
• bump-majewsky-gg
• cache_size
• configset-use-option
• context-background
• dependabot/go_modules/github.com/go-jose/go-jose/v3-3.0.3
• dependabot/go_modules/github.com/hashicorp/go-retryablehttp-0.7.7
• dependabot/go_modules/golang.org/x/net-0.38.0
• distributefairly-catch-errors
• easypg-better-test-mode
• easypg-fix-duplicate-keys-in-snapshot
• easypg-fix-quoting
• easypg-force-locale-on-testdb
• easypg-multiple-test-databases
• easypg-simplify-snapshots
• externalSecret
• fix-gomm
• fix_db_connection
• ginkgo-readiness
• ginkgo-readiness-audittools
• golangci-lint
• gophercloud2
• gophercloudext
• gophercloudext-customize-authoptions
• gophercloudext-fix-missing-domain
• gopherpolicy-compact-serialization
• gopherpolicy-remove-strict-yaml-dep
• http-utils
• httpext-limit-concurrent-requests
• httptest
• job-process-many
• jobloop-ctx-everywhere
• jobloop-improve-error-handling
• jobloop-jitter
• jobloop-panic
• lints
• liquid-client
• liquid-ignore-duplicate-service-info
• liquidapi
• liquidapi-commitment-delegation
• liquidapi-enable-profiling
• liquidapi-fix-distribute-fairly-overflow
• liquidapi-healthcheck
• liquidapi-use-gophercloudext
• liquidapi-utils
• master
• new-package-httpapi
• os-utils
• pluggable
• pprofapi
• promquery
• promquery-allow-zero-results-if-configured
• promquery-bulkcache
• promquery-support-json-config
• promquery-threadsafe-bulkquerycache
• regexpext
• regexpext-identifierconfigset
• regexpext-optimize-literals
• remove-gorilla-mux
• renovate/all
• renovate/external-dependencies
• renovate/github.com-lib-pq-1.x
• renovate/github.com-prometheus-client_golang-1.x
• renovate/github.com-rabbitmq-amqp091-go-1.x
• renovate/github.comsapcc
• renovate/go-1.x
• renovate/gopkg.in-yaml.v2-3.x
• renovate/major-external-dependencies
• respond-with-obsfuscated-error
• respondwith-clienterror
• respondwith-optimize-allocations
• revert-111-audittools_rabbitmq_persistence
• secrets-json
• sql-utils
• token-helper
• vault-remove-stat
• yaml

Build # 16293657410

Build Type

Pull #236

github

Committed by majewsky

Commit Message

review: do not store "is_admin_project" on type Token

My previous request to put this here was based on an incorrect
misremembering of how this package works. As the new WARNING comment
explains, private fields on type Token are dangerous because they can be
corrupted by the relevant various serialization roundtrips.

Pull Request Pull Request #236: gopherpolicy: add is_admin_project field to keystoneToken

Run Details

8 of 12 new or added lines in 3 files covered. (66.67%)

2 existing lines in 1 file now uncovered.

983 of 3138 relevant lines covered (31.33%)

3.39 hits per line