samvera / questioning_authority

91%

master: 98%

LAST BUILD ON BRANCH ld_refactor_mapping

branch: ld_refactor_mapping

CHANGE BRANCH

x

Reset

• ld_refactor_mapping
• 1-2-release
• 4.1.1_bug_fixes
• active-flag
• add_ldpath_for_findterm
• agrovoc_url
• api_doc
• auth_listing
• bixby
• bugfix_for_hyrax
• circleci
• code_climate_setup
• cors_headers
• coveralls_config
• deprecation/loc___configs
• deprecation/lod_full_config
• deprecation/search_query
• discogs
• discogs-context
• discogs-response-header
• discogs-update
• discogs_n3
• doc-templates
• engine_cart_update
• error_json
• filter_out_blanknodes
• fix-tgn-aat-sparql
• fix-ulan-sparql
• fix/206
• fix/244_loc_classification
• fix/246_data_size
• fix/247_predicates_nil
• fix/253_optional_context
• fix/255_config_default_for_optional
• fix/262_n3
• fix/exception_on_missing_id
• fix/ip_logging
• fix/performance_data_bug
• fix_broken_test_from_merge
• fix_docs
• fix_failing_tests
• fix_ld_term_fetch
• format_errmsg
• geonames-https
• index_name_exists_rails_6
• issues-308-jrgriffiniii-ruby-2.7
• json-ld
• jul19-ruby-versions
• keep_blanknodes
• lang_improvements
• ld_refactor_add_back_blanknode_filter
• ld_refactor_add_encode
• ld_refactor_add_prefixes
• ld_refactor_context_config
• ld_refactor_expansion_ldpath
• ld_refactor_graph_service_not_instance
• ld_refactor_init_config_parts_once
• ld_refactor_iri_template
• ld_refactor_language
• ld_refactor_ldpath
• ld_refactor_move_auth_service
• ld_refactor_pass_prefixes
• ld_refactor_process_context
• ld_refactor_qa_graph
• ld_refactor_rdf_service
• ld_refactor_remove_obsolete
• ld_refactor_sort
• ldpath_config
• ldpath_config2
• ldpath_languages
• ldpath_mapper_service
• ldpath_mapper_service2
• ldpath_refactor_findterm
• ldpath_search
• ldpath_service
• ldpath_term_mapper
• ldpath_term_tests
• loc_check
• log_ip
• master
• migration_rails5
• migrations_for_5.1
• min_context
• move_tests
• namespace_mesh
• new_configs
• num_sort
• oclcfast_rdfxml
• param_parse_template_url
• perf_data_service
• performance_stats
• prep_release
• prep_release_4.2.1
• prep_release_4.2.2
• prep_release_4.2.3
• rails-6
• rails6
• readme_do_to_wiki
• refactor_opt_attrs
• refine_deprecation_msgs
• release/5.2.0
• release/5.3.0
• release/5.3.1
• release_2.0.1
• release_2_1
• release_4.1.1
• release_4.2.0
• release_4.2.5
• release_4_0
• release_4_1_0
• release_5.0.0
• release_501
• remove_4.2_support
• remove_agrovoc
• remove_deprecations
• remove_rails4_support
• request_id
• resource_url
• response_header
• response_media_type
• robust_getty_error_handling
• stable_1.2_for_rails_4.2
• swagger_api_doc
• update_ruby_matrix
• uri-fix
• uri_escape_replacement
• uri_to_s
• v1.2.0
• v2.0.0
• v2.0.1
• v2.1.0
• v2.1.1
• v2.1.2
• v2.2.0
• v3.0.0
• v4.0.0
• version_2.0.0
• webmock-breaking
• wikidata

Build # 907

Build Type

Pull #192

travis-ci

Committed by web-flow

Commit Message

hold names of services in class attributes

Two benefits of this approach:
* simplify the code by removing long module/class refs in methods
* simplify future refactors that might want to swap out a service by having a single reference to external classes at the top of the class using them

Pull Request Pull Request #192: Extract out search results mapping to services

Run Details

53 of 53 new or added lines in 3 files covered. (100.0%)

1692 of 1853 relevant lines covered (91.31%)

481.96 hits per line