samsarahq / thunder

66%

master: 66%

LAST BUILD ON BRANCH codebrew28/normalizerepeatsbugfix

branch: codebrew28/normalizerepeatsbugfix

CHANGE BRANCH

x

Reset

• codebrew28/normalizerepeatsbugfix
• CodeBrew28-patch-1
• aaronz/mysql-force-index
• aaronz/select-for-update
• add-coveralls
• ahuang/binlog_localhost
• alanefl/dynamiclimit-return-query-on-error
• alanefl/sqlgen-db-add-dynamiclimit
• albert/federatepaginate
• albert/mutex
• albert/pagination
• albert/pagination-backup
• albert/support-obj
• albert/support-obj-2
• amonks/1.15-ci
• amyliu/federation_directives
• amyliu/make_public
• amyliu/test_directives
• anubhav/fix_stuff
• bf/add-baseline-benchmark
• bf/add-benchmarks
• bf/add-changelog
• bf/add-example-struct-tags
• bf/allow-new-tags
• bf/case-insensitive-filter
• bf/changelog-mysql
• bf/fix-diffing-nil
• bf/handle-mysql-formatted-time
• bf/handle-pointer-interface-nil
• bf/improve-binlog-error
• bf/non-ptr-proto-support
• bf/optimize
• bf/pagination
• bf/pagination-bugfixes
• bf/pagination-filter
• bf/pagination-filter-poc
• bf/support-byteslice-types
• bf/types-2.0
• bf/types-package
• bf/updates
• btuan/count
• changping/build-struct
• changping/context-lock
• changping/ctx
• changping/depsvc
• changping/diff-key
• changping/fix-memory
• changping/no-panic
• changping/oneof
• changping/revert
• changping/runmiddlewares
• changping/scan-error
• changping/serialize
• changping/value-filter
• codebew28/esposemetadata
• codebrew28/ManualPaginationWithFallback
• codebrew28/NonExpensiveContext
• codebrew28/SimplifyApi1
• codebrew28/batchPagiantedSorts
• codebrew28/batchingPaginationFlagError
• codebrew28/batchingpagination
• codebrew28/cleanUpNonBatchExecutor
• codebrew28/convertversionedschema
• codebrew28/customFederatedKeys
• codebrew28/customFederatedServer
• codebrew28/customexecutorresponse
• codebrew28/errorhandlingfederationplanner
• codebrew28/errorhandlingtests
• codebrew28/executorOptionalArgs
• codebrew28/executorfederated
• codebrew28/executorfederationpt1
• codebrew28/expensiveArgumentForPagiantedSorts
• codebrew28/expnesiveFederatedFFs
• codebrew28/fedderationdocs
• codebrew28/federatedExecutorpart1
• codebrew28/federatedExecutorpart2
• codebrew28/federatedExecutorpart4
• codebrew28/federatedExecutorpart5
• codebrew28/federatedKeys
• codebrew28/federatedffApiSimplification
• codebrew28/federatedfieldfuncsWithFallback
• codebrew28/federationApi
• codebrew28/federationBug
• codebrew28/federationEnumAsInputObject
• codebrew28/federationExecutorNestedServices
• codebrew28/federationExecutorNestedServicesUnionTypes
• codebrew28/federationMethodNameFormat
• codebrew28/federationNameConvention
• codebrew28/federationSchema
• codebrew28/federationedfieldfunc
• codebrew28/filterTextSpecifications
• codebrew28/lowercasepgainatedsort
• codebrew28/manualPaginationIssue
• codebrew28/memoryAllocationFix
• codebrew28/migrationfederation
• codebrew28/morePaginationTestsPls
• codebrew28/morefederationtests
• codebrew28/multipleFederatedKeys
• codebrew28/nonnullablebug
• codebrew28/normalizebug
• codebrew28/objectName
• codebrew28/paginatedFilterOptimization
• codebrew28/pagination
• codebrew28/paginationFilterExpensive
• codebrew28/paginationInfo
• codebrew28/paginationSortAndFilterFields
• codebrew28/paginationWorkScheduler
• codebrew28/parnetselection
• codebrew28/planning
• codebrew28/refactorFilters
• codebrew28/renameShouldUseBatchFunc
• codebrew28/renamefederation
• codebrew28/savewip
• codebrew28/schemasyncer
• codebrew28/serviceseelctorthundderbug
• codebrew28/shadowFieldFuncbug
• codebrew28/shadowTypeValidation
• codebrew28/skipAndIncludeDirectives
• codebrew28/testingAddingAndDeletingKeys
• codebrew28/unmarshallingErrors
• codebrew28/updateFederationApi
• dependabot/npm_and_yarn/client/acorn-5.7.4
• dependabot/npm_and_yarn/client/chownr-1.1.4
• dependabot/npm_and_yarn/client/decode-uri-component-0.2.2
• dependabot/npm_and_yarn/client/handlebars-4.7.6
• dependabot/npm_and_yarn/client/handlebars-4.7.7
• dependabot/npm_and_yarn/client/hosted-git-info-2.8.9
• dependabot/npm_and_yarn/client/ini-1.3.7
• dependabot/npm_and_yarn/client/lodash-4.17.19
• dependabot/npm_and_yarn/client/lodash-4.17.21
• dependabot/npm_and_yarn/client/merge-1.2.1
• dependabot/npm_and_yarn/client/mixin-deep-1.3.2
• dependabot/npm_and_yarn/client/path-parse-1.0.7
• dependabot/npm_and_yarn/client/qs-6.4.1
• dependabot/npm_and_yarn/client/shell-quote-1.7.3
• dependabot/npm_and_yarn/client/tar-2.2.2
• dependabot/npm_and_yarn/client/ua-parser-js-0.7.28
• dependabot/npm_and_yarn/client/ua-parser-js-0.7.33
• dependabot/npm_and_yarn/client/y18n-3.2.2
• dependabot/npm_and_yarn/example/client/codemirror-5.61.0
• dependabot/npm_and_yarn/example/client/css-what-2.1.3
• dependabot/npm_and_yarn/example/client/express-4.18.2
• dependabot/npm_and_yarn/example/client/graphiql-1.4.7
• dependabot/npm_and_yarn/example/client/handlebars-4.1.2
• dependabot/npm_and_yarn/example/client/handlebars-4.5.3
• dependabot/npm_and_yarn/example/client/handlebars-4.7.6
• dependabot/npm_and_yarn/example/client/handlebars-4.7.7
• dependabot/npm_and_yarn/example/client/hosted-git-info-2.8.9
• dependabot/npm_and_yarn/example/client/http-proxy-1.18.1
• dependabot/npm_and_yarn/example/client/ini-1.3.7
• dependabot/npm_and_yarn/example/client/is-my-json-valid-2.20.5
• dependabot/npm_and_yarn/example/client/marked-0.3.19
• dependabot/npm_and_yarn/example/client/merge-1.2.1
• dependabot/npm_and_yarn/example/client/path-parse-1.0.7
• dependabot/npm_and_yarn/example/client/sockjs-0.3.21
• dependabot/npm_and_yarn/example/client/tar-2.2.2
• dependabot/npm_and_yarn/example/client/ua-parser-js-0.7.28
• dependabot/npm_and_yarn/example/client/ua-parser-js-0.7.31
• dependabot/npm_and_yarn/example/client/ua-parser-js-0.7.33
• dependabot/npm_and_yarn/example/client/websocket-extensions-0.1.4
• dependabot/npm_and_yarn/example/client/y18n-3.2.2
• dependabot/npm_and_yarn/graphql/graphiql/async-2.6.4
• dependabot/npm_and_yarn/graphql/graphiql/clean-css-4.1.11
• dependabot/npm_and_yarn/graphql/graphiql/css-what-2.1.3
• dependabot/npm_and_yarn/graphql/graphiql/elliptic-6.5.3
• dependabot/npm_and_yarn/graphql/graphiql/elliptic-6.5.4
• dependabot/npm_and_yarn/graphql/graphiql/extend-3.0.2
• dependabot/npm_and_yarn/graphql/graphiql/graphiql-1.4.7
• dependabot/npm_and_yarn/graphql/graphiql/hosted-git-info-2.8.9
• dependabot/npm_and_yarn/graphql/graphiql/ini-1.3.7
• dependabot/npm_and_yarn/graphql/graphiql/lodash-4.17.15
• dependabot/npm_and_yarn/graphql/graphiql/lodash-4.17.21
• dependabot/npm_and_yarn/graphql/graphiql/macaddress-0.2.9
• dependabot/npm_and_yarn/graphql/graphiql/marked-0.3.19
• dependabot/npm_and_yarn/graphql/graphiql/qs-6.4.1
• dependabot/npm_and_yarn/graphql/graphiql/sshpk-1.16.1
• dependabot/npm_and_yarn/graphql/graphiql/stringstream-0.0.6
• dependabot/npm_and_yarn/graphql/graphiql/tar-2.2.2
• dependabot/npm_and_yarn/graphql/graphiql/ua-parser-js-0.7.28
• dependabot/npm_and_yarn/graphql/graphiql/ua-parser-js-0.7.33
• dependabot/npm_and_yarn/graphql/graphiql/y18n-3.2.2
• ehzhang/non-null-directives
• export-workunit-fields
• ez/example_client_upgrade
• ez/graphiql_deps_upgrade
• frost/withtx-ctx
• jelle/federation
• jelle/federation-normalize
• jelle/shard-limit
• jelle/terrible-option
• jl3329/allow-hashing-complex-types
• jl3329/fail-schema-on-duplicate-type-name
• jl3329/rm-caching-for-expensive-work-units
• jl3329/track-dependencies-per-selection
• jsm/wrap
• justinlevine/pass-args-down
• kevinxing/add-test-to-patcher
• kevinxing/augment-IntrospectionSyncer
• kevinxing/cleanup-messed-code
• kevinxing/directive-fragment-fix
• kevinxing/federation-executor-api-1
• kevinxing/federation-migration
• kevinxing/federation-migration-2
• kevinxing/fix-bug
• kevinxing/fix-infinite-loop-in-mergeSameAlias
• kevinxing/fix-typo
• kevinxing/introduce-NonNullableListTyping
• kevinxing/some-improvement
• kevinxing/test
• kevinxing/test-add-dependencies
• kevinxing/use-external-executor-in-mutation
• lulucas/fix-empty-type-name
• master
• pagination-parallel
• revert-167-changping/revert
• revert-281-wdaly/thunder-gql-inexpensive-check
• revert-309-wdaly/undo-revert
• revert-535-weilian/federation_introspection_client
• shahryart/change-txkey
• shane/optional-directive
• simon/panic-on-no-index-option
• simon/update-explain-parse
• sshi/fix-flatten
• stephen/cause
• stephen/context-cancellation
• stephen/dedupe-names
• stephen/error
• stephen/fix
• stephen/fix-sql-validation
• stephen/flatten-fix
• stephen/generic-handlers
• stephen/more-flatten-fix
• stephen/tm
• stephen/unwrap
• tacocat21/OB-83-adding-message-to-oops
• tonia/pass-custom-filterfunc
• v0.1.0
• v0.2.0
• v0.3.0
• v0.3.1
• v0.5.0
• wc/simple_where_tosql_null_filter_support
• wdaly/add-missing-dependencies
• wdaly/bff-with-fallback-always-expensive
• wdaly/expensive-field-func-option-take-two
• wdaly/expose-sanitize-helper
• wdaly/expose-workunit-session
• wdaly/fix-batch-expensive
• wdaly/fix-dependencies
• wdaly/hacky-projection-prototype
• wdaly/reenable-expensive-option
• wdaly/remove-query
• wdaly/table-views
• wdaly/thunder-gql-inexpensive-check
• wdaly/tmp-revert
• wdaly/undo-revert
• weilian/expand_federation_schema
• weilian/federation-execute-root
• weilian/federation_introspection_client
• weilian/introspection_client_schema
• weilian/introspection_helper
• wh/BFFs/part-1.0
• wh/asyncScheduler/part-1.0
• wh/batchExternal/part-1.0
• wh/batchFieldFunc/part-1.0
• wh/batchFieldFunc/part-2.0
• wh/batchIndex/part-1.0
• wh/batchIndexStruct/part-1.0
• wh/batchSizes/part-1.0
• wh/clearCacheOnRetry/part-1.0
• wh/deleteClearAll/part-1.0
• wh/diffFIx/part-1.0
• wh/execOverride/part-1.0
• wh/exposeCTX/part-1.0
• wh/fixIndexing/part-1.0
• wh/fixNilBatchFuncs/part-1.0
• wh/fixNilBatchFuncs/part-2.0
• wh/fixNilBatchFuncs/part-3.0
• wh/fixoptional/part-1.0
• wh/mutateMemLeak/part-1.0
• wh/newExecutor/part-1.0
• wh/newExecutor/part-2.0
• wh/newExecutor/part-3.0
• wh/noCicular/part-1.0
• wh/noMarshalFuncs/part-1.0
• wh/nonSelectionBatching/part-1.0
• wh/noopexpensive/part-1.0
• wh/optionaltest/part-1.0
• wh/protoStuff/part-1.0
• wh/purgecache/part-1.0
• wh/release/part-1.0
• wh/shortCircuit/part-1.0
• wh/starts/batchFieldFunc/part-2.0
• wh/starts/batchFieldFunc/part-3.0
• wh/starts/batchFieldFunc/part-4.0
• wh/starts/fixNilBatchFuncs/part-2.0
• wh/starts/fixNilBatchFuncs/part-3.0
• wh/starts/newExecutor/part-3.0
• wh/starts/uuidmarshal/part-2.0
• wh/starts/uuidmarshal/part-3.0
• wh/stopleak/part-1.0
• wh/unwrap/part-1.0
• wh/uuidmarshal/part-1.0
• wh/uuidmarshal/part-2.0
• wh/uuidmarshal/part-3.0
• witold/postprocess
• workunit-field-access-methods
• yolanda/batch-index-marshal
• zachdylag/RerunnerSleep
• zachdylag/reusecomputationinput
• zmgreen/sqlgen_batch_upsert

Build # 3189

Build Type

push

travis-ci

Committed by CodeBrew28

Commit Message

federation: remove repeated selection and fragment parsing

When we were merging aliases, if we saw a repeated selection or fragment, we were adding it to the list again. Now we use a dictionary to check we don't add the same selection or fragment more than once, which helps reduce the number of times we need to flatten and merge aliases.

Once we parse a flatten a fragment, we remove it from the list of fragments since its already been parsed, which further helps prevent repeated parsing

Run Details

5935 of 8979 relevant lines covered (66.1%)

11632.78 hits per line