samsarahq / thunder
62%
master: 66%

LAST BUILD BRANCH: dependabot/npm_and_yarn/client/ua-parser-js-0.7.33
DEFAULT BRANCH: master
Repo Added
Files 59
Badge
Embed â–¾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH ahuang/binlog_localhost
branch: ahuang/binlog_localhost
CHANGE BRANCH
x

coverage: 62.216% (-0.005%) from 62.221%
2186

push

travis-ci

arthurhuang 
go livesql/binlog: set Localhost in binlogSyncerConfig

This sets the localhost field of the BinlogSyncerConfig. If unset,
as it was, it will use the os.Hostname() value as the hostname instead.

In rare situations, the OS's hostname could be too long for the slave
host's "host" field, and we got an error like:

  panic: ERROR 1105 (HY000): Failed to register slave: too long 'report-host'

which would crash the server. So we strip the hostname to be 60
characters, which is the max allowed length.

It doesn't seem like the hostname of the slave hosts matters that much;
Verified everything still worked as expected. We could hardcode
"localhost" here as the host name but are keeping the OS's hostname in
case it's useful for debugging on remote hosts.

To see the hostname of slave hosts:
mysql> show slave hosts;
+------------+--------------------------+------+-----------+------------+
| Server_id  | Host                     | Port | Master_id | Slave_UUID |
+------------+--------------------------+------+-----------+------------+
| 2926146535 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 4101280766 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
|  738891311 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 3490062834 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 3176772553 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
|  985189460 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 4240725287 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 2752132824 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 3221796892 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 3038601891 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
+------------+--------------------------+------+-----------+------------+

Also see https://github.com/siddontang/go-mysql/issues/388

4357 of 7003 relevant lines covered (62.22%)

14369.99 hits per line

Relevant lines Covered
7003 RELEVANT LINES 4357 COVERED LINES
14369.99 HITS PER LINE
Source Files on ahuang/binlog_localhost
Detailed source file information is not available for this build.

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
2186 ahuang/binlog_localhost go livesql/binlog: set Localhost in binlogSyncerConfig This sets the localhost field of the BinlogSyncerConfig. If unset, as it was, it will use the os.Hostname() value as the hostname instead. In rare situations, the OS's hostname could be too ... push arthurhuang travis-ci
62.22
2187 ahuang/binlog_localhost go livesql/binlog: set Localhost in binlogSyncerConfig This sets the localhost field of the BinlogSyncerConfig. If unset, as it was, it will use the os.Hostname() value as the hostname instead. In rare situations, the OS's hostname could be too ... Pull #334 web-flow travis-ci
62.2
2182 ahuang/binlog_localhost go livesql/binlog: set Localhost in binlogSyncerConfig This sets the hostname of the slave hosts to be "localhost". If unset, as it was, it will use the os.Hostname() value as the hostname instead. In rare situations, the OS's hostname could be ... Pull #334 web-flow travis-ci
62.21
2181 ahuang/binlog_localhost go livesql/binlog: set Localhost in binlogSyncerConfig This sets the hostname of the slave hosts to be "localhost". If unset, as it was, it will use the os.Hostname() value as the hostname instead. In rare situations, the OS's hostname could be ... push arthurhuang travis-ci
62.22
See All Builds (1959)