samsarahq / taskrunner

53%

master: 45%

LAST BUILD ON BRANCH tonia/logf

branch: tonia/logf

CHANGE BRANCH

x

Reset

• tonia/logf
• ashaw/go_builder
• bf/add-travis
• bf/annotations
• bf/better-api
• bf/better-logging-for-goextensions
• bf/bugfixes
• bf/fix-datarace
• bf/persistent-invalidation-cache
• bf/tui
• changping/gqltaskrunner
• danhansen/fix-watcher-panic
• datadog_usage_monitoring
• denbeigh/hack-modules-build
• dependabot/go_modules/golang.org/x/crypto-0.1.0
• dependabot/go_modules/golang.org/x/net-0.7.0
• dependabot/go_modules/golang.org/x/sys-0.1.0
• dschofie/listall
• dschofie/models-combine
• jelle/watch
• jesse/add-license
• jesse/description
• jesse/extension
• jesse/isgroup
• jesse/taskrunner-help
• johnkim/add-owner-field-to-task
• johnkim/failOnAnyInvalidTask
• johnkim/go1.17
• johnkim/handle-sighup
• jsm/shell-run-options
• master
• mdb/dynamically-set-up-go-in-ci
• pass-cl-args-to-tasks
• samloop/add-taskrunner-owners-to-annotations
• samloop/improve-runner-logging
• samloop/test
• samloop/update-github-actions
• sara/task_description
• shane/line-buffer-output
• shaunhoulihan/goupdate
• shaunhoulihan/readable
• simon/add-warning-option
• stephen-patch-1
• stephen/config-rewrite
• stephen/execs
• stephen/fixes
• stephen/propagate
• stephen/remove-livelogger
• stephen/stdout-option
• tonia/fix-flags-to-tr
• tonia/fix-silent-runner-task-invalidation
• tonia/runwithgo
• tonia/support-task-flags
• tonia/support-task-options
• tonia/validate-tasks-in-runner
• wh/symboliclinks/part-1.0
• zack/update-node-modules

Build # 5257122225

Build Type

push

github

Committed by toniihsia

Commit Message

taskrunner logger: if no logger found in ctx, fallback to Printf

If LoggerFromContext returns nil, then the log is dropped.

Instead of dropping the log, print a warning and fallback to using
`fmt.Printf` to ensure:
* The log is still shown
* The developer is warned that no logger was found

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

730 of 1390 relevant lines covered (52.52%)

4.77 hits per line