salsify / delayed_job_heartbeat_plugin

97%

master: 96%

LAST BUILD ON BRANCH feature/PLAT-1593-unlock-jobs-on-term

branch: feature/PLAT-1593-unlock-jobs-on-term

CHANGE BRANCH

x

Reset

• feature/PLAT-1593-unlock-jobs-on-term
• bug/missing-migration-version
• feature/genesis
• feature/logger
• feature/test-rubies
• master
• v0.1.0
• v0.2.0

Build # 31

Build Type

push

travis-ci

Committed by atsheehan

Commit Message

Worker clears locks on shutdown [PLAT-1593]

In some cases the ClearLocks plugin from Delayed::Job may fail to clear
the locked_at/locked_by fields on a job because it was interrupted at a
bad time (see [PLAT-1590]). The delayed_worker is still removed since
the heartbeat is using a separate connection, leaving orphaned jobs
behind that are not re-run until the 4 hour max run time has passed.

This change will require the worker to clear its own locks when it is
shutting down before it removes itself from the delayed_workers table.

Run Details

166 of 171 relevant lines covered (97.08%)

131.3 hits per line