• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

safe-global / safe-smart-account
95%
main: 94%

Build:
Build:
LAST BUILD BRANCH: chore/migrate-away-from-cla-assistant
DEFAULT BRANCH: main
Repo Added 22 Jan 2024 09:44AM UTC
Files 42
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH feat/domain-separator-perf
branch: feat/domain-separator-perf
CHANGE BRANCH
x
Reset
  • feat/domain-separator-perf
  • 1.4.1/backmerge-coveralls-job-fix
  • 1.4.1/backport-safetol2setup-contract
  • 1.5-addresses
  • 731-imports-ordering-for-contracts
  • 992-disablemodule-not-sufficiently-documented
  • ackee/i1
  • ackee/i2
  • ackee/i3
  • ackee/i4
  • ackee/i7
  • ackee/i8
  • ackee/l1
  • ackee/l2
  • ackee/l3
  • ackee/m1
  • ackee/w1
  • ackee/w2
  • ackee/w3
  • ackee/w4
  • ackee/w5
  • ackee/w6
  • assembly-encodeSafeTransactionData
  • audit/v1.5
  • better-variable-naming-in-eip-712-hashing
  • bug/benchmark-ci-silent-fail
  • bump-v1.4.1-2
  • bump-version/v1.4.1-1
  • certora-workfile
  • certora/v6-spec-update
  • changelog-v1.5.0
  • chore/bump-dependencies
  • chore/bump-hardhat-toolbox
  • chore/consistent-nat-spec
  • chore/deprecate-zksync
  • chore/disable-zksync-tests
  • chore/doc-fixes
  • chore/fix-harness-patch
  • chore/fix-ts-lints
  • chore/fix-up-migration-tests
  • chore/migrate-away-from-cla-assistant
  • chore/no-longer-disable-reporter-test
  • chore/prepare-release-1.5.0
  • chore/refactor-migration-tests
  • chore/refactor-zk-sync-ci
  • chore/release-1.5.0-readme
  • chore/safe-singleton-factory-v2
  • chore/self-owned-safe-warning
  • chore/update-certora-cli
  • chore/update-current-version
  • chore/update-dependencies
  • chore/update-node-js
  • chore/update-readme-release-v1.4.1-2
  • chore/update-transitive-deps
  • codeowners
  • core/bump-toolbox-v6-pt2
  • creationCodeHash
  • dep-bumppppp
  • dependabot/npm_and_yarn/braces-3.0.3
  • dependabot/npm_and_yarn/follow-redirects-1.15.6
  • dependabot/npm_and_yarn/form-data-4.0.4
  • dependabot/npm_and_yarn/multi-b29f0fd473
  • dependabot/npm_and_yarn/multi-c22b14adf9
  • dependabot/npm_and_yarn/pbkdf2-3.1.3
  • dependabot/npm_and_yarn/secp256k1-4.0.4
  • dependabot/npm_and_yarn/sha.js-2.4.12
  • dependabot/npm_and_yarn/undici-5.28.3
  • dependabot/npm_and_yarn/undici-5.28.4
  • dependencies/upgrade
  • deprecated-test-removal
  • deps-bump
  • doc/fix-simulation-natspec
  • doc/fixes
  • doc/more-natspec-fixes
  • docs/get-transaction-hash-dirty-bits
  • docs/simulate-and-revert
  • enable-zksync-tests
  • erc777-compat-comments
  • error-propagation
  • experiment/auto-l2-safe
  • extensible-fallback-handler
  • fallback-handler-comments
  • feat/dep-update
  • feat/disable-pre-approved-1271-signature
  • feat/migration-to-l2-deprecation
  • feat/safe-7702
  • feat/support-pre-approved-1271-signature
  • feat/update-certora-prover
  • feature-787-migration-contract
  • feature-context-in-module-tx
  • feature/eip-7702
  • feature/module-tx-guard
  • fix
  • fix-735-compilation-with-new-solidity-version
  • fix-735-compilation-with-new-solidity-version-temp
  • fix-754-signature-length-check
  • fix-790-update-changelog
  • fix-emit-event-in-SafeL2-execTransactionFromModuleReturnData
  • fix-errors
  • fix-link
  • fix-natspec-inheritdoc
  • fix-solidity-range
  • fix-typo
  • fix/build
  • fix/ci-coverage
  • fix/fallback-simulation
  • fix/incorrect-length-comment-svm
  • fix/memory-safe-assembly
  • fix/multisend-payability
  • fix/shifting-bits-not-bytes
  • fix/zk-tests
  • g01
  • g02
  • g03
  • g04
  • g05
  • g06
  • g07
  • g08
  • g09
  • g10
  • getSafeWithOwners-ts
  • getsafe
  • i02-keccak256
  • i03
  • improvement-add-transaction-pre-hooks
  • improvement-execTransaction-post-call-hook
  • library-audit
  • main
  • migration-contract-141
  • migration-fv
  • migration-tests-zksync
  • mmv08-patch-1
  • moldovan
  • new-safe-v1.5-addresses
  • patch
  • patch-1
  • patch-2
  • pin-anvil-zksync
  • refs/tags/v1.4.1-1
  • release/v1.4.1
  • release/v1.4.1-1
  • release/v1.4.1-2
  • release/v1.4.1-2-deployment
  • release/v1.4.1-3
  • release/v1.5.0
  • remove-payable
  • remove-unused-test-contracts
  • remove-vscode-junm
  • revert-1026-main
  • revert-973-ackee/w1
  • safe-proxy-event
  • safeToL2Migration-zksync
  • sig-malleability-comments
  • signing-constants
  • storage-constants
  • storage-constants-v2
  • temp/1.5.0-build
  • test-workflow
  • typo
  • typo-pass-1
  • typos
  • update-compatibility-documentation
  • updating-dependencies
  • using-returndatasize
  • v1.4.1-2
  • v1.4.1-2-audit
  • v1.4.1-3
  • v1.4.1-audit-and-address
  • v1.4.1-audit-changes
  • v1.4.1/singleton-factory-update
  • v1.4.1/zksync-compat
  • v1.5-addresses
  • v1.5-audit-report
  • v1.5.0
  • v1.5.0-audit
  • v1.5.0-base
  • v1.5.0-zksync
  • v1_3_0_zksync
  • workflow-updated
  • zksync-error-update
  • zksync-failing-test
  • zksync-node-bump

10 Jul 2025 08:44AM UTC coverage: 94.514% (-0.01%) from 94.527%
16190460171

Pull #1016

github

nlordell
Refactor `domainSeparator` implementation

We give it the same treatment as `getTransactionHash`, as it has
sufficiently substantial gains IMO, and the assembly is simple enough.

**Before:**

```
$ npm run codesize | grep '^Safe '
Safe 21434 bytes (limit is 24576)

$ npm run benchmark | grep -A4 'ERC20 - transfer' | sed '1P;$!N;$!D'
  ERC20 - transfer
           Used 82498n gas for >transfer<
    ✔ with a single owner Safe
```

**After:**

```
$ npm run codesize | grep '^Safe '
Safe 21372 bytes (limit is 24576)

$ npm run benchmark | grep -A4 'ERC20 - transfer' | sed '1P;$!N;$!D'
  ERC20 - transfer
           Used 82382n gas for >transfer<
    ✔ with a single owner Safe
```
Pull Request #1016: Refactor `domainSeparator` implementation

308 of 340 branches covered (90.59%)

Branch coverage included in aggregate %.

450 of 462 relevant lines covered (97.4%)

109.05 hits per line

Relevant lines Covered
Build:
Build:
462 RELEVANT LINES 450 COVERED LINES
109.05 HITS PER LINE
Source Files on feat/domain-separator-perf
  • Tree
  • List 42
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
16190460171 feat/domain-separator-perf Refactor `domainSeparator` implementation We give it the same treatment as `getTransactionHash`, as it has sufficiently substantial gains IMO, and the assembly is simple enough. **Before:** ``` $ npm run codesize | grep '^Safe ' Safe 21434 byte... Pull #1016 10 Jul 2025 08:47AM UTC nlordell github
94.51
See All Builds (831)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc