safe-global / safe-smart-account
94%
main: 94%

LAST BUILD BRANCH: patch-1
DEFAULT BRANCH: main
Repo Added
Files 42
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH chore/refactor-zk-sync-ci
branch: chore/refactor-zk-sync-ci
CHANGE BRANCH
x

coverage: 93.957%. Remained the same
14381184277

Pull #939

github

nlordell 
Separate zkSync Tests to Separate CI Step

This PR moves the zkSync tests outside of the normal `test` NPM
script. Since this would make it no longer run by default in CI, we
added a separate `tests-zk` step to run the zkSync tests only.

This split allows us to potentially merge PRs when zkSync tests fail
as long as the normal test suite does not. It is not the first time
that CI starts failing without cause because of zkSync tests. As far
as I can tell, the zkSync tooling downloads an in-memory node binary
that it starts for actually executing the tests. In the past, tests
have randomly started to fail because of:

* Changes to the behaviour of the in-memory node ([example](https://github.com/safe-global/safe-smart-account/actions/runs/14359540825/job/40257156305?pr=938))
* Binary no longer hosted on the same URL ([example](https://github.com/safe-global/safe-smart-account/actions/runs/14359540825/job/40257156305?pr=938))

When this happens, we do not want to block changes that are unrelated
to contract logic (as they should not, in theory, have any affect on
the zkSync tests).

Furthermore, running the zkSync tests takes quite a bit longer than the
regular tests, so this also makes local `npm test` a bit faster.
Pull Request #939: Separate zkSync Tests to Separate CI Step

325 of 366 branches covered (88.8%)

Branch coverage included in aggregate %.

499 of 511 relevant lines covered (97.65%)

100.87 hits per line

Relevant lines Covered
511 RELEVANT LINES 499 COVERED LINES
100.87 HITS PER LINE
Source Files on chore/refactor-zk-sync-ci

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
14381184277 chore/refactor-zk-sync-ci Separate zkSync Tests to Separate CI Step This PR moves the zkSync tests outside of the normal `test` NPM script. Since this would make it no longer run by default in CI, we added a separate `tests-zk` step to run the zkSync tests only. This spl... Pull #939 nlordell github
93.96
14380860124 chore/refactor-zk-sync-ci Separate zkSync Tests to Separate CI Step This PR moves the zkSync tests outside of the normal `test` NPM script. Since this would make it no longer run by default in CI, we added a separate `tests-zk` step to run the zkSync tests only. This spl... Pull #939 nlordell github
93.39
14377749090 chore/refactor-zk-sync-ci Separate zkSync Tests to Separate CI Step This PR moves the zkSync tests outside of the normal `test` NPM script. Since this would make it no longer run by default in CI, we added a separate `tests-zk` step to run the zkSync tests only. This spl... Pull #939 nlordell github
93.96
14375477437 chore/refactor-zk-sync-ci Separate zkSync Tests to Separate CI Step This PR moves the zkSync tests outside of the normal `test` NPM script. Since this would make it no longer run by default in CI, we added a separate `tests-zk` step to run the zkSync tests only. This spl... Pull #939 nlordell github
93.39
See All Builds (830)