safe-global / safe-smart-account

94%

main: 94%

LAST BUILD ON BRANCH ackee/w6

branch: ackee/w6

CHANGE BRANCH

x

Reset

• ackee/w6
• 1.4.1/backmerge-coveralls-job-fix
• 1.4.1/backport-safetol2setup-contract
• 1.5-addresses
• 731-imports-ordering-for-contracts
• 992-disablemodule-not-sufficiently-documented
• ackee/i1
• ackee/i2
• ackee/i3
• ackee/i4
• ackee/i7
• ackee/i8
• ackee/l1
• ackee/l2
• ackee/l3
• ackee/m1
• ackee/w1
• ackee/w2
• ackee/w3
• ackee/w4
• ackee/w5
• assembly-encodeSafeTransactionData
• audit/v1.5
• better-variable-naming-in-eip-712-hashing
• bug/benchmark-ci-silent-fail
• bump-v1.4.1-2
• bump-version/v1.4.1-1
• certora-workfile
• certora/v6-spec-update
• changelog-v1.5.0
• chore/bump-dependencies
• chore/bump-hardhat-toolbox
• chore/consistent-nat-spec
• chore/deprecate-zksync
• chore/disable-zksync-tests
• chore/doc-fixes
• chore/fix-harness-patch
• chore/fix-ts-lints
• chore/fix-up-migration-tests
• chore/migrate-away-from-cla-assistant
• chore/no-longer-disable-reporter-test
• chore/prepare-release-1.5.0
• chore/refactor-migration-tests
• chore/refactor-zk-sync-ci
• chore/release-1.5.0-readme
• chore/safe-singleton-factory-v2
• chore/self-owned-safe-warning
• chore/update-certora-cli
• chore/update-current-version
• chore/update-dependencies
• chore/update-node-js
• chore/update-readme-release-v1.4.1-2
• chore/update-transitive-deps
• codeowners
• core/bump-toolbox-v6-pt2
• creationCodeHash
• dep-bumppppp
• dependabot/npm_and_yarn/braces-3.0.3
• dependabot/npm_and_yarn/follow-redirects-1.15.6
• dependabot/npm_and_yarn/form-data-4.0.4
• dependabot/npm_and_yarn/multi-b29f0fd473
• dependabot/npm_and_yarn/multi-c22b14adf9
• dependabot/npm_and_yarn/pbkdf2-3.1.3
• dependabot/npm_and_yarn/secp256k1-4.0.4
• dependabot/npm_and_yarn/sha.js-2.4.12
• dependabot/npm_and_yarn/undici-5.28.3
• dependabot/npm_and_yarn/undici-5.28.4
• dependencies/upgrade
• deprecated-test-removal
• deps-bump
• doc/fix-simulation-natspec
• doc/fixes
• doc/more-natspec-fixes
• docs/get-transaction-hash-dirty-bits
• docs/simulate-and-revert
• enable-zksync-tests
• erc777-compat-comments
• error-propagation
• experiment/auto-l2-safe
• extensible-fallback-handler
• fallback-handler-comments
• feat/dep-update
• feat/disable-pre-approved-1271-signature
• feat/domain-separator-perf
• feat/migration-to-l2-deprecation
• feat/safe-7702
• feat/support-pre-approved-1271-signature
• feat/update-certora-prover
• feature-787-migration-contract
• feature-context-in-module-tx
• feature/eip-7702
• feature/module-tx-guard
• fix
• fix-735-compilation-with-new-solidity-version
• fix-735-compilation-with-new-solidity-version-temp
• fix-754-signature-length-check
• fix-790-update-changelog
• fix-emit-event-in-SafeL2-execTransactionFromModuleReturnData
• fix-errors
• fix-link
• fix-natspec-inheritdoc
• fix-solidity-range
• fix-typo
• fix/build
• fix/ci-coverage
• fix/fallback-simulation
• fix/incorrect-length-comment-svm
• fix/memory-safe-assembly
• fix/multisend-payability
• fix/shifting-bits-not-bytes
• fix/zk-tests
• g01
• g02
• g03
• g04
• g05
• g06
• g07
• g08
• g09
• g10
• getSafeWithOwners-ts
• getsafe
• i02-keccak256
• i03
• improvement-add-transaction-pre-hooks
• improvement-execTransaction-post-call-hook
• library-audit
• main
• migration-contract-141
• migration-fv
• migration-tests-zksync
• mmv08-patch-1
• moldovan
• new-safe-v1.5-addresses
• patch
• patch-1
• patch-2
• pin-anvil-zksync
• refs/tags/v1.4.1-1
• release/v1.4.1
• release/v1.4.1-1
• release/v1.4.1-2
• release/v1.4.1-2-deployment
• release/v1.4.1-3
• release/v1.5.0
• remove-payable
• remove-unused-test-contracts
• remove-vscode-junm
• revert-1026-main
• revert-973-ackee/w1
• safe-proxy-event
• safeToL2Migration-zksync
• sig-malleability-comments
• signing-constants
• storage-constants
• storage-constants-v2
• temp/1.5.0-build
• test-workflow
• typo
• typo-pass-1
• typos
• update-compatibility-documentation
• updating-dependencies
• using-returndatasize
• v1.4.1-2
• v1.4.1-2-audit
• v1.4.1-3
• v1.4.1-audit-and-address
• v1.4.1-audit-changes
• v1.4.1/singleton-factory-update
• v1.4.1/zksync-compat
• v1.5-addresses
• v1.5-audit-report
• v1.5.0
• v1.5.0-audit
• v1.5.0-base
• v1.5.0-zksync
• v1_3_0_zksync
• workflow-updated
• zksync-error-update
• zksync-failing-test
• zksync-node-bump

Build # 15269377376

Build Type

Pull #965

github

Committed by nlordell

Commit Message

Ackee[W6]: Document `TokenCallbackHandler` Locks Tokens

A byproduct of the `TokenCallbackHandler` implementing token callback
functions is that it is able to receive tokens (such as ERC-721)
despite not being designed to do so. Tokens sent to this contract will
be permanently locked: SO DO NOT SEND TOKENS TO THIS CONTRACT!

This PR adds a documentation blurb to the contract in question to
document this shortcomming. Unfortunately, this is not something that
can be reasonably checked for such that the handlers `revert`.

Pull Request Pull Request #965: Ackee[W6]: Prevent `TokenCallbackHandler` from Locking Tokens

Run Details

329 of 370 branches covered (88.92%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 2 files covered. (100.0%)

495 of 507 relevant lines covered (97.63%)

102.38 hits per line