safe-global / safe-modules
100%
master: 85%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Repo Added
Files 12
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refs/tags/passkey/v0.2.1-1
branch: refs/tags/passkey/v0.2.1-1
CHANGE BRANCH
x

coverage: 100.0%. Remained the same
10473249029

push

github

web-flow 
Fix Passkey Verification (#486)

In deploying the Passkey v0.2.1 contracts, I noticed that the local
verification script wasn't working as well as Etherscan verification of
the FCL verifier contract. This PR fixes both of these things and is
related to a few issues:

1. The `solc` package version was not correctly specified for each
`localVerify` script. It was pulling in a `solc` version based on
transient dependencies which doesn't necessarily match what the
contracts are compiled with (and thus affects local verification). This
was an issue shared by all Solidity packages.
2. Local verification was not correctly building the Solidity compiler
input JSON. It turns out that the way we build compiler input would
sometimes only pass in the Keccak-256 hash of the source instead of the
actual Solidity source - so we add an additional condition in the task
to read the source from disk if necessary (this is a `hardhat-deploy`
inconsistency).
3. The `etherscan-verify` task from the `hardhat-deploy` package does
not work for contracts with Solidity compiler settings overrides such as
the FCL P-256 verifier contract (which has different compiler settings
from the rest of the contracts). We have a special manual
`hardhat-verify` plugin call in the `deploy-all` task to work around the
issue.

28 of 28 branches covered (100.0%)

Branch coverage included in aggregate %.

92 of 92 relevant lines covered (100.0%)

30.29 hits per line

Relevant lines Covered
92 RELEVANT LINES 92 COVERED LINES
30.29 HITS PER LINE
Source Files on refs/tags/passkey/v0.2.1-1

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
10473249029 refs/tags/passkey/v0.2.1-1 Fix Passkey Verification (#486) In deploying the Passkey v0.2.1 contracts, I noticed that the local verification script wasn't working as well as Etherscan verification of the FCL verifier contract. This PR fixes both of these things and is re... push web-flow github
100.0
10473249032 refs/tags/passkey/v0.2.1-1 Fix Passkey Verification (#486) In deploying the Passkey v0.2.1 contracts, I noticed that the local verification script wasn't working as well as Etherscan verification of the FCL verifier contract. This PR fixes both of these things and is re... push web-flow github
100.0
See All Builds (1603)