safe-global / safe-client-gateway
90%
main: 90%

LAST BUILD BRANCH: fix/relay-fee-relayer-safetxhash
DEFAULT BRANCH: main
Repo Added
Files 1191
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v1.110.0
branch: v1.110.0
CHANGE BRANCH
x

coverage: 89.722% (+0.03%) from 89.695%
26231860036

push

github

web-flow 
refactor(members): lift admin check from MembersRepository to MembersService (#3095)

* refactor(members): extract findActiveAdmin on MembersRepository

Pull the inline active-admin lookup inside inviteUsers into a public
method on MembersRepository. Pure refactor — inviteUsers still throws
on non-admin caller and behavior is unchanged.

Preparation for lifting the admin check out of the repository and into
MembersService in subsequent commits.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor(members): move admin check from MembersRepository to MembersService

Lift the active-admin gate from MembersRepository.inviteUsers into the
application layer. The repository is no longer responsible for the
authentication assertion either — both checks now run at the service
entry point.

- MembersService.inviteUser calls getAuthenticatedUserIdOrFail and
  findActiveAdmin, throwing ForbiddenException when no active admin
  membership is found.
- A TODO on inviteUsers signals the next cleanup step: drop authPayload
  and accept invitedBy as a parameter.

Test-suite updates that mirror this move follow in subsequent commits.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor(members): extract assertActiveAdmin helper on MembersService

Pull the authenticated-user + active-admin check out of inviteUser
into a small private assertActiveAdmin helper, so subsequent route
methods on MembersService that need the same gate can call it
directly. No behavior change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(members): move not-authenticated case to MembersService spec

Same coverage, new home: the unauthenticated rejection now lives on
the service spec, since the auth assertion moved up with the admin
guard in the preceding prod commits.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(members): move not-an-admin case to MembersService + findActive... (continued)

4221 of 5078 branches covered (83.12%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

16119 of 17592 relevant lines covered (91.63%)

605.54 hits per line

Relevant lines Covered
17592 RELEVANT LINES 16119 COVERED LINES
605.54 HITS PER LINE
Source Files on v1.110.0

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26231860036 v1.110.0 refactor(members): lift admin check from MembersRepository to MembersService (#3095) * refactor(members): extract findActiveAdmin on MembersRepository Pull the inline active-admin lookup inside inviteUsers into a public method on MembersReposito... push web-flow github
89.72
26231858106 v1.110.0 refactor(members): lift admin check from MembersRepository to MembersService (#3095) * refactor(members): extract findActiveAdmin on MembersRepository Pull the inline active-admin lookup inside inviteUsers into a public method on MembersReposito... push web-flow github
89.73
See All Builds (9864)