rzane / baby_squeel

99%

master: 86%

LAST BUILD ON BRANCH handle-null-relation-for-attribute-in

branch: handle-null-relation-for-attribute-in

CHANGE BRANCH

x

Reset

• handle-null-relation-for-attribute-in
• 52-support
• activerecord-5
• ar-521
• arel-star
• avoid-nasty-aliases
• better-coverage
• better-error-messages
• binary-as
• bind-parameters
• calculations
• compare-parent-reflections
• deprecate-41
• extract-join
• fix-61
• fix-dumb-error
• fix-pluck-deprecation
• function-math
• grouping
• helpers
• issue-37
• join-aliasing
• join-wip
• joining-bug
• keypath-methods
• master
• master-with-updates
• math-bugfix
• more-selective-decoration
• not-in
• outer-join-fixes
• plucking
• polyamorous
• polymorphic-joins
• polymorphic-joins-2
• port-more-compat
• query-assoc-eq-neq
• resolver
• select-exists
• sifting
• simpler-where
• snapshot-testing
• squeel-compat
• table-alias-on
• tables-without-models
• use-aliases-on-where
• v0.1.0
• v0.2.0
• v0.2.1
• v0.2.2
• v0.3.0
• v0.3.1
• v1.0.0
• v1.0.1
• v1.0.2
• v1.0.3
• v1.1.0
• v1.1.1
• v1.1.2
• v1.1.3
• v1.1.4
• v1.1.5
• v1.2.0
• v1.2.1
• v1.3.0
• v1.3.1
• where-should-accept-nil
• workaround-alias-tracker

NullRelation#to_sql returns an empty string, which results in the
following invalid SQL when using Attribute#in:

   WHERE "id" IN ()

ActiveRecord handles scenarios like this by appending 1=0 to the
subquery to ensure that no results are returned. So, if we just convert
the NullRelation back to a relation, we're all good.