rustymotors / server

44%

Build Type

push

github

Committed by web-flow

Commit Message

Port parts catalog + part-mgmt MCOTS handlers from Recons (#2832)

## Summary

Brings two pieces of legacy MCO functionality into the main server, both
of which were previously implemented only in Recons
(\`tools/mco-revival.mjs\`) and were missing from \`dev\`:

1. **Parts catalog HTTP endpoint** at \`GET /mco/local/58\` — the legacy
client fetches parts metadata from this URL during gameplay. Without it,
parts pickers are empty.
2. **Four MCOTS opcodes** the client sends for part management —
previously hitting \`UNSUPPORTED_MESSAGECODE\`:
   - 177 \`MC_REPAIR_SINGLE_PART\`
   - 178 \`MC_REPAIR_MULTIPLE_PARTS\`
   - 182 \`MC_REMOVE_PART\`
   - 214 \`MC_DESTROY_PART\`

### Designed for swap-in DB later

The catalog ships behind a \`PartsCatalog\` interface with a
\`TsvPartsCatalog\` implementation reading
\`packages/database/seed/parts-catalog.tsv\` (3236 rows, copied from
Recons). The factory selects an implementation via
\`MCO_PARTS_CATALOG_SOURCE=tsv|db\` env var (default \`tsv\`); the
\`db\` branch is a stub-throw with a \`TODO(parts-catalog-db)\` marker —
when ready, drop in a \`DbPartsCatalog\` class that reads from
\`BrandedPart\` / \`AbstractPartType\` / \`PartGrade\` and add one
\`case "db":\` line. Handlers and the HTTP route never need to change.

### Stub-only handlers

All four MCOTS handlers parse the partId from the \`GenericRequest\`
payload, log a structured event, and ack with \`MC_SUCCESS\`
(DESTROY_PART returns no reply, matching the legacy "who cares" comment
and Recons's behavior). Every deferred concern is tagged with
\`TODO(parts-mgmt)\` or \`TODO(parts-mgmt-economy)\` markers —
including:

- ownership validation
- subtree handling for remove/destroy (yanking a chassis takes its
suspension and brakes with it)
- per-persona DB-backed bank balance (Recons uses a single global
in-memory \`localBankBalance\`, which doesn't translate to multi-user)
- partial-success replies for repair-multiple
- chassis-root guard

The economy work... (continued)

Coverage Stats

691 of 1771 branches covered (39.02%)

Branch coverage included in aggregate %.

48 of 101 new or added lines in 7 files covered. (47.52%)

3 existing lines in 2 files now uncovered.

4221 of 9317 relevant lines covered (45.3%)

130.25 hits per line