rond-authz / rond

86%

main: 87%

LAST BUILD ON BRANCH test/added-get-headers-builtin-tests

branch: test/added-get-headers-builtin-tests

CHANGE BRANCH

x

Reset

Sync Branches

• test/added-get-headers-builtin-tests
• RJC-242-grant-revoke-permission-with-optional-resource
• add-openapi-documentation
• automated-release
• chore/mod-tidy
• ci/coveralls-parallelism
• ci/docker-push-mia-registry
• ci/go122-benchmark
• ci/ignore-testutil-files-from-cover
• ci/make-test-no-cache
• ci/multiple-go-versions
• ci/new-job-names
• ci/test-latest-with-latest-go
• dependabot/docker/golang-1.19.2
• dependabot/docker/golang-1.19.3
• dependabot/docker/golang-1.19.4
• dependabot/docker/golang-1.19.5
• dependabot/docker/golang-1.20.0
• dependabot/docker/golang-1.20.1
• dependabot/docker/golang-1.20.2
• dependabot/docker/golang-1.20.3
• dependabot/docker/golang-1.20.4
• dependabot/docker/golang-1.20.5
• dependabot/docker/golang-1.20.6
• dependabot/docker/golang-1.20.7
• dependabot/docker/golang-1.21.0
• dependabot/docker/golang-1.21.1
• dependabot/docker/golang-1.21.2
• dependabot/docker/golang-1.21.3
• dependabot/docker/golang-1.21.4
• dependabot/docker/golang-1.21.5
• dependabot/docker/golang-1.21.6
• dependabot/docker/golang-1.22.0
• dependabot/docker/golang-1.22.1
• dependabot/docker/golang-1.22.2
• dependabot/docker/golang-1.22.3
• dependabot/docker/golang-1.22.4
• dependabot/docker/golang-1.22.5
• dependabot/docker/golang-1.22.6
• dependabot/docker/golang-1.23.0
• dependabot/docker/golang-1.23.1
• dependabot/docker/golang-1.23.2
• dependabot/docker/golang-1.23rc1
• dependabot/docker/library/golang-0caf875
• dependabot/docker/library/golang-1.23.3
• dependabot/docker/library/golang-1.23.4
• dependabot/docker/library/golang-1.23.5
• dependabot/docker/library/golang-1.23.6
• dependabot/docker/library/golang-1.24.0
• dependabot/docker/library/golang-1.24.1
• dependabot/docker/library/golang-1.24.2
• dependabot/docker/library/golang-1.24.3
• dependabot/docker/library/golang-1.24.4
• dependabot/docker/library/golang-1.24.5
• dependabot/docker/library/golang-1.24rc2
• dependabot/docker/library/golang-1.25.1
• dependabot/docker/library/golang-1ecc479
• dependabot/docker/library/golang-1fd7d46
• dependabot/docker/library/golang-267159c
• dependabot/docker/library/golang-3178db8
• dependabot/docker/library/golang-3b1a7de
• dependabot/docker/library/golang-5255fad
• dependabot/docker/library/golang-574185e
• dependabot/docker/library/golang-7003184
• dependabot/docker/library/golang-73f06be
• dependabot/docker/library/golang-7ea4c9d
• dependabot/docker/library/golang-8305f5f
• dependabot/docker/library/golang-86b4cff
• dependabot/docker/library/golang-8956c08
• dependabot/docker/library/golang-8c10f21
• dependabot/docker/library/golang-9820aca
• dependabot/docker/library/golang-ab1f5c4
• dependabot/docker/library/golang-ad5c126
• dependabot/docker/library/golang-bb979b2
• dependabot/docker/library/golang-c2d828f
• dependabot/docker/library/golang-cc637ce
• dependabot/docker/library/golang-cd0c949
• dependabot/docker/library/golang-cf5209f
• dependabot/docker/library/golang-d1db785
• dependabot/docker/library/golang-fffeec5
• dependabot/docker/library/golang-sha256d9db32125db0c3a680cfb7a1afcaefb89c898a075ec148fdc2f0f646cc2ed509
• dependabot/github_actions/actions/cache-4
• dependabot/github_actions/actions/checkout-3
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/actions/checkout-5.0.0
• dependabot/github_actions/actions/setup-go-4
• dependabot/github_actions/actions/setup-go-5
• dependabot/github_actions/actions/setup-go-6.0.0
• dependabot/github_actions/docker/build-push-action-4
• dependabot/github_actions/docker/build-push-action-5
• dependabot/github_actions/docker/build-push-action-6
• dependabot/github_actions/docker/login-action-3
• dependabot/github_actions/docker/metadata-action-5
• dependabot/github_actions/docker/setup-buildx-action-3
• dependabot/github_actions/docker/setup-qemu-action-3
• dependabot/github_actions/github/codeql-action-3
• dependabot/github_actions/minor-actions-dependencies-10bed7a685
• dependabot/github_actions/minor-actions-dependencies-14559d16b5
• dependabot/github_actions/minor-actions-dependencies-1f8d2d4b8f
• dependabot/github_actions/minor-actions-dependencies-64b03f35d5
• dependabot/github_actions/minor-actions-dependencies-6804b26fe2
• dependabot/github_actions/minor-actions-dependencies-6d79f1e017
• dependabot/github_actions/minor-actions-dependencies-84309ffe88
• dependabot/github_actions/minor-actions-dependencies-865b20de3a
• dependabot/github_actions/minor-actions-dependencies-8dc50fc076
• dependabot/github_actions/minor-actions-dependencies-8e95eef7cb
• dependabot/github_actions/minor-actions-dependencies-b9d89d074e
• dependabot/github_actions/minor-actions-dependencies-e4a9feea18
• dependabot/github_actions/softprops/action-gh-release-2
• dependabot/go_modules/github.com/davidebianchi/go-jsonclient-1.5.0
• dependabot/go_modules/github.com/davidebianchi/gswagger-0.10.0
• dependabot/go_modules/github.com/davidebianchi/gswagger-0.6.0
• dependabot/go_modules/github.com/davidebianchi/gswagger-0.6.1
• dependabot/go_modules/github.com/davidebianchi/gswagger-0.7.0
• dependabot/go_modules/github.com/davidebianchi/gswagger-0.8.0
• dependabot/go_modules/github.com/davidebianchi/gswagger-0.9.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.100.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.101.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.102.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.103.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.104.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.105.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.106.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.107.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.108.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.109.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.110.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.111.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.112.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.113.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.114.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.115.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.116.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.117.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.118.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.119.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.120.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.121.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.124.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.125.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.126.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.127.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.131.0
• dependabot/go_modules/github.com/getkin/kin-openapi-0.99.0
• dependabot/go_modules/github.com/google/uuid-1.3.1
• dependabot/go_modules/github.com/google/uuid-1.4.0
• dependabot/go_modules/github.com/google/uuid-1.5.0
• dependabot/go_modules/github.com/google/uuid-1.6.0
• dependabot/go_modules/github.com/gorilla/mux-1.8.1
• dependabot/go_modules/github.com/mia-platform/glogger/v4-4.1.0
• dependabot/go_modules/github.com/mia-platform/go-crud-service-client-0.11.0
• dependabot/go_modules/github.com/mia-platform/go-crud-service-client-0.12.0
• dependabot/go_modules/github.com/mia-platform/go-crud-service-client-0.13.0
• dependabot/go_modules/github.com/mia-platform/go-crud-service-client-0.14.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.41.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.42.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.42.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.42.2
• dependabot/go_modules/github.com/open-policy-agent/opa-0.43.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.44.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.45.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.46.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.47.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.47.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.47.2
• dependabot/go_modules/github.com/open-policy-agent/opa-0.47.3
• dependabot/go_modules/github.com/open-policy-agent/opa-0.47.4
• dependabot/go_modules/github.com/open-policy-agent/opa-0.48.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.49.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.49.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.49.2
• dependabot/go_modules/github.com/open-policy-agent/opa-0.50.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.50.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.50.2
• dependabot/go_modules/github.com/open-policy-agent/opa-0.51.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.52.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.53.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.53.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.54.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.55.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.56.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.57.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.57.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.58.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.59.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.60.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.61.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.62.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.62.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.63.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.64.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.64.1
• dependabot/go_modules/github.com/open-policy-agent/opa-0.65.0
• dependabot/go_modules/github.com/open-policy-agent/opa-0.69.0
• dependabot/go_modules/github.com/open-policy-agent/opa-1.4.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.15.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.15.1
• dependabot/go_modules/github.com/prometheus/client_golang-1.16.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.17.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.18.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.19.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.19.1
• dependabot/go_modules/github.com/prometheus/client_golang-1.20.5
• dependabot/go_modules/github.com/prometheus/common-0.44.0
• dependabot/go_modules/github.com/samber/lo-1.27.0
• dependabot/go_modules/github.com/samber/lo-1.27.1
• dependabot/go_modules/github.com/samber/lo-1.28.0
• dependabot/go_modules/github.com/samber/lo-1.28.2
• dependabot/go_modules/github.com/samber/lo-1.30.0
• dependabot/go_modules/github.com/samber/lo-1.31.0
• dependabot/go_modules/github.com/samber/lo-1.32.0
• dependabot/go_modules/github.com/samber/lo-1.33.0
• dependabot/go_modules/github.com/samber/lo-1.34.0
• dependabot/go_modules/github.com/samber/lo-1.35.0
• dependabot/go_modules/github.com/samber/lo-1.36.0
• dependabot/go_modules/github.com/samber/lo-1.37.0
• dependabot/go_modules/github.com/samber/lo-1.38.1
• dependabot/go_modules/github.com/samber/lo-1.39.0
• dependabot/go_modules/github.com/samber/lo-1.42.0
• dependabot/go_modules/github.com/sirupsen/logrus-1.9.0
• dependabot/go_modules/github.com/sirupsen/logrus-1.9.1
• dependabot/go_modules/github.com/sirupsen/logrus-1.9.2
• dependabot/go_modules/github.com/sirupsen/logrus-1.9.3
• dependabot/go_modules/github.com/stretchr/testify-1.7.2
• dependabot/go_modules/github.com/stretchr/testify-1.7.4
• dependabot/go_modules/github.com/stretchr/testify-1.7.5
• dependabot/go_modules/github.com/stretchr/testify-1.8.0
• dependabot/go_modules/github.com/stretchr/testify-1.8.1
• dependabot/go_modules/github.com/stretchr/testify-1.8.2
• dependabot/go_modules/github.com/stretchr/testify-1.8.3
• dependabot/go_modules/github.com/stretchr/testify-1.8.4
• dependabot/go_modules/github.com/stretchr/testify-1.9.0
• dependabot/go_modules/github.com/uptrace/bunrouter-1.0.18
• dependabot/go_modules/github.com/uptrace/bunrouter-1.0.19
• dependabot/go_modules/github.com/uptrace/bunrouter-1.0.20
• dependabot/go_modules/github.com/uptrace/bunrouter-1.0.21
• dependabot/go_modules/github.com/uptrace/bunrouter-1.0.22
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.10.0
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.10.1
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.10.2
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.10.3
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.10.4
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.11.0
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.11.1
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.11.2
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.11.3
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.11.4
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.11.5
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.11.6
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.11.7
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.12.0
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.12.1
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.13.0
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.13.1
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.14.0
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.15.0
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.15.1
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.16.0
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.16.1
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.17.0
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.17.1
• dependabot/go_modules/golang.org/x/crypto-0.17.0
• dependabot/go_modules/golang.org/x/crypto-0.31.0
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• dependabot/go_modules/google.golang.org/protobuf-1.33.0
• dependabot/go_modules/gotest.tools/v3-3.3.0
• dependabot/go_modules/gotest.tools/v3-3.4.0
• deps/glogger
• docs/readme
• edit/introduce-lo
• edit/status-routes
• feat/#273-preventBodyLoad-in-request
• feat/207-user-id-in-policies
• feat/268-better-status-routes
• feat/51
• feat/add-evaluation-info-logs
• feat/add-trace-log
• feat/audit-trail-in-stdout-logs
• feat/benchmark-action
• feat/compiler
• feat/dependency-review
• feat/doc-improvement
• feat/explore-paranoia
• feat/export-metrics
• feat/filter-unwanted-trace
• feat/head-method-proxy
• feat/ignore-trailing-slash-support
• feat/include-binding-resource-type-audit-data
• feat/issue-247
• feat/logger
• feat/maxIdleTimeMs
• feat/migrate-crud-client
• feat/migrate-envs-lib
• feat/multi-os-tests
• feat/new-bucket-values
• feat/new-pipelines
• feat/prepared-partial
• feat/retrieve-bindings-roles-function
• feat/revoke-binding-by-resource-type-and-id
• feat/rjc-460-fix-bindings
• feat/role-name-in-types
• feat/save-audit-timestamp
• feat/sdk
• feat/sdk-evaluate-request
• feat/sdk-from-config
• feat/sdk-package
• feat/sdk-prometheus
• feat/store-audits-on-mongodb
• feat/support-in-operator-in-query
• feat/support-metadata-input
• feat/who-is-using-rond
• fix-content-type-response-error
• fix-test-main
• fix/all-method-spreaded
• fix/allowed-log-in-response-policy
• fix/bench
• fix/change-metadata
• fix/code-scanning-alert
• fix/concurrent-audit-cache-write
• fix/conflicting-policy-configuration
• fix/cosign-pipeline-step
• fix/deprecation-and-warning-cleaning
• fix/deps-configlib
• fix/expose-metrics-endpoint
• fix/failing-test
• fix/glogrus
• fix/go-mod-ambiguous-imports
• fix/go-sec
• fix/grant-api-permissions
• fix/ignore-trailing-slash-bug-with-ALL-method
• fix/issue-161
• fix/issue-368
• fix/log-with-inherited-field
• fix/optimize-mongo-connection
• fix/optional-audit-configuration-file
• fix/policy-name-in-logs
• fix/prevent-exposing-interface-with-internal-package
• fix/provide-security-query-filter-on-custom-header
• fix/restore-guard-against-panic
• fix/router-properly-initlized-based-on-verbs
• fix/sec-warning
• fix/send-empty-filter
• fix/specify-method
• fix/typo-in-md-files
• fix/update-audit-labels-on-subsequent-store-calls
• fredmaggiowski-patch-1
• gh-readonly-queue/main/pr-151-9e7b6f6d989a84965969c3fe6b9506a94bb225f3
• gh-readonly-queue/main/pr-152-59ab505b470e895d14e65758697cbd1e3d6147b4
• gh-readonly-queue/main/pr-153-1672f525e2d6ca9ce6b4999a8d0c198d4ed4a5f6
• gh-readonly-queue/main/pr-154-06e0cd112f500fba45e967ecc1096c56750710b4
• gh-readonly-queue/main/pr-156-2d990faa135d9228cad718f54314f3bbd635157f
• gh-readonly-queue/main/pr-157-a5431f94d3506ff46564c33762656496985185af
• gh-readonly-queue/main/pr-158-10becc42ee4c4c29c9c52da25bdc03b8d17c9d94
• gh-readonly-queue/main/pr-160-e3ff073e973eed977bee508164e3b8d5f5b52453
• gh-readonly-queue/main/pr-162-2a3822814172c3974344d4548a37abf842194724
• gh-readonly-queue/main/pr-164-540a664dc11bdd20f436c1b8315e776167734701
• gh-readonly-queue/main/pr-165-2c01591970f493ed2f34c4ac4877babecd089896
• gh-readonly-queue/main/pr-166-cc9f0d286425e4a44920479c15b3280c3537b767
• gh-readonly-queue/main/pr-167-5a8d08b151323121a4229890b0df1b043ae9f7f3
• gh-readonly-queue/main/pr-168-d39082f2920498798fdde676667022d011faff2a
• gh-readonly-queue/main/pr-169-915415919d1ba3e72765649a46c86e441388f6ad
• gh-readonly-queue/main/pr-170-0eaa30f0baa67d57d6b94f6827f14673a79558be
• gh-readonly-queue/main/pr-172-dac20dcb8e3fe48b33ce4d0085aefe9b8b971239
• gh-readonly-queue/main/pr-173-5f45706cde437c78f37ef69f354cb41df59436e5
• gh-readonly-queue/main/pr-174-c73bd0db883bff5a0efd13fa94744289a6c48531
• gh-readonly-queue/main/pr-175-fa044ae435946f79256910b8d6ca4c01c500fbd8
• gh-readonly-queue/main/pr-176-ddf23d7487af38071d516989712ffe5c4c831ac3
• gh-readonly-queue/main/pr-177-42442fef31b2070f5cf192d66dba2afb8b49c94e
• gh-readonly-queue/main/pr-178-6115bd5cec6c48ac35d442548501008247e829ff
• main
• patch-1
• poc/operator
• refactor-remove-gotest
• refactor/core-error-messages
• refactor/core-without-env
• refactor/improved-setup-logs
• refactor/in-operator-order-in-tests
• refactor/main-tests
• refactor/make-rond-usable-as-lib
• refactor/test-mongodb-host-gen
• refactor/use-new-reverse-proxy
• refs/tags/v1.10.0
• refs/tags/v1.10.1
• refs/tags/v1.11.0
• refs/tags/v1.11.1
• refs/tags/v1.12.0
• refs/tags/v1.12.1
• refs/tags/v1.12.2
• refs/tags/v1.12.3
• refs/tags/v1.12.4
• refs/tags/v1.12.5
• refs/tags/v1.12.6
• refs/tags/v1.2.1
• refs/tags/v1.2.2
• refs/tags/v1.3.0
• refs/tags/v1.3.1
• refs/tags/v1.3.2
• refs/tags/v1.4.0
• refs/tags/v1.4.1
• refs/tags/v1.4.2
• refs/tags/v1.4.3
• refs/tags/v1.5.0
• refs/tags/v1.5.1
• refs/tags/v1.5.2
• refs/tags/v1.5.3
• refs/tags/v1.6.0
• refs/tags/v1.6.1
• refs/tags/v1.6.2
• refs/tags/v1.6.3
• refs/tags/v1.6.4
• refs/tags/v1.7.0
• refs/tags/v1.8.0
• refs/tags/v1.9.0
• sec/fix-errors-mngmt
• sec/sanitize-query-input
• test/empty-userproperties-header
• test/filter-query-with-nested-prop
• test/improve-coverage
• test/integration-test-with-request-load
• test/mongodb-utilities-test-refactor
• test/t.Setenv
• update-issue-template
• update/actions
• update/readme
• update/varius-deps
• v1.12.7
• v1.12.8
• v1.12.9
• v1.13.0
• v1.14.0
• v1.14.1

Build # 12985480262

Build Type

Pull #434

github

Committed by fredmaggiowski

Commit Message

refactor: comments+indent

Pull Request Pull Request #434: test: added get headers builtin tests

Run Details

10 of 10 new or added lines in 1 file covered. (100.0%)

2623 of 3051 relevant lines covered (85.97%)

21.34 hits per line