rollandf / network-operator

62%

master: 62%

LAST BUILD ON BRANCH upgrade-ofed

branch: upgrade-ofed

CHANGE BRANCH

x

Reset

Sync Branches

• upgrade-ofed
• 25.01-0.2.2.0
• 25.04-0.1.7.0
• 25.04-0.2.9.0-0
• 25.04-0.5.1.0-1
• 25.04-0.5.5.0-0
• 25.04-0.5.5.0-1
• 25.04-0.6.0.0-1
• 25.04-0.6.1.0-2
• 25.04-0.6.1.0-2-bp
• 25.07-0.3.1.0-0
• 25.07-0.9.7.0
• 25.10-0.8.1.0-0
• 26.04-0.3.5.0
• CVE-2024-41110
• CVE-24.10
• alignrc1
• alm-sha
• backport-nic-op-aff
• backport-spectrumx-ports
• backportca
• baseimage26.1
• bbundlega
• beta5
• bumps
• bundle-24.10.01
• bundle-24.10.1
• bundle-24.7.1
• bundle-fix
• bundle-ga
• chart-update
• cherry-pick-pr-checker
• ci-branch
• ci-branch-backport
• ci-build
• ci-check
• ci-release
• clean-branches
• cleanup-nodeattributes
• cm-nic-ofed
• container-registry
• containerd
• crd-api-ctnd
• create-release-branch
• cve-distroless
• cve-docker
• cvexnet
• deploymentTolerations
• deprecated
• deprecated-bp
• device-plugin-3-8
• disableblackduck
• doc-api-update
• doc-ci-timeout
• doc-ci-wait-for-image
• doc-ofed-backport
• doca-25-01
• doca-25.01-0.5.3.0
• doca-25.04-0.0.6.0-0
• doca-25.10-0.3.4.0
• doca-ga
• doca-ga-backport
• doca-ofed
• doca26.1
• doca3.1.0-25.07-0.7.5.0-1
• doca3.4.0-26.04-0.5.3.0-0
• doca3.4.0-26.04-0.6.1.0-0
• docaofed-validation
• docaupdate
• docker125
• dockerarch
• dockerbuild
• dockerbundle
• docs-ci
• dra
• dradriver
• dts
• dts-3.4
• dts-3.4-bp
• dts-link
• dts-ocp
• dts-url-bp
• dtsupdate
• fail-release
• fips-nic-conf
• fix-branch
• fix-build
• fix-build2
• fix-build3
• fix-build4
• fix-bundle-error
• fix-nic-fw-version
• force-precompiled
• full-ncp-cr
• ga-master
• go1-24
• go1.25
• go12411
• gonet
• hack-docs-version
• helm-ga
• helm-ga-ci
• helm-push
• helm-values-doc-format
• helm-values-doc-format-master
• ib-k8s-rbac
• ib-kubernetes
• ibkubernetessecret
• init-container
• init-container-ofed
• ipam-node
• ipam-v0.3.7
• ipoib
• keep-ncp
• launchkit
• master
• memory
• migrate
• mo-name
• mo-system-critical
• multus-config
• nfd
• nfd-update
• ngc-ga-cont
• nic-conf-helm
• nic-feature
• nic-if-template
• nic-op-aff
• nic-role
• no-primary-cni
• nv-ipam
• nvipam-pernode
• ocp-bundle
• ocp-bundle-pr
• ocp-cr-back
• ocp-full-ncp
• ocp-versions
• ocp4.18
• ocp417
• ocpbundle
• ofed-registry-ga
• ofed-remove
• ofed-sha
• ofed-validation
• ofed-wait-fix
• ofed25.01-0.3.9.0
• ofed25070960
• ofedverinfolog
• patch-release
• pr-checker
• probetest
• rbac-proxy
• rc-doca
• rdma-cni
• rdma-shared
• related-images
• related-no-image
• release-branch
• release-values
• remove-nic-op-helm
• remove-vars-doc
• retry
• rh-pr-remove
• role-check
• role-pool
• role-spcx
• sha-init
• short-sha-12
• shortname
• sles
• sos-perm
• sparse
• spectrumx-crd
• spectrumx-ports
• spectrumx-related
• spectrumx-release
• spectrumx3.0
• specx-cm
• specx-role
• sriov-no-ga
• sriov-nvstaging
• sriov-rc1
• sriovcrd
• sriovdp-3.9
• stable
• startupprobe
• sync-25.10
• tag-force
• template-patch
• test-ci
• test-doc
• test-doca-validation
• tolerationds
• update-base
• update-docs-ver-comment
• update-maintenance-op
• update-mo
• update-spx
• updatecrdnicconf
• upgrade-nv-ipam
• v24.10.1-rc1
• v24.10.x
• values
• values-ctnd
• verify-doca-driver
• version-releaseyaml
• version-validation
• whereabout-crd-bp
• whereaboutcrd
• yet-another-try

Build # 25002584503

Build Type

push

github

Committed by rollandf

Commit Message

fix: backfill ds-owner label on OFED pods when upgrading from GA releases

When upgrading from a GA release (e.g. v26.1) to v26.4+, existing MOFED
pods lack the ds-owner label that was added to the pod template in v26.4.
Because the DaemonSet uses OnDelete update strategy, these pods are never
recreated automatically and retain their original label set.

The upgrade controller calls BuildState with both nvidia.com/ofed-driver
and ds-owner label selectors. With no pods matching the combined selector,
BuildState errors with "driver DaemonSet should not have Unscheduled pods"
on every reconcile, preventing ApplyState from ever running and causing
the upgrade to stall indefinitely.

Add handleMissingDSOwnerLabelOnPods to the migration path. It runs at
operator startup before any controller is unblocked (MigrationCh gate),
finds OFED pods that lack ds-owner, and patches them with the correct
NicClusterPolicy CRD name. This is a no-op on v26.4+ upgrades where all
pods already carry the label.

Signed-off-by: Fred Rolland <frolland@nvidia.com>

Coverage Stats

25 of 35 new or added lines in 1 file covered. (71.43%)

95 existing lines in 9 files now uncovered.

4858 of 7844 relevant lines covered (61.93%)

46.24 hits per line