rm-hull / dot-block

42%

main: 47%

LAST BUILD ON BRANCH fix/data-races

branch: fix/data-races

CHANGE BRANCH

x

Reset

Sync Branches

• fix/data-races
• chore/correct-package-name
• chore/slog
• chore/update-deps
• chore/update-go-deps
• dependabot/docker/golang-1.26-alpine
• dependabot/github_actions/actions/cache-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/upload-artifact-6
• dependabot/github_actions/docker/build-push-action-7
• dependabot/github_actions/docker/login-action-4
• dependabot/github_actions/docker/metadata-action-6
• dependabot/github_actions/docker/setup-buildx-action-4
• dependabot/github_actions/golangci/golangci-lint-action-9
• dependabot/github_actions/mikepenz/action-junit-report-6
• dependabot/go_modules/github.com/Depado/ginprom-1.8.3
• dependabot/go_modules/github.com/axiomhq/hyperloglog-0.2.6
• dependabot/go_modules/github.com/caddyserver/certmagic-0.25.2
• dependabot/go_modules/github.com/caddyserver/certmagic-0.25.3
• dependabot/go_modules/github.com/getsentry/sentry-go-0.37.0
• dependabot/go_modules/github.com/getsentry/sentry-go-0.38.0
• dependabot/go_modules/github.com/getsentry/sentry-go-0.39.0
• dependabot/go_modules/github.com/getsentry/sentry-go-0.40.0
• dependabot/go_modules/github.com/getsentry/sentry-go-0.41.0
• dependabot/go_modules/github.com/getsentry/sentry-go-0.42.0
• dependabot/go_modules/github.com/getsentry/sentry-go-0.44.1
• dependabot/go_modules/github.com/getsentry/sentry-go-0.45.0
• dependabot/go_modules/github.com/getsentry/sentry-go-0.45.1
• dependabot/go_modules/github.com/getsentry/sentry-go-0.46.0
• dependabot/go_modules/github.com/getsentry/sentry-go-0.46.1
• dependabot/go_modules/github.com/getsentry/sentry-go-0.46.2
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.37.0
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.38.0
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.39.0
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.40.0
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.41.0
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.42.0
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.44.1
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.45.0
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.45.1
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.46.1
• dependabot/go_modules/github.com/getsentry/sentry-go/gin-0.46.2
• dependabot/go_modules/github.com/gin-contrib/pprof-1.5.4
• dependabot/go_modules/github.com/gin-gonic/gin-1.12.0
• dependabot/go_modules/github.com/miekg/dns-1.1.69
• dependabot/go_modules/github.com/miekg/dns-1.1.72
• dependabot/go_modules/github.com/rm-hull/godx-0.0.10
• dependabot/go_modules/github.com/rm-hull/godx-0.0.7
• dependabot/go_modules/github.com/rm-hull/godx-0.0.8
• dependabot/go_modules/github.com/rm-hull/godx-0.2.1
• dependabot/go_modules/github.com/rm-hull/godx-0.2.2
• dependabot/go_modules/github.com/samber/slog-gin-1.19.1
• dependabot/go_modules/github.com/samber/slog-gin-1.20.0
• dependabot/go_modules/github.com/samber/slog-gin-1.20.1
• dependabot/go_modules/github.com/samber/slog-gin-1.21.0
• dependabot/go_modules/github.com/samber/slog-gin-1.21.1
• dependabot/go_modules/github.com/spf13/cobra-1.10.2
• dependabot/go_modules/github.com/tavsec/gin-healthcheck-1.7.12
• dependabot/go_modules/github.com/tavsec/gin-healthcheck-1.7.13
• dependabot/go_modules/github.com/tavsec/gin-healthcheck-1.7.14
• dependabot/go_modules/github.com/tavsec/gin-healthcheck-1.7.15
• dependabot/go_modules/go.uber.org/zap-1.28.0
• dependabot/go_modules/golang.org/x/crypto-0.44.0
• dependabot/go_modules/golang.org/x/crypto-0.45.0
• dependabot/go_modules/golang.org/x/crypto-0.46.0
• dependabot/go_modules/golang.org/x/net-0.47.0
• dependabot/go_modules/golang.org/x/net-0.48.0
• dependabot/go_modules/golang.org/x/net-0.49.0
• dependabot/go_modules/golang.org/x/net-0.50.0
• dependabot/go_modules/golang.org/x/net-0.52.0
• dependabot/go_modules/golang.org/x/net-0.53.0
• dependabot/go_modules/golang.org/x/net-0.55.0
• dependabot/go_modules/golang.org/x/sync-0.20.0
• feat/acme-DNS-01-challenge
• feat/cache-reaper
• feat/cache-ttl-floor
• feat/connection-pool
• feat/dispatcher-source
• feat/dns-listener
• feat/dns-metrics-skill
• feat/geoblock
• feat/ip2location-cronjob
• feat/mobileconfig
• feat/multiple-blocklists
• feat/proxy-protocol
• feat/reduce-info-level-logging
• feat/reload
• feat/reload-blocklist
• feat/sentry-integration
• feat/top-blocked-domains
• feat/top-domains
• feat/upstream-latency
• feat/upstream-ttl-metrics
• fix/blocklist-age-gauge
• fix/hot-paths
• fix/improved-error-reporting
• fix/no-NXDOMAIN-errors
• fix/round-robin-error-observability
• fix/round-robin-retry
• fix/use-spacesaver-error
• gemini/patch-issue-129-b1f017a
• gemini/patch-issue-131-4aba170
• main
• refactor/error-wrap
• refactor/handle-multiple-questions
• refactor/log-adapters
• refactor/p99-latency-spikes
• refactor/telemetry-goroutine
• test/pi-agent
• testing/integration

Build # 26719937718

Build Type

Pull #124

github

Committed by gemini-pr-agent[bot]

Commit Message

chore: iterative updates from Gemini based on PR comment

I have completed the investigation and fix for the data race issues.

1.  **Compilation Error:** Fixed a duplicate declaration of `DroppedCacheUpdates` in `internal/metrics/dns_metrics.go`.
2.  **Data Race in Tests:** The `go test -race` tool identified data races in the `startLocalDNS` test helper in `internal/forwarder/dispatcher_test.go`, caused by unsynchronized access to `server.PacketConn`. I updated this helper to use `dns.Server.NotifyStartedFunc` to correctly synchronize server readiness, resolving the race conditions.
3.  **Verification:** Confirmed all tests pass successfully with the `-race` detector enabled.

Pull Request Pull Request #124: fix: add race detection and thread-safe sketches

Coverage Stats

6 of 11 new or added lines in 1 file covered. (54.55%)

576 of 1374 relevant lines covered (41.92%)

1282.72 hits per line