rgerum / saenopy

61%

master: 61%

LAST BUILD ON BRANCH fix/material-parameter-order

branch: fix/material-parameter-order

CHANGE BRANCH

x

Reset

• fix/material-parameter-order
• codex/add-macos-dmg
• codex/tolerate-coveralls-outage
• docs/cleanup
• docs/example-viewer-prototype
• fix/nan-safe-reference-states
• master
• t3code/2ba6f67b
• t3code/7fe3ec7f
• t3code/95271684
• t3code/b44aa1cb
• t3code/bcc6f755

Build # 30658140327

Build Type

Pull #93

github

Committed by rgerum

Commit Message

Fix swapped lambda_s and d_s in the default material fallback

SemiAffineFiberMaterial takes (k, d_0, lambda_s, d_s), but the fallback in
TabResultView.calculateStiffness passed 0.055 and 0.032 positionally in the
other order, so it built a material with lambda_s=0.055 and d_s=0.032.

Every other place that names these values has them the other way round:
examples.py, the dynamical single cell example, and the spheroid lookup table
dialog all use lambda_s=0.032, d_s=0.055 for the collagen I 1.2 mg/ml
reference. The three other live call sites of SemiAffineFiberMaterial pass
their parameters in the correct order.

The likely origin is that the lookup table dialog lists the parameters as
"k, d_0, ds and lambda_s" and quotes them in that order, and that order was
typed into a positional call.

This only affects the stiffness display when no material model has been set,
which is the branch that prints "Warning using default material parameters",
but the effect is not small: the two orderings agree below the stiffening
onset and then diverge, giving 16x the stiffness at 30% strain.

Passing the parameters by keyword so the order cannot silently matter again.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #93: Fix swapped lambda_s and d_s in the default material fallback

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

8173 of 13395 relevant lines covered (61.02%)

0.61 hits per line