rentpath / react-ui

73%

master: 87%

LAST BUILD ON BRANCH mpn/fix_listing_carousel_onslide

branch: mpn/fix_listing_carousel_onslide

CHANGE BRANCH

x

Reset

• mpn/fix_listing_carousel_onslide
• @rentpath/react-ui-ag@0.6.0
• @rentpath/react-ui-ag@0.7.0
• @rentpath/react-ui-ag@11.0.3
• @rentpath/react-ui-ag@11.1.5
• @rentpath/react-ui-ag@11.2.0
• @rentpath/react-ui-ag@11.2.1
• @rentpath/react-ui-ag@11.3.0
• @rentpath/react-ui-ag@11.3.1
• @rentpath/react-ui-ag@11.3.2
• @rentpath/react-ui-ag@11.5.0
• @rentpath/react-ui-ag@11.5.1
• @rentpath/react-ui-ag@11.5.2
• @rentpath/react-ui-ag@11.5.3
• @rentpath/react-ui-ag@11.5.5
• @rentpath/react-ui-ag@11.5.6
• @rentpath/react-ui-ag@11.5.7
• @rentpath/react-ui-ag@11.5.8
• @rentpath/react-ui-ag@12.0.0
• @rentpath/react-ui-ag@12.1.0
• @rentpath/react-ui-ag@12.1.1
• @rentpath/react-ui-ag@12.1.2
• @rentpath/react-ui-ag@12.1.3
• @rentpath/react-ui-ag@12.1.4
• @rentpath/react-ui-ag@12.1.5
• @rentpath/react-ui-ag@13.0.0
• @rentpath/react-ui-ag@13.0.1
• @rentpath/react-ui-ag@3.0.2
• @rentpath/react-ui-ag@3.0.4
• @rentpath/react-ui-ag@4.0.1
• @rentpath/react-ui-ag@5.1.1
• @rentpath/react-ui-ag@6.0.0
• @rentpath/react-ui-ag@6.2.0
• @rentpath/react-ui-ag@6.3.0
• @rentpath/react-ui-ag@6.4.0
• @rentpath/react-ui-ag@6.5.1
• @rentpath/react-ui-ag@6.6.0
• @rentpath/react-ui-ag@9.1.0
• @rentpath/react-ui-core@16.2.4
• @rentpath/react-ui-core@16.2.5
• @rentpath/react-ui-core@16.2.6
• @rentpath/react-ui-core@16.3.0
• @rentpath/react-ui-core@16.3.1
• @rentpath/react-ui-core@16.3.2
• @rentpath/react-ui-core@16.3.8
• @rentpath/react-ui-core@16.3.9
• @rentpath/react-ui-core@16.4.0
• @rentpath/react-ui-core@17.0.0
• @rentpath/react-ui-core@17.0.1
• @rentpath/react-ui-core@17.0.2
• @rentpath/react-ui-core@18.0.0
• @rentpath/react-ui-core@18.1.0
• @rentpath/react-ui-core@18.2.0
• @rentpath/react-ui-core@18.3.0
• @rentpath/react-ui-core@18.3.1
• @rentpath/react-ui-core@18.3.2
• @rentpath/react-ui-core@18.4.0
• @rentpath/react-ui-core@19.0.0
• @rentpath/react-ui-core@19.0.1
• @rentpath/react-ui-core@19.0.2
• @rentpath/react-ui-core@19.0.3
• @rentpath/react-ui-core@19.1.0
• @rentpath/react-ui-core@19.1.2
• @rentpath/react-ui-core@19.1.3
• @rentpath/react-ui-core@19.2.0
• @rentpath/react-ui-core@19.3.0
• @rentpath/react-ui-core@19.3.1
• @rentpath/react-ui-rent@4.2.17
• @rentpath/react-ui-rent@4.2.18
• @rentpath/react-ui-rent@4.2.19
• @rentpath/react-ui-rent@4.3.0
• @rentpath/react-ui-rent@4.3.1
• @rentpath/react-ui-rent@4.3.10
• @rentpath/react-ui-rent@4.3.12
• @rentpath/react-ui-rent@4.3.13
• @rentpath/react-ui-rent@4.3.14
• @rentpath/react-ui-rent@4.3.2
• @rentpath/react-ui-rent@4.3.8
• @rentpath/react-ui-rent@4.3.9
• @rentpath/react-ui-rent@5.0.0
• @rentpath/react-ui-rent@5.0.1
• @rentpath/react-ui-rent@5.0.2
• @rentpath/react-ui-rent@5.0.3
• @rentpath/react-ui-rent@5.0.4
• @rentpath/react-ui-rent@5.0.5
• @rentpath/react-ui-rent@5.0.6
• @rentpath/react-ui-tracking@5.0.0
• @rentpath/react-ui-tracking@5.0.1
• @rentpath/react-ui-tracking@5.0.2
• @rentpath/react-ui-tracking@5.0.3
• @rentpath/react-ui-tracking@5.0.4
• @rentpath/react-ui-utils@4.2.10
• @rentpath/react-ui-utils@4.2.8
• @rentpath/react-ui-utils@4.2.9
• AG-4378/data_tag_action
• AG-4378/update_field_datatag
• AG-4944/overflow-class-not-applied
• RD/node-12-upgrade
• RENT-3592
• ab/PE-228-gpr-workflow
• ab/PE-232-update-registry
• ab/yarn-test-workflow
• add-isactive-to-marker
• add-rating-placeholder
• add-redux-repo
• add-scaledSize-redDot
• bb/smoothScrollGalleryWrapper
• bc/add-url-fallback
• bs/650974736/free_draw_controls
• bs/668249505/free_draw_core_component
• bs/add_map_icon
• bs/add_property_title_tag
• bs/add_styles_to_gmap
• bs/change_readme
• bs/changes_for_tagging
• bs/export_free_draw_controls
• bs/gmap_modifications
• bs/mobile_grid_listing_spotlight
• bs/modal_stack
• bs/remove_listings_from_react-ui-ag
• bs/update_listing_card
• bw/AG-5025/Add-overflow-hidden-class
• ck/INVP-443/overlay-class
• ck/carousel-thumbs
• cloudinary
• core-v-bump
• cr_travis_updates
• csc/DX-144
• csc/DX-156
• csc/DX-157
• darnell/kill-flatmap-stream
• data-rating
• dgav/rating-progress
• dh/673931956/allow-multiple-shapes-react-ui
• dt/ag-4972/add-move-in-val
• eh/expose-marker-utils
• eh/small-ts-components
• export-marker
• faster_builds
• fitz/modal-overlay-click
• fitz/radiogroup-unselect
• fitz/remove-rent
• fix-themed-listing-bug
• fix-versioning
• ga/605433729/revert-mapbox-into-core-temporarily
• ga/616095971/mobilemaplisting-clickProps-fix
• ga/617713126/listingcell-event-propagation-fix
• ga/lazyload-photocarousel
• ga/mobilemaplisting-phone-refactor
• ga/mpn/bs/607050974/listing-cell-react-ui-core-updates
• ga/nr/616095971/fix-mobile-map-cta-phone
• ga/nr/616095971/revert-phone-cta-href
• ga/update-babel-preset-to-env
• gaa/624494614/lazyload-listing-photo
• gaa/627459493/srp-mobilegridlisting
• gaa/mobilemaplisting-lazyload-redux
• generic-listing-cell
• greenkeeper/initial
• hp/613128248/prioritize-card-click-for-CTA-btn
• hp/added-LinkList-component-to-react-ui
• hp/added-tagging-placeholder
• improve-drawer-animation
• jl/bug/refactor-moreOptions-buttons
• jl/feature/ULA-Text
• jl/feature/more-options-dataTid
• jl/refactor/remove-moreOptions
• jsral/dateparsing-bug
• jsral/fix-set-state-callback
• lerna_reorg
• lex/fix_photo_onerror
• lex/remove_MobileListing
• lex/remove_ag_gmap
• lex/remove_email_modal
• lf_000_build_first
• lf_000_noop
• lf_000_passing_delete_me
• lf_542_PDP_photo_bug
• lf_iOS_closes_map_annotation
• lf_lazy_loader_tweaks
• marker-export
• marker_index
• master
• menu_item_props_fix
• ml/grey-inactive-pin
• mpn/613135571/support_default_favorite_value
• mpn/615319754/hide_arrows_on_nonactive_listings
• mpn/619763011/desktop_pin_listing
• mpn/625558284/fix_desktop_map_pin_props
• mpn/628904109/add_selected_support
• mpn/678468241/rent-sign-in
• mpn/686665477/move_inline_filters_to_core
• mpn/692614587/fix_listings_bugs
• mpn/add-onChange-to-rgfc
• mpn/bs/ga/607050974/listing_carousel
• mpn/fix_onSlide
• mpn/form_change_release_stuff
• mpn/hnl-378/auto-suggest-updates
• mpn/hnl-378/publish
• mpn/hnl-378/show-selection-on-keys-only
• mpn/hnl520/update-react-themed
• mpn/huh
• mpn/ml/636455802/external_link_email
• mpn/nr/595782316/mobile-map-listing
• mpn/pd/624769677/grid_view_header
• mpn/publish
• mpn/publish2
• mpn/publish3
• mpn/publish4
• mpn/publish_2018-02-28
• mpn/publish_again___
• mpn/radiogroup-fix
• mpn/release-2019-04-30
• mpn/remove-price-filter-props
• mpn/ya/615297106/support_stroke_width_override
• mps/INVP-475/carousel_data_tid_prop
• mps/INVP-559/image-carousel-version
• mps/INVP-685/remove_react_ui_ag
• mps_readme_react_themed
• mps_readme_updates
• mps_readme_updates_cz
• mts/copy_string
• mts/fix_replace_method
• new-gallery
• nm/css-svg
• nm/photo_picture
• nm/pub
• nm/publish
• nm/publish-ratingbar
• nr/595390934/add-onIndexChange-to-ListingCarousel
• nr/607619120/single-family-listing-cell
• of/645468870-addingdatePickerType
• of/deepCall-markerInteraction
• of/fix-card-address
• of/fix-circular-dep
• of/fix-gmap-binding
• of/fix-test-dependencies
• of/gmapinteraction-check-fix
• of/mapbox-upgrade
• of/modalStack
• of/modalstack-default-fix
• of/newspinner
• of/simple-date-picker
• ok/624767748/create-sort-component
• ok/646235681/create-desktop-map-listing
• ok/653535974/listing-not-rerendering-on-prop-change
• onSlide-index-param
• optimize-scu-MobileMapListing
• pd/683686402/more_options_final
• pd/683686402/more_options_last
• pd/683686402/more_options_modal
• pd/gmap_overlay_positioning
• pjo/722560743/cluster-render-fix
• pjo/736625826/map-icon-scale-prop
• pjo/740371798/pin-zindexing
• pjo/listing-structured-data
• pjo/sands-25/ag-pin-sizing
• pjo/sands-37/map-pin-color
• pk_datepicker
• pp/ag_grey_isBasic_pins
• pp/layer_export_gmap_children
• pp/map_layer
• publish--05152018-1045
• publish-03072018-1013
• publish-040202018-0800
• publish-04202018-1645
• publish-04252018-1615
• publish-04262018-1400
• publish-04302018
• publish-05012018-0900
• publish-05022018-0910
• publish-05022018-1210
• publish-05032018-1200
• publish-05042018-1440
• publish-05072018-1030
• publish-05072018-1340
• publish-05092018-1340
• publish-05102018-0950
• publish-05102018-1300
• publish-05112018-0832
• publish-05112018-0900
• publish-05112018-0914
• publish-05122018-1500
• publish-05162018-1000
• publish-05172018-1210
• publish-05182018-0830
• publish-05212018-0425
• publish-05222018-0855
• publish-06012018-1350
• publish-06042018-01340
• publish-06122018-0930
• publish-06122018-1045
• publish-06132018-1010
• publish-06142018-1645
• publish-06212018-1300
• publish-07092018-0815
• publish-07102018-0925
• publish-07112018-1345
• publish-07172018-1520
• publish-07302018-0830
• publish-08012018-1345
• publish-08072018-0810
• publish-08152018-1450
• publish-08282018-1410
• publish-08282018-1515
• publish-08302018-1300
• publish-09042018-1520
• publish-09122018-1720
• publish-09142018-1000
• publish-10012018-1330
• publish-20072018-0354
• publish-2018-08-13-1310
• publish-20180921-1345
• publish-inline-filters-move
• qs/AP-42-SSR-Image-Fix
• qs/fullbleed-carousel-proptypes
• re-enable-draw-on-empty-poly
• remove-schema
• revert-198-ga/lazyload-photocarousel
• revert-356-re-enable-draw-on-empty-poly
• revert-icons
• rex/carousel-on-swipe
• rex/handle-photo-carousel-slide
• rex/render-custom-controls-on-mobile-listing
• rex/slide-to-index
• scaledSize-icons
• separate-mobile-listings
• tadjohnston-patch-1
• thrasher/grid-kill
• tj/add-min-max-zoom
• tj/ag-markers
• tj/babel7
• tj/bump
• tj/bump-versions-manually
• tj/calendar-bug
• tj/calendar-data-tids
• tj/carousel
• tj/carousel-lazy-loading
• tj/clear-marker
• tj/datepicker
• tj/env-fix
• tj/error-on-warnings
• tj/es-modules
• tj/es-modules-all
• tj/eslint-upgrade
• tj/file-removal
• tj/fix-es-modules
• tj/fix-fsevents
• tj/fix-gmap-children
• tj/fix-google-script-loader
• tj/fix-repos
• tj/fix-submit-lead-form-button
• tj/fix-tests
• tj/google-map
• tj/google-maps
• tj/ignore-storybook-build
• tj/map-fixes
• tj/map-lib-change
• tj/map-tweaks
• tj/missing-fallback-bug
• tj/modal-close-data-tid
• tj/modal-refactor
• tj/move-map
• tj/photo-ssr
• tj/photo-stories
• tj/photo-stuff
• tj/pkg-upgrades
• tj/publish
• tj/publish-022718
• tj/publish-030118
• tj/publish-03052018
• tj/publish-03152018
• tj/publish-03202018
• tj/publish-03232018-0900
• tj/publish-04032018-1100
• tj/publish-04082018
• tj/publish-04092018-1437
• tj/publish-04102018-1150
• tj/publish-04112018-0830
• tj/react-bump
• tj/readme
• tj/refactor-freedraw
• tj/remove-marker-title
• tj/reverting-mapbox-gl
• tj/script-load-bug
• tj/selected-icon-tweak
• tj/small-theme-fixes
• tj/ssr-datepicker-bug
• tj/storybook-marker-fix
• tj/update-date-fns
• tj/update-packages
• tj/upgrade-date-fns
• tj/upgrade-fixes
• tj/upgrade-pkgs
• tj/workspaces
• tm/gmaps_markers_zindex
• tm/modify_desktoplisting
• tr/AG-2676/cal-start-date
• travis_review_envs
• try_out_codecov
• tw/INVP-412/fix-modal-stack
• tw/event-bubbling
• tw/fix-undefined-projection
• tw/gmap-fixes
• tw/ie11-event-fix
• tw/infowindow
• tw/layer-events
• tw/marker-events
• tw/on-markers-ready
• tw/overlay-popup
• tw/update-zoom-center
• vis-search-no-match
• visual-search-changes
• working_locally_doc
• ya/544424697/AutoSuggestOnVisibilityChange
• ya/628763578/AutoSuggestMenuChanges
• ya/642141204/ListingCarouselRepeatedClickFix
• ya/652900868/IncreaseListingCarouselDebounceTime
• ya/695314151/disableDrawFiringTwiceFix
• ya/AutoSuggestFieldPassValue
• ya/DestructureOnClick
• ya/Drawer
• ya/DrawerUpdate
• ya/ListingCellClassNameFix
• ya/freeDrawLayerFix
• ya/menu-fix
• ya/menu/fix
• ya/nr/627939416/React-uiOptimizations

Build # 335

Build Type

push

travis-ci

Committed by mneumark

Commit Message

fix(Hybrid Map): fix how onSlide is handled by ListingCarousel

affects: @rentpath/react-ui-ag

[Story](https://rentpath.leankit.com/card/615319754)

* moved call to onSlide prop to updateSelectedIndex
* removed onSlide in render to avoid it overriding stuff in Carousel

Run Details

362 of 611 branches covered (59.25%)

Branch coverage included in aggregate %.

661 of 790 relevant lines covered (83.67%)

18.81 hits per line