renatahodovan / grammarinator

91%

master: 85%

LAST BUILD ON BRANCH linting

branch: linting

CHANGE BRANCH

x

Reset

• linting
• 17.7
• 18.10
• 19.3
• 23.7
• actions-upgrade
• add-conan
• add-lstnr
• adjust-parse
• analyze2
• antlr-4.13
• antlr-4.8
• antlr-cov
• antlr-param
• antlr-up
• antlr-update
• antlr4.12.0
• api-doc
• appveyor
• arg-parse
• argret
• badge
• bump-fbs-24.12.23
• bump-rtd-os-u24.04
• c++-support
• calc_min_sizes
• charsets-rework
• choice
• choice-simp
• cite
• cleanup-cxx-template
• cli-refactor
• codec-enc
• codec-inf
• concept-select-donor
• condvar
• confighpp
• const-mutate-v2
• copy
• copy-resources
• cpp-build-impr
• cpp-indv
• cpp-readme
• ctxm
• custom-weights
• cxx-build-impr
• cxx-build-install-abspath
• cxx-build-subprocess-check
• cxx-std-conf
• cxx-template-comp-error-fix
• dbg-annotate
• dbg-members
• decode
• del-bb
• din-max-depth
• din-max-depth-ctx
• doc
• drop-py36-actions
• dry
• dup-rule
• empty
• encode-fix
• eof-fix
• esc-lit
• ex-html-cpp
• example-ascii
• fbs-24.3.25
• fbs-xxh-header-only
• fbtc-cu
• filter-immutable
• fix-alts
• fix-badge-url
• fix-chain
• fix-cool
• fix-decode
• fix-duprule
• fix-exit
• fix-html-srl
• fix-lint
• fix-lint-default-dict
• fix-model-docs
• fix-not-set
• fix-parse-lit
• fix-parser
• fix-pop-check
• fix-pylint
• fix-pytest
• fix-rec
• fix-rule-id
• fstring-check
• gen-cool
• gen-recursion
• gen-typo
• generate-name
• generator
• gha-fail-fast-false
• gha-pypy311
• gr-lf-cite
• grammar-test-maintenance
• ignore-dotantlr
• img-root
• immut-fix
• immut-parse
• immutable2
• imp-lit
• impr-format
• individual2
• infra-maintenance
• init-after
• inp-form
• input-mutator-selection
• input-reference
• insert-local
• invalid
• json-tree-codec
• label-prefix
• label-up
• lf-memo-2
• lfiles
• license
• license-24
• license-spdx
• lint
• listener-support2
• listener-test
• listeners-enter-exit-cxx
• literals
• master
• master_test
• members
• memo
• merge-tokens
• model-refact
• model-test
• multi-label
• named-decisions
• new-nodes-v2
• new-ops-v5
• no-cleanup
• no-eof
• no-exc
• no-kwargs
• no-obj-super
• no-pass
• no-self-use
• no-vars
• no-yield
• node20
• nodekeytype
• non-gcc-clang-build
• norm-cool
• opt-lookup
• parallel-seed
• parse-eof
• parse-err
• parse-labeled
• parse-public
• parse-readme
• parse-test
• parser-strict
• pass-parent2
• pep8-pyonly
• pkgdata-metadata
• pop-mkdir
• pop-name
• pop-select
• population-empty
• print-fix
• print-tree
• proc-named-ids
• pub-gen
• py-flat
• py3.11
• py35
• py36
• py36-tests
• py37
• py38
• py39
• pylint-fix
• pylint-fixes
• pytest-cov-subprocess
• quant-bt
• random
• random-mutators
• range-error
• readme-grammarinator-generate-html
• recurr_rule_id
• remove-all
• rename-single
• repl-impr
• replquant-maxtokenlimit
• rm-configh
• rule-choice
• rule-dbg
• rule-fixmes
• rule-getattr
• rule-sizes
• rule_id
• rulesize-operators
• save-tree
• serializer
• serializer-cu
• setuptools-fix
• shields-badges
• simp-empty
• simple-dot
• simplify-gentoolhelper
• slots
• sphinx-build-docs-dir-runcmd
• split-line
• sss
• staticdata
• swap-nodes
• templating
• token-limit-review
• token_counts
• travis-appv
• travis-depth-false
• travis-win-osx
• tree-print
• tree-print-fix
• tree_compare
• tuple-ids-v2
• typing-2
• typo-json
• uni
• uniprop
• unlexerrule-name
• unrestricted-init
• update-example
• xxhash-case

Build # 17

Build Type

push

travis-ci

Committed by akosthekiss

Commit Message

Add linting to the testing framework

Pylint's defaults are far from sensible, but at least some of its
checks are useful. The pep8 tool can also be of help. This commit
configures pylint and pep8, fixes some issues discovered by them,
and adds them to the testing framework (tox, Travis CI) to avoid
the fixed issues from creeping back.

Issues fixed:
- logger message formatting (use args to defer substitution),
- eval (avoid),
- import order (standard, custom, local packages),
- indentation,
- type checking (isinstance instead of type),
- regex patterns (raw strings are usually better for escapes).

As a side effect, the commit simplifies tox.ini. The explicit
declaration of the py34, py35, and py36 test environments is
removed as they are provided by tox by default.

Run Details

661 of 728 relevant lines covered (90.8%)

0.91 hits per line