redcross / arcdata

65%

master: 65%

LAST BUILD ON BRANCH serialized-column-migration-step-2

branch: serialized-column-migration-step-2

CHANGE BRANCH

x

Reset

• serialized-column-migration-step-2
• 103-google-distance-matrix
• 119-nokogiri-upgrade
• 119-rails-upgrade
• 125-rails-42
• 125-rails-42-attempt-2
• 126-rails-42
• 126-rails-5-rebased
• 133-tempfile-bug
• 136-admin-fix
• 140-resending-recruitment-messages
• 141-increase-recruitment-window
• 146-add-icons
• 148-fix-show-roster-link
• 154-sentry-logs
• 166-admin-permissions
• 173-damage-assessment
• 174-dat-labels
• 176-dispatch-county
• 185-rename-tables
• 186-update-schedule-welcome-text
• 187-rename-spreadsheet
• 189-add-messaging-to-contact-button
• 190-move-contact-settings
• 191-update-contact-settings-wording
• 192-enlarge-see-all
• 193-remove-on-call-times
• 194-remove-schedule-time-blocks
• 195-Rearrange-scheduling-page
• 198-submit-incident-link
• 201-close-incomplete-incidents
• 203-style-incident-timeline
• 204-increase-attachment-size
• 205-create-invalid-reason-field
• 207-shift-notes-link
• 209-norcen-new-incident-link
• 211-delete-nrocen-incidents
• 211-dispatch-incidents
• 223-paginate-open-incidents
• 224-fix-current-activity-link
• 225-rearrange-create-incident
• 230-fix-travis-ci
• 253-map-boundaries
• 254-motd-admin-default-value
• 255-realignment
• 255-update-vc-import
• 28-client-delete-confirm
• 34-bundle-vc-hours
• FY21
• add-license
• bnazari-SSL_Temp
• bnazari-geocodio
• bnazari-patch-2
• candidate-production
• dependabot/bundler/ffi-1.12.2
• dependabot/bundler/json-2.3.1
• dependabot/bundler/json-jwt-1.13.0
• dependabot/bundler/json-jwt-1.9.4
• dependabot/bundler/loofah-2.6.0
• dependabot/bundler/nokogiri-1.10.9
• dependabot/bundler/puma-4.3.3
• dependabot/bundler/puma-4.3.5
• dependabot/bundler/rack-1.6.13
• dependabot/bundler/rake-13.0.1
• dependabot/bundler/rest-client-2.1.0
• dependabot/bundler/sprockets-3.7.2
• dev-setup
• doc-updates
• fix-travis
• gny
• jm-phone-number-in-case
• main
• master
• reduce-distance-matrix-calls
• sso-vcn
• staging-environment
• tests

Build # 602

Build Type

push

travis-ci

Committed by tfe

Commit Message

SerializedColumns Migration: Step 2.2

Continuing the process of replacing the use of Postgres `hstore`
columns with `jsonb` columns, which Rails has native type casting
support for. Then we'll be able to remove the custom type casting code
from SerializedColumns which has tight coupling into AR internals.

This commit is the second half of Step 2: update SerializedColumns
module to drop hstore-specific type casting machinery and adjust any
call sites as necessary.

Mainly this changes the source for the arcdata_core gem (where
SerializedColumns lives) to the branch that has all the changes for
using JSONB columns for storage. The bulk of the code changes for this
step can be found there.

The API is as close to unchanged as possible, so the necessary changes in this app were minimal:

- A couple factories where previously we set the storage field with a
  full hash of serialized values, rather than calling the setter method
  provided by SerializedColumns. This caused some problems by skipping
  the type casting in the setter and using symbol hash keys when
  elsewhere we expect strings (as they would be if returned from the DB)

- One place where we ran a raw query against the serialized column
  using a special hstore operator (changed to the equivalent JSONB
  operator).

Run Details

5171 of 7996 relevant lines covered (64.67%)

50.87 hits per line