reactjs / react-modal

81%

master: 85%

LAST BUILD ON BRANCH v2.0

branch: v2.0

CHANGE BRANCH

x

Reset

• v2.0
• 3.0.0-alpha
• 3.0.0-rc1
• 3.0.0-rc2
• build/reorganization
• code-coverage
• dependabot/npm_and_yarn/elliptic-6.5.3
• dependabot/npm_and_yarn/elliptic-6.5.4
• dependabot/npm_and_yarn/hosted-git-info-2.8.9
• dependabot/npm_and_yarn/ini-1.3.8
• dependabot/npm_and_yarn/lodash-4.17.19
• dependabot/npm_and_yarn/lodash-4.17.21
• dependabot/npm_and_yarn/socket.io-2.4.1
• dependabot/npm_and_yarn/ssri-6.0.2
• dependabot/npm_and_yarn/url-parse-1.5.1
• dependabot/npm_and_yarn/webpack-dev-server-3.1.11
• dependabot/npm_and_yarn/websocket-extensions-0.1.4
• dependabot/npm_and_yarn/ws-6.2.2
• dependabot/npm_and_yarn/y18n-4.0.1
• fix/appElement-property-detection
• fix/incorrect-path-for-module-in-package-json
• fix/stop-propagating-esc-key-event
• ignoring-dot-babelrc
• master
• missing-2015-transformer
• next
• ping-coveralls
• saucelabs
• v1
• v2.0.0
• v2.0.1
• v2.0.2
• v2.0.6
• v2.0.7
• v2.1.0
• v2.2.0
• v2.2.1
• v2.2.2
• v2.2.3
• v2.2.4
• v2.3.1
• v2.3.2
• v2.3.3
• v2.4.1
• v3.0.0
• v3.0.2
• v3.0.3
• v3.0.4
• v3.1.0
• v3.1.10
• v3.1.11
• v3.1.12
• v3.1.13
• v3.1.2
• v3.1.3
• v3.1.4
• v3.1.5
• v3.1.6
• v3.1.7
• v3.1.8
• v3.1.9
• v3.11.1
• v3.11.2
• v3.12.1
• v3.13.1
• v3.14.1
• v3.14.2
• v3.2.1
• v3.3.1
• v3.3.2
• v3.4.1
• v3.4.2
• v3.4.3
• v3.4.4
• v3.4.5
• v3.5.1
• v3.6.1
• v3.7.1
• v3.8.1
• v3.8.2
• v3.9.1
• v4

Build # 127

Build Type

push

travis-ci

Committed by diasbruno

Commit Message

[fixed] respect closeTimeoutMS during unmount

Fixes issue #17: "When the modal is unmounted, it will abruptly close,
not waiting for any animations to finish."

The bug was caused by the Modal component unmounting the portal
immediately in `componentWillUnmount` regardless of whether the portal
is currently closing or would animate to close.

Now when a Modal has a non-zero `closeTimeoutMS`, the Modal inspects the
portal state before closing.  If the portal is open or closing, but not
closed, it waits to unmount the portal.  If the portal is open and not
already closing, the Modal calls closeWithTimeout() to trigger the
close.

Adds test to ensure portal DOM persists after Modal is unmounted when
the Modal has a `closeTimeoutMS` set.  Updates existing tests to
properly unmount test Modal instances.

Run Details

11 of 11 new or added lines in 2 files covered. (100.0%)

231 of 285 relevant lines covered (81.05%)

17.04 hits per line