pyscaffold / configupdater

96%

master: 97%

LAST BUILD ON BRANCH improve-optionxform-issue

branch: improve-optionxform-issue

CHANGE BRANCH

x

Reset

• improve-optionxform-issue
• HEAD
• add-adopt-option-test
• add-fallback
• add-missing-type-hint
• add-py-typed
• add-type-hints
• api_token
• attach-container
• badges_template
• cleanup-insert
• clear-remove-all
• deepcopy-option
• deepcopy-section
• deepcopy-toplevel
• dev
• fix-type-errors
• fix15
• fix_liskov
• fix_option
• fix_retval
• fix_setitem_in_document
• fix_type_errors
• improve-errors
• improve-validation-consistency
• issue-10
• issue-31
• issue-55
• issue-68
• link-missing
• main
• make-add-line-protected
• markdown-everywhere
• master
• mention-deepcopy-docs
• ml-comments
• modify-multiline-values
• pre-commit-ci-update-config
• psf-license
• pyscaffold-update
• pyscaffold-v4
• reorganise
• section_comment
• simplify-coverage
• type-improvements
• update-ci
• v0.1
• v0.1.1
• v0.2
• v0.3
• v0.3.1
• v0.3.2
• v0.3.2rc2
• v1.0
• v3.0
• v3.0.1
• v3.0rc1
• v3.0rc2
• v3.1
• v3.1.1
• v3.2
• v3.2b1
• work-on-optionxform
• workaround

Build # #252

Build Type

push

coveralls-python

Committed by abravalheri

Commit Message

Improve handling of optionxform when section/option is detached

This commit should fix #53, expanding on the change proposed in #48.

It should improve consistency in the case the user configures a
customised `optionxform` on ConfigUpdater, for 2 reasons:

- If the custom `optionxform` is doing something weird that is
  incompatible with `str.lower` (e.g. splitting on the first upper case
  character and joining with `_`), it is better to leave `option.key` alone...

- When importing an option form a different object, the `optionxform`
  transformation that matters is the one configured in the receiving
  object, not the one from the source.

Run Details

250 of 270 branches covered (92.59%)

Branch coverage included in aggregate %.

765 of 785 relevant lines covered (97.45%)

0.97 hits per line