pulibrary / plum

96%

master: 99%

LAST BUILD ON BRANCH remove_cruft

branch: remove_cruft

CHANGE BRANCH

x

Reset

• remove_cruft
• 1004-image-remote-hyrax
• 1004-image-work-remote-metadata
• 1006-ingest-existing-scanned-maps
• 1020-image-work-form
• 1022-fix-geoblacklight-hyrax
• 1022-fix-geoserver-hyrax
• 1034-batch-upload
• 1078-geo-works-events
• 1132-description
• 1132-description-property
• 1135-thumbnails
• 1163-gbl-visibility
• 1165-geo-thumbnail
• 1195-gbl-refs
• 1213-map-set
• 1215-scanned-map-fgdc
• 1259-mapset-ingest
• 1295-mapset-bbox
• 1308-gbl-mapset
• 1320-dct-source
• 1324-delete-map-set-children
• 1333-data-type
• 1340-fgdc-whitelist
• 1345-gbl-update
• 1347-gbl-caching
• 1349-rabbit-connections
• 1411-update-pul-uv-rails
• 1434-image-work-manifest
• 1477-geo-ark-urls
• 1479-geo-permissions
• 1482-geo-works-mint
• 1485-geo-editor-permissions
• 839-pending-uploads
• 840-thumbnails
• 844-derivative-path
• 845-landing-page
• 845-welcome-page
• 851-manifest-event
• 859-geoserver-docker
• 865-fonts
• 867-geoserver-staging
• 871-geo-derivatives
• 872-arks-workflow
• 875-labels
• 883-metadata-extraction
• 886-geo-server-path
• 887-collections
• 890-geoblacklight
• 892-geo-file-manager
• 893-messaging-status
• 905-subjects
• 920-cc-2-0
• 994-scanned-documents
• OSD
• aardvark
• abilities
• access_use
• admin-menu
• admin-role-task
• admin-user-docs
• admins-can-do-anything
• af_noid_fix
• after-bulk-edit
• after_create_html
• all-notable
• all-the-roles
• all_collection_dont_embed_manifests
• all_collections_manifest
• all_collections_permissions
• all_the_metadata
• always-noids
• annotation_lists
• append-files
• arks-point-to-public-urls
• attach-mets
• authorities_json
• authorized_users
• back-to-html
• background-ingest
• background_bulk_ingest
• barcode
• barcode-autofocus
• better_pid
• bigger_manifest_url
• bitonal
• blacklight-js
• blacklight6
• box-jsonld
• box_workflow
• boxes
• branding
• browse_everything
• browse_everything_ingest_later
• browse_everything_restartable
• bulk-edit-error
• bulk-fileset-link
• bulk-ingest
• bulk_labeller
• bulk_mark
• bulk_update
• cached_manifests
• cap-geo-derivatives
• capybara-warnings
• cas_login
• cascading-permissions
• cc_version_bump
• child_scanned_book_indexing
• cleanup
• cleanup-geo-derivatives
• cleanup-logging
• cleanup-members
• collection-counts
• collection-display
• collection-form
• collection-membership-migration
• collection-tasks
• collection_bug
• collection_manifests
• collection_no_structures
• collection_slugs
• collections
• collections-on-create
• color_pdf_toggle
• color_pdfs
• complete_collection_rake_task
• completer
• controlled_vocabulary_qa
• controller-breakup
• copy_file_always
• coverage-update
• coveralls-parallel
• create-another
• datadog
• datadog_in_dev
• datadog_sidekiq
• datatables
• dates
• db-minter-state
• dce-date
• dce_date
• ddtrace_only_prod
• default-order
• deliver_later
• deploy_fixes
• deprecation-warnings
• deprecations
• derivative_service_hyrax
• detect-duplicates
• disable-suggest
• disable_redirect_for_lookup
• disable_updating_ark_metadata
• disabled-links
• distributed_plum
• dont_create_thumbnail
• dont_return_false
• download_multiple_images_as_zip
• duplicate-exclude-current
• edit-link
• enhance-geo-works-forms
• ephemera-editor
• ephemera-form
• ephemera-linked-data
• ephemera-member-display
• ephemera-project
• ephemera-sort-title
• ephemera_folder_work
• error_fix
• es6
• events
• events_update
• external_md
• extract-vector-geom
• fallback-image
• feature-list
• file-count
• file-set-display
• file_manager_permissions
• file_manager_select_css
• file_set_view
• fill_out_pudl_collections
• find_by_section
• find_parent_from_child
• fits-debug
• fix-cleanup-derivatives-specs
• fix-deprecations
• fix-mapset-gbl
• fix-mapset-gbl-presenter
• fix-migrations
• fix_barcode
• fix_ci
• fix_collection_manifests
• fix_coverage
• fix_created_in_manifest
• fix_deploy
• fix_environment_for_cache_clear
• fix_errors
• fix_external_url
• fix_facets
• fix_ingest_bug
• fix_label_editor
• fix_language_service
• fix_login_link
• fix_manifest_display_permissions
• fix_rabbit
• fix_reorder
• fix_resque_bug
• fix_role_management_link
• fix_typo
• fix_upload_set
• fix_vary_header
• fix_workflow
• fixture_images
• flag
• flash-alert-update
• folder-jsonld
• form-field-text-color
• fulltext_work
• gc-0-3-2
• gem-updates
• generate_hocr
• geo-content-note
• geo-indexer
• geo-works
• geo_concerns_test
• geo_origin_qa
• grid-first
• grocer
• hack_fedora_connection
• hide-access-note
• hide-add-content
• hide-date-created
• hide-empty-ocr
• hide-lease-and-embargo
• home-page
• honeybadger
• https-bibdata
• hyrax
• hyrax1rc
• id-above-title
• id-title-mutex
• iiif-auth
• iiif-fields
• iiif-lookup
• iiif-manifest-reference
• iiif_manifests
• iiif_properties
• iiif_thumbnails
• iiif_validation
• image-editor-role
• image-server-thumbnails
• index-view-fields
• indexing-collection-slug
• ingest-local-id
• ingest-rescue
• ingest-viewing-hint
• ingest_bug_with_manifest_permissions
• ingest_categories
• ingest_scanned_maps_service
• issues-1174-jrgriffiniii-remove-file-set-edit-tabs
• issues-1336-jrgriffiniii-standardize-vector-work-show
• issues-1401-griffinj-extend-date-builder
• issues-1446-jrgriffiniii-unauth-pdf-download
• issues-1472-jrgriffiniii-fix-osd-file-manager
• jettywrapper
• job_priorities
• jp2_derivatives
• js-tests-readme
• jsonld
• kakadu
• label-tiles-spiffup
• lae-ingest
• lae_workflow
• language-date-display
• language-display
• less_workers
• lib_proc4
• link-before-files
• link-to-parent
• linked-data-failsafe
• literals_in_manifest
• local_identifier
• location
• logical-structure
• logical_order
• logo-and-rights
• logo-fix
• maintain_context
• manifest-collections
• manifest-lookup
• manifest_metadata
• manifest_token_authentication
• manifests-test
• master
• member_of_collections
• merge_reorder_label
• metadata-display
• metadata-error
• mets-fileset-titles
• mets-ingest
• mets-order
• mets-rtl-non-paged
• migrate-state
• minter-statefile
• missing-physical-structmap
• more-geo-fields
• more_efficient_identifier
• more_metadata
• multi-part-hint
• multi-step-ingest
• multi-volume-members
• multi-volume-thumbnails
• multi-volume-work
• multi_volume_work_view
• multiple_labels_for_manifest
• mutually-exclusive-destruction
• mvw-structures
• mvw_manifests
• mvw_structure
• navigation_date
• new-facets
• new_cc
• new_relic
• new_structure_editor
• nil-viewing-hint
• no-pdf
• no_number_labeling
• objstate
• ocr-language-filtering
• ocr_language
• order_vocabularies
• ordered_file_sets
• ordering-fix
• organization-that-has-made-the-item-available
• osd_info_json
• osd_modal_update
• osd_modal_viewer
• osullivan_rename
• pagination
• pairtree_derivatives
• parallel_titles
• pdf
• pdf-cover
• pdf-cover2
• pdf-outline
• pdf-utf8
• pdf_caching
• pdf_coverpage
• pdf_metadata
• pdfs
• pipeline-test
• portion-note-for-dupes
• portion_note_property
• prawn_pdf_compress
• predicates
• prevent-phantomjs-install
• prevent_duplicate_nodes
• proc6
• proc6-retry
• profile_iiif
• profile_iiif_manifests
• pudl-id
• pudl-mapping
• pudl3_mvw
• pul_metadata_services
• pulfa
• pulfa-errors
• pulfa-ingest-improvements
• pulfa-metadata
• pulfa-shared-dirs
• pulfa_updates
• pull-from-jsonld
• queue-task
• rails5
• rails5x
• rbtrace
• read_only_metadata
• readme-dependenices
• redis_config
• reduce-deprecations
• refactor_manifest_builder
• refresh_bibdata
• regenerate-derivatives
• reload-workflows
• remove-attach-file
• remove-extra-facets
• remove-instructions
• remove_collection_ids
• remove_collection_viewer
• remove_fm_toggle
• remove_hsh
• remove_metadata_fields_from_iiif
• remove_multiple_false
• rendering
• reorder_pages
• reorder_ui
• repo-ocr
• representative-media
• resource_identifier
• retired
• retrieval
• retry-queue
• review
• rights-breaks
• rights-cleanup
• rights-impl
• rights-note
• role-based-notification
• rollback-button
• routes_refactor
• rtl_display
• rtl_fonts
• ruby-prof
• sammelband_manifests
• save_notification
• scaling
• scanned-resource-creation-context
• scanned-resources
• search_by_identifier
• section-duplication
• see-also-source-metadata
• selecting_iteration
• shared-uploads-dir
• show-metadata-source-id
• show-page-number
• show_metadata
• sidekiq
• sidekiq-web
• sidekiq_namespace
• sipity-workflow-mets
• sipity-workflow-state
• skip-additional-fields
• skip-file-ingest
• slowdown_sidekiq
• slug-noid
• solr-6.0.1
• solr-6.1.0
• solr5
• solr6
• speedup_iiif_collections
• staging
• start_canvas
• state
• state-completion
• state_workflow_lite
• static_assets
• structure_editor_collapsing
• structure_editor_levels
• structure_fix
• sub-vocabularies
• such_coverage
• suppress-embargo-lease
• suppress-source-metadata
• suppress-virus-warnings
• system-sort
• templates
• tesseract_from_apt
• tesseract_remove_page_mode
• test
• test-cap-geo-derivatives
• test-coverage
• test_empty
• thumbnail_edit
• thumbnail_from_work
• thumbnail_selector
• thumbnails
• title_sort
• titles-for-edit-views
• toggle_grid
• token-label
• token_auth
• top_range_label
• ui-fixes
• ui_update_fix
• underline_pdf
• universal-readers
• universal_viewer_test
• update-cc
• update-ezid
• update-ezid-after-ingest
• update-hyrax
• update-readme
• update-remote-metadata-if-changed
• update-test-setup
• update_at
• update_browse_everything
• update_capistrano_passenger
• update_cc
• update_curation_concerns
• update_everything
• update_hyrax
• update_hyrax_again
• update_hyrax_even_more
• update_ldp
• update_pul_metadata
• update_sidekiq
• update_universal_viewer
• updates
• upload-helper-text
• url-fields
• use_cc_file_manager
• use_tesseract_command_line
• uv-theme
• uv_config
• validate-files
• validate-from-checksum
• validate-rake
• vatican-copyright
• vatican-objects
• view-edit-updates
• vocab
• vocab-descriptions
• vocab-import
• vocab-labels
• vocab-linked-data
• volumes-first
• welcome-refactor
• whitespace_search
• wide-open
• worker2
• workflow_note
• working-read-permissions
• z_noid_template

Build # 56

Build Type

Pull #59

circleci

Committed by terrellt

Commit Message

Clean up ScannedBook.

Pull Request Pull Request #59: Small refactor of ScannedBook

Run Details

16 of 16 new or added lines in 2 files covered. (100.0%)

387 of 404 relevant lines covered (95.79%)

2.69 hits per line