pulibrary / orangelight

96%

main: 96%

LAST BUILD ON BRANCH i4294_refactor_requests_patron_iii

branch: i4294_refactor_requests_patron_iii

CHANGE BRANCH

x

Reset

• i4294_refactor_requests_patron_iii
• 1918-header-small-screen
• 2174-submit-btnsearch-bar
• 2825_link_to_dataset
• 2965-partOf
• 3036-mobile-back-btn
• 3230_do_not_show_detailed_status
• 3302-main-branch-failure-v10
• 3302-main-branch-failure-v12
• 3302-main-branch-failure-v9
• 3302-main-circleci
• 3333-bookmark
• 3346-3347-remove-unused-links
• 3349_capture_more_in_clancy_errors
• 3446-lower-abc-size
• 3450_mapset_multiple_viewers
• 3456_stackmap_bug
• 3479-open-plasma
• 3503_address_deprecations
• 3505-electronic-delivery
• 3512-requestsjs
• 3523_purge_bookmarks_solr
• 3546-update-blacklight-marc
• 3557-resource-sharing
• 3557-resource-sharing-pc
• 3567-request-form
• 3567-request-toggle-onoff
• 3615-accessibility-docs
• 3648-remove-copyfield
• 3748-algo-switch-ui
• 3789-biased-results-form-b
• 3804-recap-guest-user
• 3808-search-algo
• 3913-availability-js-fetch
• 3913-availability-js-remove-title
• 3918-ga-cookie-domain
• 3979-catalog-header
• 3988-scsb-search-results
• 4001-scsb-search-use-bibdata-status
• 4081-bootstrap5-BL8-rebase
• 4095-FaST-subject-facet-keyword
• 4130-cleanup
• 4356-remove-cdl
• 4359-put-back-lighthouse
• 4430-print
• 4453-update-where-to=find-it
• 4489-citation-display
• 4535-record-email-portfolio
• 4557-honeybadger-env
• 4565-remove-alert-health-check
• 4566-set-pagination
• 4567-feedback-options-main
• 4576-remove-online-badge-finding-aids
• 4578-holdings-locations-sorting
• 4581-handle-patron-errors
• 4601-update-search-widgets-record-page
• 4608-LuxDataTable
• 4640-skip-links-main
• 4641-form-validation
• 4641-modal-form-submit-close
• 4641-partof
• 4641-submit-form-once
• 4667-remove-old-stackmap-code
• 583_display_take_three
• Blacklight8-upgrade-v2
• accessibility-3958-i3677-atkinson-font
• accessibility-template-update
• add-back-fields-to-email-in-bl8
• add-font-src
• add-reek-to-ci
• add_q_to_test
• advanced-search
• advanced-search-no-rows
• advanced_search_translation_bug
• aeon-constituent-record-metadata
• allow_language_facet_in_facet_suggest_query
• applicationjs-require-tree
• archival-item-icon
• authority-vocab-updates-v2
• blacklight-8.7.0
• blacklight-backport-testing
• blacklight-deprecations
• blacklight-marc
• blacklight8-upgrade
• blaklight-v-readme
• browsing-spec-selectors
• browsing-spec-v2
• bundle-exec-mem
• bundle-update
• bundle-update-3-4-1
• cache-facet-values-for-advanced
• capybara_improvements
• catalog-indexer-staging2
• center-icon
• change_comment_form
• christinach-patch-1
• ci_check
• ci_test
• clear-cdl-request-item
• codeql-docs
• config-test
• content-security-policy
• coverage-in-ci-only
• csp-v2
• databases-icon
• dependabot/bundler/actionpack-7.1.5.1
• dependabot/npm_and_yarn/nanoid-3.3.8
• deprecated-synonym-factory
• doc-content-warning
• dry-enum-value
• email_portfolio_link
• email_portfolio_link_fresh
• erblint-accessibility
• even-more-deprecations
• extract-eligibility-classes
• fix-cas-login-for-devs
• fix-circleci-chrome
• fix_chromedriver_tests_locally
• flash_revisited
• footer-black-color
• gc-profiler
• git-hooks
• header-in-container
• hitting_right_js-test
• i2613-env
• i2889_bookmark_limit-v2
• i3192_oversize_cd_browse
• i3328_feedback_bar
• i3329_ask_a_question
• i3338-non-search-param
• i3351-search-bar-on-advanced
• i3367-view-larger
• i3371_run_in_browser
• i3412_built_in_advanced_search_form
• i3421-no-more-old-borrow-direct-v2
• i3426-harmful-language-followup
• i3428-new-stackmap-language-2
• i3433_electronic_access
• i3476_prod_update
• i3476_qa_update
• i3498_requests_html_bug
• i3535-remove-route
• i3554-missing-illiad-elements
• i3555_illiad_oclc
• i3561_map_volume_info
• i3565_display_653_as_text
• i3569-illiad-request-process
• i3573_mini_profiler
• i3574-aeon-thesis-author
• i3583-marquand
• i3597-aeon-multiple-items
• i3599_too_many_aeon
• i3610_do_not_block_db_with_rake_tasks
• i3629_use_env_for_redis_db
• i3645-numismatics-builtin-advanced-2
• i3664-json-dsl-error
• i3668
• i3677-atkinson-font
• i3702_edit_search_advanced_rebased
• i3810-banner
• i3823-group1-doc-algo
• i3835-highlighting-doc
• i3864-ayn-sorting
• i3909-libanswers-api
• i3977_affiliates_can_request_on_order_and_in_process_items
• i4052_add_content_advice
• i4080_facets_advanced_search
• i4106-facets-on-left-side
• i4138_left_anchored_search
• i4138_left_anchored_search_ii
• i4176_remove_unused_methods
• i4187_previous_next_to_view_component
• i4196_remove_alma_hold_request
• i4250_recap_eligibility
• i4294_refactor_requests_patron
• i4306_sort_bookmarks_by_lib
• i4438_marquand_ineligible_for_ill
• i4449_browse_list_ordering
• i4471_bookmark_fix_on_bl_7
• i4472-backwards-compatible-retrieve-a-solr-doc
• i4485-numismatics-form
• i4486_view_component_for_email
• i4499_catalog_qa
• i4523_close_suggest_correction_modal
• i4525-display-holdings-from-bound-withs
• i4568-pagination-bookmarks
• i4595-more-in-series
• i4597-language-facet
• i4597-language-facet-v2
• i4637-series-title-search
• i4655-server-side-validation
• illiad_patron_refactor
• inherit_record_mailer
• json5
• json5-parse
• keep-one-stub-holding-locations
• left_anchor_iii
• libanswers-harmful-language-form
• light-aeon-refactor
• lighthouse-back
• load7.1-configs
• lux-5.5.1
• lux-upgrade-5.8.1
• lux-wrapper-width
• mailcatcher_on_qa_config
• mailcatcher_on_qa_config_bl8
• main
• merge_availability_experiment
• microform-facet-icon
• mini-profiler
• more-deprecations
• more_deprecation
• move-excessive-paging
• move-feedback-form-to-forms
• move-holding-location-under-request
• no-add-facet-fields-to-solr-request
• no-framework-defaults
• no-sticky-harmful-content-bar
• paging_recap_request_emails
• postgres-container-error
• rails-7-2
• refactor-more-ctx
• refactor_bibliographic_display
• refactor_holding_block_search
• refactor_holding_location_stub
• refactor_illiad_patron
• refactor_patron_iv
• refactor_patron_v
• refactor_stub_raw_from_catalog
• refactor_top_field_render
• remove-aeon-openurl-method
• remove-chosen
• remove-file
• remove-jquery-again
• remove-launchy
• remove-long-skipped-tests
• remove-more-commented-code
• remove-partner-system-id
• remove-pivot-facet-customization
• remove-postgres-auth
• remove-tooltip
• remove-unused-gem
• remove-unused-hidden_fields_holding
• remove-unused-method
• remove-unused-methods
• remove-unused-uv-class
• remove_advanced_search_views
• remove_blacklight_facet_from_controller_level_helpers
• replace-pull-right-left
• request-location-object
• requests-docs
• requests-form-v5
• requests_test_refactor
• require_identifier
• revert
• revert-blacklight8-upgrade
• router-finish-refactor
• ruby-3-4
• ruby3-3
• separate-modal-body-footer
• set-sample-itembarcode
• sidekiq-email
• simplify-advanced-search-solr-query
• simplify_collection_code_checks
• sql-injection-vulnerability
• stackmap_concern
• start-using-requests-holding-object-more
• string-rtl
• stringex-update
• tag_request_specs
• test-main-branch
• test_search_constraint_fix
• title_starts_with
• try-remove-search-fields
• try-removing-aeon-from-application-helper
• update-aeon-diagram
• update-browser-tools
• update-bunlder-v
• update-chrome-circleci
• update-dependencies
• update-footer-and-lux-version
• update-footer-with-new-Library-links
• update-jquery
• update-lux
• update-qa-staging-deploy
• update-solr-configs
• update_account_docs
• update_advanced_search_translations
• update_bookmarks_doc
• update_solr_conf
• update_vite
• updates
• upgrade-alma-gem
• upgrade-dependencies-2024-05-03
• upgrade-eslint9
• upgrade-zeitwerk
• upgrade_gems
• upgrade_node
• use-blacklight-color-sin-requests
• use-blacklight-fix
• use-holding-object-more
• use-init-params
• use-solr-params-for-notes-publisher
• use_patron_for_requests_router
• use_rails_config_for_devise_secret_key
• use_search_service_in_rescue
• vendor_test_not_pending
• view-comp-api-slot
• wording_updates
• wrap-partials-in-index-document-component
• zeitwerk
• zeitwerk-upgrade

Build # 4bfa9527-7924-46da-8135-987f7112a742

Build Type

Pull #4316

circleci

Committed by maxkadel

Commit Message

Clarify between patron object and patron_hash

- Update method names and add comments
  - Generally do not favor names that include verbs like "build" but name the thing that has been built

Pull Request Pull Request #4316: Clarify between patron object and patron_hash

Run Details

27 of 28 new or added lines in 1 file covered. (96.43%)

6016 of 6264 relevant lines covered (96.04%)

1440.02 hits per line