pulibrary / bibdata
91%
main: 91%

LAST BUILD BRANCH: romanized-south-asian-proof-of-concept
DEFAULT BRANCH: main
Repo Added
Files 198
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH sidekiq-connection_pool
branch: sidekiq-connection_pool
CHANGE BRANCH
x

coverage: 90.522%. Remained the same
7cd0b188-4154-408c-983a-5c36ee59ffb9

Pull #3280

circleci

christinach 
This part was moved in pull request
https://github.com/pulibrary/bibdata/pull/3281/changes/9c8450db0

In this commit we keep only the require 'sidekiq/api'

refactor the helper test method run_all_callbacks

zadd - a redis command that adds a member to a sorted set with a numeric score.
Redis sorted sets store members in order by their score.

Pro 7 — score based when Batch.new was called creation time + expiry:
m.zadd("batches", @created_f + expiry, bid)

Pro 8 — score based when the jobs block finishes, now + expiry:
m.zadd("batches", (Time.now + expiry).to_f, bid)

This difference changes to_a ordering only in tests because of the Sidekiq::Testing.inline!: with inline! the jobs calls perform_async which runs the job synchronously. this job calls index_next_dump
to_a order in pro7 is [parent,child] <- ZRANGE
to_a order in pro8 is [child, parent] <- ZRANGE

In pro7 the test assumes that to_a.last is the child because of the ZRANGE.
In pro8 the parent will not finish until everything inside the parent block has run. because of the ZRANGE if we use to_a.last the parent will wait for everyhting inside to run then it will run last and the reindex! will call .wipe! and delete the records that were indexed from the child. So in this case to_a.last will call the parent.
Pull Request #3280: Sidekiq connection pool

11012 of 12165 relevant lines covered (90.52%)

84.44 hits per line

Relevant lines Covered
12165 RELEVANT LINES 11012 COVERED LINES
84.44 HITS PER LINE
Source Files on sidekiq-connection_pool

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
7cd0b188... sidekiq-connection_pool This part was moved in pull request https://github.com/pulibrary/bibdata/pull/3281/changes/9c8450db0 In this commit we keep only the require 'sidekiq/api' refactor the helper test method run_all_callbacks zadd - a... Pull #3280 christinach circleci
90.52
5c71f188... sidekiq-connection_pool refactor the helper test method run_all_callbacks zadd - a redis command that adds a member to a sorted set with a numeric score. Redis sorted sets store members in order by their score. Pro 7 — score based when Batch.new was called creation tim... Pull #3280 christinach circleci
90.52
e3fbab3e... sidekiq-connection_pool refactor the helper test method run_all_callbacks zadd - a redis command that adds a member to a sorted set with a numeric score. Redis sorted sets store members in order by their score. Pro 7 — score based when Batch.new was called creation tim... Pull #3280 christinach circleci
90.52
c00e6ba8... sidekiq-connection_pool refactor the helper test method run_all_callbacks notes: Pull #3280 christinach circleci
90.52
c3387a99... sidekiq-connection_pool refactor the helper test method run_all_callbacks notes: Pull #3280 christinach circleci
90.52
cbac710a... sidekiq-connection_pool refactor the helper test method run_all_callbacks notes: Pull #3280 christinach circleci
90.52
08697523... sidekiq-connection_pool refactor the helper test method run_all_callbacks notes: push christinach circleci
90.52
cc28426d... sidekiq-connection_pool bundle update connection_pool to 3.0.2 bundle update sidekiq ~> 8.0.10 push christinach circleci
90.52
See All Builds (4203)