ptondereau / ext-php-rs

66%

master: 66%

LAST BUILD ON BRANCH fix/string-prop-getter-zend-string-leak

branch: fix/string-prop-getter-zend-string-leak

CHANGE BRANCH

x

Reset

Sync Branches

• fix/string-prop-getter-zend-string-leak
• feat/cache-slot-property-lookup
• feat/module-globals
• feat/sapi-trait-and-zts
• feat/static-property-descriptors
• fix/729-binary-interned-heap-corruption
• fix/clippy-1-95-0
• fix/null-pointer-sapi-trampolines

Build # 25812954678

Build Type

push

github

Committed by ptondereau

Commit Message

docs(prop): document the Exception::getMessage refcount leak

Hit this while building a PHPStan rule on top of biscuit-php and noticing
memory growing on every datalog parse error. Tracking it down: any
`#[php(prop)]` field holding an owned refcounted type (String, Vec, etc.)
leaks one zend_string per call when PHP's Exception::getMessage reads it.
Direct property access (`$obj->prop`) is unaffected — only the
`zval_get_string + RETURN_STR` pattern used by Exception's final C
methods triggers the orphaned refcount.

Adds a regression test (marked `#[ignore]` so CI stays green) and
documentation on the `#[php(prop)]` attribute with two workarounds:
either rename the shadow field, or mirror to the parent's real slot via
`zend_update_property_stringl`. Proper fix needs either an upstream PHP
patch or a deeper change to how field props store their value.

Coverage Stats

8653 of 13065 relevant lines covered (66.23%)

33.38 hits per line